[INFO] updating cached repository saresend/shack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saresend/shack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saresend/shack" "work/ex/clippy-test-run/sources/stable/gh/saresend/shack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saresend/shack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saresend/shack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saresend/shack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saresend/shack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3773d62601ca91564fbd10c62859297504807cd9 [INFO] sha for GitHub repo saresend/shack: 3773d62601ca91564fbd10c62859297504807cd9 [INFO] validating manifest of saresend/shack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saresend/shack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saresend/shack [INFO] finished frobbing saresend/shack [INFO] frobbed toml for saresend/shack written to work/ex/clippy-test-run/sources/stable/gh/saresend/shack/Cargo.toml [INFO] started frobbing saresend/shack [INFO] finished frobbing saresend/shack [INFO] frobbed toml for saresend/shack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saresend/shack/Cargo.toml [INFO] crate saresend/shack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saresend/shack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saresend/shack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 366ff7053609f82e80a235110e2858bcaf6688fdfc16be39b0ec866049ceb219 [INFO] running `"docker" "start" "-a" "366ff7053609f82e80a235110e2858bcaf6688fdfc16be39b0ec866049ceb219"` [INFO] [stderr] Checking app_dirs v1.2.1 [INFO] [stderr] Checking serde_json v1.0.16 [INFO] [stderr] Checking shack v0.1.1 (/opt/crater/workdir) [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/database.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | f.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/database.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | f.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/database.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if let Err(_) = fs::metadata(&database_url()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 124 | | let cont = Data { elements: vec![] }; [INFO] [stderr] 125 | | let mut f = File::create(&database_url()).unwrap(); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | f.write_all(serde_json::to_string(&cont).unwrap().as_bytes()) [INFO] [stderr] 128 | | .unwrap(); [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____- help: try this: `if fs::metadata(&database_url()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `shack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/database.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | f.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/database.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | f.write(b"\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/database.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if let Err(_) = fs::metadata(&database_url()) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 124 | | let cont = Data { elements: vec![] }; [INFO] [stderr] 125 | | let mut f = File::create(&database_url()).unwrap(); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | f.write_all(serde_json::to_string(&cont).unwrap().as_bytes()) [INFO] [stderr] 128 | | .unwrap(); [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____- help: try this: `if fs::metadata(&database_url()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `shack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "366ff7053609f82e80a235110e2858bcaf6688fdfc16be39b0ec866049ceb219"` [INFO] running `"docker" "rm" "-f" "366ff7053609f82e80a235110e2858bcaf6688fdfc16be39b0ec866049ceb219"` [INFO] [stdout] 366ff7053609f82e80a235110e2858bcaf6688fdfc16be39b0ec866049ceb219