[INFO] updating cached repository sapphie132/sapphogram [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sapphie132/sapphogram [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sapphie132/sapphogram" "work/ex/clippy-test-run/sources/stable/gh/sapphie132/sapphogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sapphie132/sapphogram'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sapphie132/sapphogram" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphie132/sapphogram"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphie132/sapphogram'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd309a6b219728b6c0922653218d715b43d04165 [INFO] sha for GitHub repo sapphie132/sapphogram: cd309a6b219728b6c0922653218d715b43d04165 [INFO] validating manifest of sapphie132/sapphogram on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sapphie132/sapphogram on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sapphie132/sapphogram [INFO] finished frobbing sapphie132/sapphogram [INFO] frobbed toml for sapphie132/sapphogram written to work/ex/clippy-test-run/sources/stable/gh/sapphie132/sapphogram/Cargo.toml [INFO] started frobbing sapphie132/sapphogram [INFO] finished frobbing sapphie132/sapphogram [INFO] frobbed toml for sapphie132/sapphogram written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphie132/sapphogram/Cargo.toml [INFO] crate sapphie132/sapphogram has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sapphie132/sapphogram against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sapphie132/sapphogram:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 552ed2a8305a158778ba2978f3a86821e23e6b8db525b6423dbd831f6f00394f [INFO] running `"docker" "start" "-a" "552ed2a8305a158778ba2978f3a86821e23e6b8db525b6423dbd831f6f00394f"` [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking sapphogram v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | stream.write(buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/client.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | stream.write(buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .ok_or(format!(r#"Malformed config file, unable to find argument for "{}""#, option_name))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!(r#"Malformed config file, unable to find argument for "{}""#, option_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(format!(r#"Malformed config file, lacking a line for "{}""#, option_name))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!(r#"Malformed config file, lacking a line for "{}""#, option_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | let s: T = config_file_lines.filter(|string| string.contains(option_name)) [INFO] [stderr] | ________________^ [INFO] [stderr] 13 | | .next() //get the next [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|string| string.contains(option_name)).next()` with `find(|string| string.contains(option_name))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | .ok_or(format!(r#"Malformed config file, unable to find argument for "{}""#, option_name))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!(r#"Malformed config file, unable to find argument for "{}""#, option_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:14:10 [INFO] [stderr] | [INFO] [stderr] 14 | .ok_or(format!(r#"Malformed config file, lacking a line for "{}""#, option_name))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!(r#"Malformed config file, lacking a line for "{}""#, option_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | let s: T = config_file_lines.filter(|string| string.contains(option_name)) [INFO] [stderr] | ________________^ [INFO] [stderr] 13 | | .next() //get the next [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|string| string.contains(option_name)).next()` with `find(|string| string.contains(option_name))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: Could not compile `sapphogram`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `sapphogram`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "552ed2a8305a158778ba2978f3a86821e23e6b8db525b6423dbd831f6f00394f"` [INFO] running `"docker" "rm" "-f" "552ed2a8305a158778ba2978f3a86821e23e6b8db525b6423dbd831f6f00394f"` [INFO] [stdout] 552ed2a8305a158778ba2978f3a86821e23e6b8db525b6423dbd831f6f00394f