[INFO] updating cached repository sappharx/mdn-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sappharx/mdn-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sappharx/mdn-cli" "work/ex/clippy-test-run/sources/stable/gh/sappharx/mdn-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sappharx/mdn-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sappharx/mdn-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sappharx/mdn-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sappharx/mdn-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7483ed7aec9799663b1c9098857afcd10d1ee8ab [INFO] sha for GitHub repo sappharx/mdn-cli: 7483ed7aec9799663b1c9098857afcd10d1ee8ab [INFO] validating manifest of sappharx/mdn-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sappharx/mdn-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sappharx/mdn-cli [INFO] finished frobbing sappharx/mdn-cli [INFO] frobbed toml for sappharx/mdn-cli written to work/ex/clippy-test-run/sources/stable/gh/sappharx/mdn-cli/Cargo.toml [INFO] started frobbing sappharx/mdn-cli [INFO] finished frobbing sappharx/mdn-cli [INFO] frobbed toml for sappharx/mdn-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sappharx/mdn-cli/Cargo.toml [INFO] crate sappharx/mdn-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sappharx/mdn-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sappharx/mdn-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b597c44a1e56bf5e8d7738e5808ad858c4aa2f97f88d95ca8137e1ae20f92941 [INFO] running `"docker" "start" "-a" "b597c44a1e56bf5e8d7738e5808ad858c4aa2f97f88d95ca8137e1ae20f92941"` [INFO] [stderr] Checking mdn-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return ROOT; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `ROOT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const ROOT : &'static str = "https://developer.mozilla.org/en-US/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `open_command` [INFO] [stderr] --> src/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let open_command = Command::new("open") [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_open_command` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return ROOT; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `ROOT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | const ROOT : &'static str = "https://developer.mozilla.org/en-US/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `open_command` [INFO] [stderr] --> src/main.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let open_command = Command::new("open") [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_open_command` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `"docker" "inspect" "b597c44a1e56bf5e8d7738e5808ad858c4aa2f97f88d95ca8137e1ae20f92941"` [INFO] running `"docker" "rm" "-f" "b597c44a1e56bf5e8d7738e5808ad858c4aa2f97f88d95ca8137e1ae20f92941"` [INFO] [stdout] b597c44a1e56bf5e8d7738e5808ad858c4aa2f97f88d95ca8137e1ae20f92941