[INFO] updating cached repository santifa/rs-examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/santifa/rs-examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/santifa/rs-examples" "work/ex/clippy-test-run/sources/stable/gh/santifa/rs-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/santifa/rs-examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/santifa/rs-examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/santifa/rs-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/santifa/rs-examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce37b7f73eec596b5d70dc29cdaa7ed172891db0 [INFO] sha for GitHub repo santifa/rs-examples: ce37b7f73eec596b5d70dc29cdaa7ed172891db0 [INFO] validating manifest of santifa/rs-examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of santifa/rs-examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing santifa/rs-examples [INFO] finished frobbing santifa/rs-examples [INFO] frobbed toml for santifa/rs-examples written to work/ex/clippy-test-run/sources/stable/gh/santifa/rs-examples/Cargo.toml [INFO] started frobbing santifa/rs-examples [INFO] finished frobbing santifa/rs-examples [INFO] frobbed toml for santifa/rs-examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/santifa/rs-examples/Cargo.toml [INFO] crate santifa/rs-examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting santifa/rs-examples against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/santifa/rs-examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45d049a0d7e9a11a1c8108ac3e82b3e4c1715f23016afc840af4029220e8fea5 [INFO] running `"docker" "start" "-a" "45d049a0d7e9a11a1c8108ac3e82b3e4c1715f23016afc840af4029220e8fea5"` [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking rs-examples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | prior: prior, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | mean_variance: mean_variance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mean_variance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | prior: prior, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `prior` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/bayes.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | mean_variance: mean_variance, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mean_variance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/fb.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | static BG: u32 = 0x1D2021; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_2021` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/fb.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | static FG: u32 = 0xA99A84; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A9_9A84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/bayes.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | const ATTR: &'static [&str] = &["RI", "Na", "Mg", "Al", "Si", "K", "Ca", "Ba", "Fe"]; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/bayes.rs:15:14 [INFO] [stderr] | [INFO] [stderr] 15 | const ATTR: &'static [&str] = &["RI", "Na", "Mg", "Al", "Si", "K", "Ca", "Ba", "Fe"]; [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/fb.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | static BG: u32 = 0x1D2021; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001D_2021` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/fb.rs:23:18 [INFO] [stderr] | [INFO] [stderr] 23 | static FG: u32 = 0xA99A84; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A9_9A84` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match t { [INFO] [stderr] 18 | | &Type::Foo | &Type::Bar | &Type::Baz => true, [INFO] [stderr] 19 | | &Type::Sum(ref l, ref r) => judgment(&l) && judgment(&r), [INFO] [stderr] 20 | | &Type::Fn(ref i, ref o) => judgment(&i) && judgment(&o), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *t { [INFO] [stderr] 18 | Type::Foo | Type::Bar | Type::Baz => true, [INFO] [stderr] 19 | Type::Sum(ref l, ref r) => judgment(&l) && judgment(&r), [INFO] [stderr] 20 | Type::Fn(ref i, ref o) => judgment(&i) && judgment(&o), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / match t { [INFO] [stderr] 18 | | &Type::Foo | &Type::Bar | &Type::Baz => true, [INFO] [stderr] 19 | | &Type::Sum(ref l, ref r) => judgment(&l) && judgment(&r), [INFO] [stderr] 20 | | &Type::Fn(ref i, ref o) => judgment(&i) && judgment(&o), [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *t { [INFO] [stderr] 18 | Type::Foo | Type::Bar | Type::Baz => true, [INFO] [stderr] 19 | Type::Sum(ref l, ref r) => judgment(&l) && judgment(&r), [INFO] [stderr] 20 | Type::Fn(ref i, ref o) => judgment(&i) && judgment(&o), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match g { [INFO] [stderr] 49 | | &Context::Empty() => true, [INFO] [stderr] 50 | | &Context::Snoc(_, ref n, _) if n == name => false, [INFO] [stderr] 51 | | &Context::Snoc(ref rest, _, _) => not_in(name, &rest), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *g { [INFO] [stderr] 49 | Context::Empty() => true, [INFO] [stderr] 50 | Context::Snoc(_, ref n, _) if n == name => false, [INFO] [stderr] 51 | Context::Snoc(ref rest, _, _) => not_in(name, &rest), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match g { [INFO] [stderr] 58 | | &Context::Empty() => true, [INFO] [stderr] 59 | | &Context::Snoc(ref rest, ref name, ref t) => { [INFO] [stderr] 60 | | judgment_ctx(&rest) && judgment(&t) && not_in(&name, &rest) [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *g { [INFO] [stderr] 58 | Context::Empty() => true, [INFO] [stderr] 59 | Context::Snoc(ref rest, ref name, ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / match g { [INFO] [stderr] 77 | | &Context::Empty() => false, [INFO] [stderr] 78 | | &Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] 79 | | true => type_equality(a, &t), [INFO] [stderr] 80 | | false => var_has_type(v, a, &rest), [INFO] [stderr] 81 | | }, [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 76 | match *g { [INFO] [stderr] 77 | Context::Empty() => false, [INFO] [stderr] 78 | Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/type.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | &Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 79 | | true => type_equality(a, &t), [INFO] [stderr] 80 | | false => var_has_type(v, a, &rest), [INFO] [stderr] 81 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if name == v { type_equality(a, &t) } else { var_has_type(v, a, &rest) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match g { [INFO] [stderr] 49 | | &Context::Empty() => true, [INFO] [stderr] 50 | | &Context::Snoc(_, ref n, _) if n == name => false, [INFO] [stderr] 51 | | &Context::Snoc(ref rest, _, _) => not_in(name, &rest), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *g { [INFO] [stderr] 49 | Context::Empty() => true, [INFO] [stderr] 50 | Context::Snoc(_, ref n, _) if n == name => false, [INFO] [stderr] 51 | Context::Snoc(ref rest, _, _) => not_in(name, &rest), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match g { [INFO] [stderr] 58 | | &Context::Empty() => true, [INFO] [stderr] 59 | | &Context::Snoc(ref rest, ref name, ref t) => { [INFO] [stderr] 60 | | judgment_ctx(&rest) && judgment(&t) && not_in(&name, &rest) [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | match *g { [INFO] [stderr] 58 | Context::Empty() => true, [INFO] [stderr] 59 | Context::Snoc(ref rest, ref name, ref t) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/bin/type.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / match g { [INFO] [stderr] 77 | | &Context::Empty() => false, [INFO] [stderr] 78 | | &Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] 79 | | true => type_equality(a, &t), [INFO] [stderr] 80 | | false => var_has_type(v, a, &rest), [INFO] [stderr] 81 | | }, [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 76 | match *g { [INFO] [stderr] 77 | Context::Empty() => false, [INFO] [stderr] 78 | Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/type.rs:78:54 [INFO] [stderr] | [INFO] [stderr] 78 | &Context::Snoc(ref rest, ref name, ref t) => match name == v { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 79 | | true => type_equality(a, &t), [INFO] [stderr] 80 | | false => var_has_type(v, a, &rest), [INFO] [stderr] 81 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if name == v { type_equality(a, &t) } else { var_has_type(v, a, &rest) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/bin/type.rs:285:13 [INFO] [stderr] | [INFO] [stderr] 285 | let foo = Type::Foo; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/bin/type.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | let bar = Type::Bar; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> src/bin/type.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | let baz = Type::Baz; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/bayes.rs:72:47 [INFO] [stderr] | [INFO] [stderr] 72 | prior.insert((*key).clone(), vec![*val as f64 / train.len() as f64]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/bin/bayes.rs:72:47 [INFO] [stderr] | [INFO] [stderr] 72 | prior.insert((*key).clone(), vec![*val as f64 / train.len() as f64]); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(*val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | let mean_var = self.mean_variance.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mean_variance[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/bayes.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*result.get(*key).unwrap() - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/bayes.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | let mean_var = self.mean_variance.get(k).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.mean_variance[k]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | if &row[row.len() - 1] == predictions.get(&row[0]).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&predictions[&row[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/bin/bayes.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*result.get(*key).unwrap() - max).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/bin/bayes.rs:137:29 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:137:30 [INFO] [stderr] | [INFO] [stderr] 137 | .find(|key| *result.get(*key).unwrap() == max) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/bayes.rs:170:35 [INFO] [stderr] | [INFO] [stderr] 170 | if &row[row.len() - 1] == predictions.get(&row[0]).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&predictions[&row[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs-examples`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `rs-examples`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(data[index] as u32)` [INFO] [stderr] --> src/bin/fb.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | ((data[index] as u32) << 0) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ((data[index] as u32) << 0) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((data[index+1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((data[index+2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ((data[index+3] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/bin/fb.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | libc::mmap(0 as *mut libc::c_void, len as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(data[index] as u32)` [INFO] [stderr] --> src/bin/fb.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | ((data[index] as u32) << 0) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ((data[index] as u32) << 0) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((data[index+1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((data[index+2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/fb.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ((data[index+3] as u32) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[index+3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/bin/fb.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | libc::mmap(0 as *mut libc::c_void, len as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "45d049a0d7e9a11a1c8108ac3e82b3e4c1715f23016afc840af4029220e8fea5"` [INFO] running `"docker" "rm" "-f" "45d049a0d7e9a11a1c8108ac3e82b3e4c1715f23016afc840af4029220e8fea5"` [INFO] [stdout] 45d049a0d7e9a11a1c8108ac3e82b3e4c1715f23016afc840af4029220e8fea5