[INFO] updating cached repository sandhose/rust-todo
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sandhose/rust-todo
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sandhose/rust-todo" "work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-todo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-todo'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sandhose/rust-todo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-todo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-todo'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c058b04a64b0b8433d51d8a6c70e71a046369fb9
[INFO] sha for GitHub repo sandhose/rust-todo: c058b04a64b0b8433d51d8a6c70e71a046369fb9
[INFO] validating manifest of sandhose/rust-todo on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sandhose/rust-todo on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sandhose/rust-todo
[INFO] finished frobbing sandhose/rust-todo
[INFO] frobbed toml for sandhose/rust-todo written to work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-todo/Cargo.toml
[INFO] started frobbing sandhose/rust-todo
[INFO] finished frobbing sandhose/rust-todo
[INFO] frobbed toml for sandhose/rust-todo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-todo/Cargo.toml
[INFO] crate sandhose/rust-todo has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sandhose/rust-todo against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-todo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c32a15f7331f22499836ecef658bd37656ab1f694deb92a3626892ee92b155db
[INFO] running `"docker" "start" "-a" "c32a15f7331f22499836ecef658bd37656ab1f694deb92a3626892ee92b155db"`
[INFO] [stderr]     Checking rustc-serialize v0.3.21
[INFO] [stderr]     Checking xdg v2.0.0
[INFO] [stderr]     Checking term_size v0.2.1
[INFO] [stderr]     Checking term v0.2.14
[INFO] [stderr]     Checking clap v2.18.0
[INFO] [stderr]     Checking toml v0.2.1
[INFO] [stderr]     Checking todo v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/todo/list.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/todo/list.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:39:13
[INFO] [stderr]    |
[INFO] [stderr] 39 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/todo/mod.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | mod todo;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/todo/mod.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | mod todo;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `find_todo`
[INFO] [stderr]   --> src/todo/list.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn find_todo(&self, todo: &Todo) -> Option<usize> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `load`
[INFO] [stderr]    --> src/todo/list.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn load() -> Result<Self, Error> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `save`
[INFO] [stderr]    --> src/todo/list.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save(&self) -> Result<(), Error> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/todo/priority.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn to_u8(&self) -> u8 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<toml::Parser>::new` doesn't need a mutable reference
[INFO] [stderr]   --> src/todo/list.rs:86:44
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let mut parser = toml::Parser::new(&mut r);
[INFO] [stderr]    |                                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/todo/list.rs:90:62
[INFO] [stderr]    |
[INFO] [stderr] 90 |                   return Err(Error::ParserError(Vec::from_iter(parser.errors.clone().iter().map(move |ref e| {
[INFO] [stderr]    |  ______________________________________________________________^
[INFO] [stderr] 91 | |                     (parser.to_linecol(e.lo), path.to_owned(), (*e).clone())
[INFO] [stderr] 92 | |                 }).into_iter())))
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 return Err(Error::ParserError(Vec::from_iter(parser.errors.clone().iter().map(move |ref e| {
[INFO] [stderr] 91 |                     (parser.to_linecol(e.lo), path.to_owned(), (*e).clone())
[INFO] [stderr] 92 |                 }))))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/todo/list.rs:139:22
[INFO] [stderr]     |
[INFO] [stderr] 139 |                 errs.into_iter().fold(write!(f, "Parse Errors:"), |result, &(loc, ref file, ref err)| {
[INFO] [stderr]     |                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `find_todo`
[INFO] [stderr]   --> src/todo/list.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn find_todo(&self, todo: &Todo) -> Option<usize> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `load`
[INFO] [stderr]    --> src/todo/list.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn load() -> Result<Self, Error> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `save`
[INFO] [stderr]    --> src/todo/list.rs:116:5
[INFO] [stderr]     |
[INFO] [stderr] 116 |     pub fn save(&self) -> Result<(), Error> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/todo/priority.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |     fn to_u8(&self) -> u8 {
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<toml::Parser>::new` doesn't need a mutable reference
[INFO] [stderr]   --> src/todo/list.rs:86:44
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let mut parser = toml::Parser::new(&mut r);
[INFO] [stderr]    |                                            ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/todo/list.rs:90:62
[INFO] [stderr]    |
[INFO] [stderr] 90 |                   return Err(Error::ParserError(Vec::from_iter(parser.errors.clone().iter().map(move |ref e| {
[INFO] [stderr]    |  ______________________________________________________________^
[INFO] [stderr] 91 | |                     (parser.to_linecol(e.lo), path.to_owned(), (*e).clone())
[INFO] [stderr] 92 | |                 }).into_iter())))
[INFO] [stderr]    | |______________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]    |
[INFO] [stderr] 90 |                 return Err(Error::ParserError(Vec::from_iter(parser.errors.clone().iter().map(move |ref e| {
[INFO] [stderr] 91 |                     (parser.to_linecol(e.lo), path.to_owned(), (*e).clone())
[INFO] [stderr] 92 |                 }))))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/todo/list.rs:139:22
[INFO] [stderr]     |
[INFO] [stderr] 139 |                 errs.into_iter().fold(write!(f, "Parse Errors:"), |result, &(loc, ref file, ref err)| {
[INFO] [stderr]     |                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.15s
[INFO] running `"docker" "inspect" "c32a15f7331f22499836ecef658bd37656ab1f694deb92a3626892ee92b155db"`
[INFO] running `"docker" "rm" "-f" "c32a15f7331f22499836ecef658bd37656ab1f694deb92a3626892ee92b155db"`
[INFO] [stdout] c32a15f7331f22499836ecef658bd37656ab1f694deb92a3626892ee92b155db