[INFO] updating cached repository sandhose/rust-simple-dht
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sandhose/rust-simple-dht
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sandhose/rust-simple-dht" "work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-simple-dht"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-simple-dht'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sandhose/rust-simple-dht" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-simple-dht"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-simple-dht'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a13cd9b91ea62dde51520aa76e5f02291bc8695b
[INFO] sha for GitHub repo sandhose/rust-simple-dht: a13cd9b91ea62dde51520aa76e5f02291bc8695b
[INFO] validating manifest of sandhose/rust-simple-dht on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sandhose/rust-simple-dht on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sandhose/rust-simple-dht
[INFO] finished frobbing sandhose/rust-simple-dht
[INFO] frobbed toml for sandhose/rust-simple-dht written to work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-simple-dht/Cargo.toml
[INFO] started frobbing sandhose/rust-simple-dht
[INFO] finished frobbing sandhose/rust-simple-dht
[INFO] frobbed toml for sandhose/rust-simple-dht written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandhose/rust-simple-dht/Cargo.toml
[INFO] crate sandhose/rust-simple-dht has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sandhose/rust-simple-dht against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sandhose/rust-simple-dht:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a4d77e7063d21cd67a20c23347902983303a0c2cf17378e7aa407b6c52c866ab
[INFO] running `"docker" "start" "-a" "a4d77e7063d21cd67a20c23347902983303a0c2cf17378e7aa407b6c52c866ab"`
[INFO] [stderr]     Checking shlex v0.1.1
[INFO] [stderr]     Checking atty v0.2.3
[INFO] [stderr]     Checking tokio-timer v0.1.2
[INFO] [stderr]     Checking mio v0.6.11
[INFO] [stderr]     Checking tokio-io v0.1.4
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking clap v2.29.0
[INFO] [stderr]     Checking tokio-core v0.1.11
[INFO] [stderr]     Checking structopt v0.1.6
[INFO] [stderr]     Checking simple_dht v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/state.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/state.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 | /     return Box::new(
[INFO] [stderr] 155 | |         (send_future, server_future, broadcast_future)
[INFO] [stderr] 156 | |             .into_future()
[INFO] [stderr] 157 | |             .map(|_| ()),
[INFO] [stderr] 158 | |     );
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 154 |     Box::new(
[INFO] [stderr] 155 |         (send_future, server_future, broadcast_future)
[INFO] [stderr] 156 |             .into_future()
[INFO] [stderr] 157 |             .map(|_| ()),
[INFO] [stderr] 158 |     )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/server.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 | /     return Box::new(
[INFO] [stderr] 155 | |         (send_future, server_future, broadcast_future)
[INFO] [stderr] 156 | |             .into_future()
[INFO] [stderr] 157 | |             .map(|_| ()),
[INFO] [stderr] 158 | |     );
[INFO] [stderr]     | |______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 154 |     Box::new(
[INFO] [stderr] 155 |         (send_future, server_future, broadcast_future)
[INFO] [stderr] 156 |             .into_future()
[INFO] [stderr] 157 |             .map(|_| ()),
[INFO] [stderr] 158 |     )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn put(&mut self, hash: &Hash, data: Vec<u8>) {
[INFO] [stderr]    |                                 ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:51:29
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn get(&self, hash: &Hash) -> Option<Vec<u8>> {
[INFO] [stderr]    |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:55:34
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn contains(&self, hash: &Hash) -> bool {
[INFO] [stderr]    |                                  ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:192:40
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 let req = self.request(hash.clone());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:254:29
[INFO] [stderr]     |
[INFO] [stderr] 254 |     pub fn put(&self, hash: &Hash, data: Vec<u8>) {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:259:29
[INFO] [stderr]     |
[INFO] [stderr] 259 |     pub fn get(&self, hash: &Hash) -> Option<Vec<u8>> {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:263:30
[INFO] [stderr]     |
[INFO] [stderr] 263 |     fn contains(&self, hash: &Hash) -> bool {
[INFO] [stderr]     |                              ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/server.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         self.peers
[INFO] [stderr] 50 | |             .borrow()
[INFO] [stderr] 51 | |             .keys()
[INFO] [stderr] 52 | |             .map(|addr| addr.clone())
[INFO] [stderr]    | |_____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 49 |         self.peers
[INFO] [stderr] 50 |             .borrow()
[INFO] [stderr] 51 |             .keys().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/server.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |             .map(|addr| addr.clone())
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: try dereferencing it: `*addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/client.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 | /                     if let &Message::Put(hash2, ref payload) = resp {
[INFO] [stderr] 43 | |                         // The server answered with the hash I wanted
[INFO] [stderr] 44 | |                         if hash == hash2 {
[INFO] [stderr] 45 | |                             println!("{}", payload);
[INFO] [stderr] 46 | |                             return true;
[INFO] [stderr] 47 | |                         }
[INFO] [stderr] 48 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     if let Message::Put(hash2, ref payload) = *resp {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/client.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 | /                     if let &Message::IHave(hash2) = resp {
[INFO] [stderr] 52 | |                         // The server has the hash I just pushed
[INFO] [stderr] 53 | |                         if hash == hash2 {
[INFO] [stderr] 54 | |                             return true;
[INFO] [stderr] 55 | |                         }
[INFO] [stderr] 56 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     if let Message::IHave(hash2) = *resp {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/cli.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |     pub fn to_message(self) -> Message {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cli.rs:99:20
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 if args.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/messages.rs:400:23
[INFO] [stderr]     |
[INFO] [stderr] 400 |         let payload = "Hello, world!".as_bytes();
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello, world!"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/messages.rs:402:36
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let message = Message::Put(hash.clone(), Payload(payload.clone().to_vec()));
[INFO] [stderr]     |                                    ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/messages.rs:402:58
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let message = Message::Put(hash.clone(), Payload(payload.clone().to_vec()));
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let message = Message::Put(hash.clone(), Payload(&(*payload).clone().to_vec()));
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let message = Message::Put(hash.clone(), Payload(&[u8]::clone(payload).to_vec()));
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/messages.rs:405:26
[INFO] [stderr]     |
[INFO] [stderr] 405 |         assert_eq!(frame[1..(1 + HASH_SIZE)], hash.0); // Check hash
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^ help: use: `1..=HASH_SIZE`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn put(&mut self, hash: &Hash, data: Vec<u8>) {
[INFO] [stderr]    |                                 ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:51:29
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn get(&self, hash: &Hash) -> Option<Vec<u8>> {
[INFO] [stderr]    |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/state.rs:55:34
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn contains(&self, hash: &Hash) -> bool {
[INFO] [stderr]    |                                  ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:192:40
[INFO] [stderr]     |
[INFO] [stderr] 192 |                 let req = self.request(hash.clone());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:254:29
[INFO] [stderr]     |
[INFO] [stderr] 254 |     pub fn put(&self, hash: &Hash, data: Vec<u8>) {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:259:29
[INFO] [stderr]     |
[INFO] [stderr] 259 |     pub fn get(&self, hash: &Hash) -> Option<Vec<u8>> {
[INFO] [stderr]     |                             ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/state.rs:263:30
[INFO] [stderr]     |
[INFO] [stderr] 263 |     fn contains(&self, hash: &Hash) -> bool {
[INFO] [stderr]     |                              ^^^^^ help: consider passing by value instead: `Hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:302:31
[INFO] [stderr]     |
[INFO] [stderr] 302 |         assert_eq!(state.get(&hash.clone()), None);
[INFO] [stderr]     |                               ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:304:20
[INFO] [stderr]     |
[INFO] [stderr] 304 |         state.put(&hash.clone(), content.clone());
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:331:55
[INFO] [stderr]     |
[INFO] [stderr] 331 |         let mut stream = state.process(Message::IHave(hash.clone()));
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/state.rs:332:37
[INFO] [stderr]     |
[INFO] [stderr] 332 |         let expected = Message::Get(hash.clone());
[INFO] [stderr]     |                                     ^^^^^^^^^^^^ help: try removing the `clone` call: `hash`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/server.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 | /         self.peers
[INFO] [stderr] 50 | |             .borrow()
[INFO] [stderr] 51 | |             .keys()
[INFO] [stderr] 52 | |             .map(|addr| addr.clone())
[INFO] [stderr]    | |_____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] help: Consider calling the dedicated `cloned` method
[INFO] [stderr]    |
[INFO] [stderr] 49 |         self.peers
[INFO] [stderr] 50 |             .borrow()
[INFO] [stderr] 51 |             .keys().cloned()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/server.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |             .map(|addr| addr.clone())
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: try dereferencing it: `*addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/client.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 | /                     if let &Message::Put(hash2, ref payload) = resp {
[INFO] [stderr] 43 | |                         // The server answered with the hash I wanted
[INFO] [stderr] 44 | |                         if hash == hash2 {
[INFO] [stderr] 45 | |                             println!("{}", payload);
[INFO] [stderr] 46 | |                             return true;
[INFO] [stderr] 47 | |                         }
[INFO] [stderr] 48 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     if let Message::Put(hash2, ref payload) = *resp {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/client.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 | /                     if let &Message::IHave(hash2) = resp {
[INFO] [stderr] 52 | |                         // The server has the hash I just pushed
[INFO] [stderr] 53 | |                         if hash == hash2 {
[INFO] [stderr] 54 | |                             return true;
[INFO] [stderr] 55 | |                         }
[INFO] [stderr] 56 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     if let Message::IHave(hash2) = *resp {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/cli.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |     pub fn to_message(self) -> Message {
[INFO] [stderr]    |                       ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cli.rs:99:20
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 if args.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `simple_dht`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "a4d77e7063d21cd67a20c23347902983303a0c2cf17378e7aa407b6c52c866ab"`
[INFO] running `"docker" "rm" "-f" "a4d77e7063d21cd67a20c23347902983303a0c2cf17378e7aa407b6c52c866ab"`
[INFO] [stdout] a4d77e7063d21cd67a20c23347902983303a0c2cf17378e7aa407b6c52c866ab