[INFO] updating cached repository sandeep-datta/mind_forge_gtkrs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sandeep-datta/mind_forge_gtkrs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sandeep-datta/mind_forge_gtkrs" "work/ex/clippy-test-run/sources/stable/gh/sandeep-datta/mind_forge_gtkrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sandeep-datta/mind_forge_gtkrs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sandeep-datta/mind_forge_gtkrs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandeep-datta/mind_forge_gtkrs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandeep-datta/mind_forge_gtkrs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37cb1ac8544b044213278f35902609c1dc0809cf [INFO] sha for GitHub repo sandeep-datta/mind_forge_gtkrs: 37cb1ac8544b044213278f35902609c1dc0809cf [INFO] validating manifest of sandeep-datta/mind_forge_gtkrs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sandeep-datta/mind_forge_gtkrs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sandeep-datta/mind_forge_gtkrs [INFO] finished frobbing sandeep-datta/mind_forge_gtkrs [INFO] frobbed toml for sandeep-datta/mind_forge_gtkrs written to work/ex/clippy-test-run/sources/stable/gh/sandeep-datta/mind_forge_gtkrs/Cargo.toml [INFO] started frobbing sandeep-datta/mind_forge_gtkrs [INFO] finished frobbing sandeep-datta/mind_forge_gtkrs [INFO] frobbed toml for sandeep-datta/mind_forge_gtkrs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sandeep-datta/mind_forge_gtkrs/Cargo.toml [INFO] crate sandeep-datta/mind_forge_gtkrs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sandeep-datta/mind_forge_gtkrs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sandeep-datta/mind_forge_gtkrs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddb98e57eee5f1183bb7315bc4d9d7ca5d68c17482054bc22cc0286b5eb25fbe [INFO] running `"docker" "start" "-a" "ddb98e57eee5f1183bb7315bc4d9d7ca5d68c17482054bc22cc0286b5eb25fbe"` [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling cairo-rs v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling cairo-sys-rs v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking glib-sys v0.3.4 [INFO] [stderr] Checking gobject-sys v0.3.4 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking atk-sys v0.3.4 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking mind_forge_gtkrs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | Node {text: text, children: children} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | Node {text: text, children: children} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | Node {text: text, children: children} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | Node {text: text, children: children} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/utils.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! print_err { [INFO] [stderr] 14 | | ($($arg:tt)*) => ({ [INFO] [stderr] 15 | | use std::io::Write; [INFO] [stderr] 16 | | match write!(&mut ::std::io::stderr(), $($arg)* ) { [INFO] [stderr] ... | [INFO] [stderr] 20 | | }) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `BoxExt` [INFO] [stderr] --> src/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | use gtk::{Align, BoxExt}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | sample [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let sample = Node::new("Root node".to_string(), vec![ [INFO] [stderr] | __________________^ [INFO] [stderr] 48 | | Node::new("Child node 1".to_string(), vec![ [INFO] [stderr] 49 | | Node::new("Child node 1.1".to_string(), vec![]), [INFO] [stderr] 50 | | Node::new("Child node 1.2".to_string(), vec![]) [INFO] [stderr] 51 | | ]), [INFO] [stderr] 52 | | Node::new("Child node 2".to_string(), vec![]), [INFO] [stderr] 53 | | ]); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/utils.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! print_err { [INFO] [stderr] 14 | | ($($arg:tt)*) => ({ [INFO] [stderr] 15 | | use std::io::Write; [INFO] [stderr] 16 | | match write!(&mut ::std::io::stderr(), $($arg)* ) { [INFO] [stderr] ... | [INFO] [stderr] 20 | | }) [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `BoxExt` [INFO] [stderr] --> src/main.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | use gtk::{Align, BoxExt}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | sample [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let sample = Node::new("Root node".to_string(), vec![ [INFO] [stderr] | __________________^ [INFO] [stderr] 48 | | Node::new("Child node 1".to_string(), vec![ [INFO] [stderr] 49 | | Node::new("Child node 1.1".to_string(), vec![]), [INFO] [stderr] 50 | | Node::new("Child node 1.2".to_string(), vec![]) [INFO] [stderr] 51 | | ]), [INFO] [stderr] 52 | | Node::new("Child node 2".to_string(), vec![]), [INFO] [stderr] 53 | | ]); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.38s [INFO] running `"docker" "inspect" "ddb98e57eee5f1183bb7315bc4d9d7ca5d68c17482054bc22cc0286b5eb25fbe"` [INFO] running `"docker" "rm" "-f" "ddb98e57eee5f1183bb7315bc4d9d7ca5d68c17482054bc22cc0286b5eb25fbe"` [INFO] [stdout] ddb98e57eee5f1183bb7315bc4d9d7ca5d68c17482054bc22cc0286b5eb25fbe