[INFO] updating cached repository samstokes/hibi2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samstokes/hibi2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samstokes/hibi2" "work/ex/clippy-test-run/sources/stable/gh/samstokes/hibi2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samstokes/hibi2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samstokes/hibi2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samstokes/hibi2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samstokes/hibi2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 40a7e600933e51e13550533f9de8c0ba5c20253e [INFO] sha for GitHub repo samstokes/hibi2: 40a7e600933e51e13550533f9de8c0ba5c20253e [INFO] validating manifest of samstokes/hibi2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samstokes/hibi2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samstokes/hibi2 [INFO] finished frobbing samstokes/hibi2 [INFO] frobbed toml for samstokes/hibi2 written to work/ex/clippy-test-run/sources/stable/gh/samstokes/hibi2/Cargo.toml [INFO] started frobbing samstokes/hibi2 [INFO] finished frobbing samstokes/hibi2 [INFO] frobbed toml for samstokes/hibi2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samstokes/hibi2/Cargo.toml [INFO] crate samstokes/hibi2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samstokes/hibi2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samstokes/hibi2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fa0eeae4f658aa02e9e80b1fe8dc244e8a1a006d810c4bb289e7d7db8528990 [INFO] running `"docker" "start" "-a" "1fa0eeae4f658aa02e9e80b1fe8dc244e8a1a006d810c4bb289e7d7db8528990"` [INFO] [stderr] Compiling encoding_rs v0.8.10 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Checking simple-error v0.1.12 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Compiling im v12.2.0 [INFO] [stderr] Compiling sentry v0.12.0 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Compiling syn v0.15.14 [INFO] [stderr] Checking openssl v0.10.15 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking debugid v0.3.1 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking native-tls v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Compiling synstructure v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.3 [INFO] [stderr] Checking sentry-types v0.8.1 [INFO] [stderr] Checking hibi2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/time.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/time.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .ok_or(format!("time zone does not match: {:?}", tz_str))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("time zone does not match: {:?}", tz_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | PgConnection::establish(&database_url).expect(&format!("Error connecting to {}", database_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/time.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .ok_or(format!("time zone does not match: {:?}", tz_str))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("time zone does not match: {:?}", tz_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:26:44 [INFO] [stderr] | [INFO] [stderr] 26 | PgConnection::establish(&database_url).expect(&format!("Error connecting to {}", database_url)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 50s [INFO] running `"docker" "inspect" "1fa0eeae4f658aa02e9e80b1fe8dc244e8a1a006d810c4bb289e7d7db8528990"` [INFO] running `"docker" "rm" "-f" "1fa0eeae4f658aa02e9e80b1fe8dc244e8a1a006d810c4bb289e7d7db8528990"` [INFO] [stdout] 1fa0eeae4f658aa02e9e80b1fe8dc244e8a1a006d810c4bb289e7d7db8528990