[INFO] updating cached repository samsartor/infloop [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samsartor/infloop [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samsartor/infloop" "work/ex/clippy-test-run/sources/stable/gh/samsartor/infloop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samsartor/infloop'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samsartor/infloop" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samsartor/infloop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samsartor/infloop'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 999f89d287a80e32957861ce42d5a7c27db6579d [INFO] sha for GitHub repo samsartor/infloop: 999f89d287a80e32957861ce42d5a7c27db6579d [INFO] validating manifest of samsartor/infloop on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samsartor/infloop on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samsartor/infloop [INFO] finished frobbing samsartor/infloop [INFO] frobbed toml for samsartor/infloop written to work/ex/clippy-test-run/sources/stable/gh/samsartor/infloop/Cargo.toml [INFO] started frobbing samsartor/infloop [INFO] finished frobbing samsartor/infloop [INFO] frobbed toml for samsartor/infloop written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samsartor/infloop/Cargo.toml [INFO] crate samsartor/infloop has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samsartor/infloop against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samsartor/infloop:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0524b05635f19b3cd88f8afb01519d77498e708dc814b000fbf02aecb288820f [INFO] running `"docker" "start" "-a" "0524b05635f19b3cd88f8afb01519d77498e708dc814b000fbf02aecb288820f"` [INFO] [stderr] Checking arrayref v0.3.2 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking infloop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/solver.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::NumCast` [INFO] [stderr] --> src/solver.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num::NumCast; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `InfLoopSolver` [INFO] [stderr] --> src/solver.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct InfLoopSolver { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/solver.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Empty, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Line` [INFO] [stderr] --> src/solver.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Line, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Corner` [INFO] [stderr] --> src/solver.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Corner, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Three` [INFO] [stderr] --> src/solver.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Three, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cross` [INFO] [stderr] --> src/solver.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Cross [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `basic_shape` [INFO] [stderr] --> src/solver.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn basic_shape(&self) -> [bool; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rot_shape` [INFO] [stderr] --> src/solver.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn rot_shape>(&self, rot: T) -> [bool; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 21 | impl_using_as!(u32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 21 | impl_using_as!(u32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 24 | impl_using_as!(i16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 24 | impl_using_as!(i16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 25 | impl_using_as!(i32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | fn check_same(a: &[Option; 4], b: &[Option; 4]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | fn check_same(a: &[Option; 4], b: &[Option; 4]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/solver.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num::NumCast` [INFO] [stderr] --> src/solver.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use num::NumCast; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | fn peg_solve(sides: &[Option; 4], peg_val: bool) -> Result<[Option; 4], ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `possible` [INFO] [stderr] --> src/solver.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..4 { if possible[i] { at = i; break; }} [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (i, ) in possible.iter().enumerate() { if possible[i] { at = i; break; }} [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | } else { Ok(sides.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*sides` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self { [INFO] [stderr] 68 | | &CellType::Empty => [false; 4], [INFO] [stderr] 69 | | &CellType::Peg => [true, false, false, false], [INFO] [stderr] 70 | | &CellType::Line => [true, false, true, false], [INFO] [stderr] ... | [INFO] [stderr] 73 | | &CellType::Cross => [true; 4], [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *self { [INFO] [stderr] 68 | CellType::Empty => [false; 4], [INFO] [stderr] 69 | CellType::Peg => [true, false, false, false], [INFO] [stderr] 70 | CellType::Line => [true, false, true, false], [INFO] [stderr] 71 | CellType::Corner => [true, true, false, false], [INFO] [stderr] 72 | CellType::Three => [true, true, true, false], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | let arr = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 80 | | &CellType::Empty => [false; 7], [INFO] [stderr] 81 | | &CellType::Peg => [true, false, false, false, true, false, false], [INFO] [stderr] 82 | | &CellType::Line => [true, false, true, false, true, false, true], [INFO] [stderr] ... | [INFO] [stderr] 85 | | &CellType::Cross => [true; 7], [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | let arr = match *self { [INFO] [stderr] 80 | CellType::Empty => [false; 7], [INFO] [stderr] 81 | CellType::Peg => [true, false, false, false, true, false, false], [INFO] [stderr] 82 | CellType::Line => [true, false, true, false, true, false, true], [INFO] [stderr] 83 | CellType::Corner => [true, true, false, false, true, true, false], [INFO] [stderr] 84 | CellType::Three => [true, true, true, false, true, true, true], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | array_ref!(arr, rot, 4).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | *{ [INFO] [stderr] 88 | { [INFO] [stderr] 89 | # [ inline ] unsafe fn as_array < T > ( slice : & [ T ] ) -> & [ T ; $ len ] { [INFO] [stderr] 90 | & * ( slice . as_ptr ( ) as * const [ _ ; $ len ] ) } let offset = $ offset ; [INFO] [stderr] 91 | let slice = & $ arr [ offset .. offset + $ len ] ; unsafe { as_array ( slice ) [INFO] [stderr] 92 | } } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:90:38 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn solve_sides(&self, sides: &[Option; 4]) -> Result<[Option; 4], ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &CellType::Empty => { [INFO] [stderr] 93 | | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] 94 | | else { Ok([Some(false); 4]) } [INFO] [stderr] ... | [INFO] [stderr] 142 | | }, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | CellType::Empty => { [INFO] [stderr] 93 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] 94 | else { Ok([Some(false); 4]) } [INFO] [stderr] 95 | }, [INFO] [stderr] 96 | CellType::Peg => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/solver.rs:93:68 [INFO] [stderr] | [INFO] [stderr] 93 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sides` [INFO] [stderr] --> src/solver.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for (i, ) in sides.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | } else { Ok(sides.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*sides` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/solver.rs:140:68 [INFO] [stderr] | [INFO] [stderr] 140 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == false) { Err(()) } [INFO] [stderr] | ^^^^^^^^^^^ help: try simplifying it as shown: `!(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `InfLoopSolver` [INFO] [stderr] --> src/solver.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct InfLoopSolver { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Empty` [INFO] [stderr] --> src/solver.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Empty, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Line` [INFO] [stderr] --> src/solver.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Line, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Corner` [INFO] [stderr] --> src/solver.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Corner, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Three` [INFO] [stderr] --> src/solver.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Three, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cross` [INFO] [stderr] --> src/solver.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Cross [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `basic_shape` [INFO] [stderr] --> src/solver.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn basic_shape(&self) -> [bool; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rot_shape` [INFO] [stderr] --> src/solver.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn rot_shape>(&self, rot: T) -> [bool; 4] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 19 | impl_using_as!(u8 as u8 u16 u32 u64 i8 i16 i32 i64 char usize isize); [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 20 | impl_using_as!(u16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `u64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 21 | impl_using_as!(u32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 21 | impl_using_as!(u32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i16::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 23 | impl_using_as!(i8 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i32::from(self)` [INFO] [stderr] ... [INFO] [stderr] 24 | impl_using_as!(i16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 24 | impl_using_as!(i16 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/castutils.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | self as $b [INFO] [stderr] | ^^^^ help: try: `i64::from(self)` [INFO] [stderr] ... [INFO] [stderr] 25 | impl_using_as!(i32 as u8 u16 u32 u64 i8 i16 i32 i64 usize isize); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | fn check_same(a: &[Option; 4], b: &[Option; 4]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | fn check_same(a: &[Option; 4], b: &[Option; 4]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | fn peg_solve(sides: &[Option; 4], peg_val: bool) -> Result<[Option; 4], ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `possible` [INFO] [stderr] --> src/solver.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..4 { if possible[i] { at = i; break; }} [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (i, ) in possible.iter().enumerate() { if possible[i] { at = i; break; }} [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | } else { Ok(sides.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*sides` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / match self { [INFO] [stderr] 68 | | &CellType::Empty => [false; 4], [INFO] [stderr] 69 | | &CellType::Peg => [true, false, false, false], [INFO] [stderr] 70 | | &CellType::Line => [true, false, true, false], [INFO] [stderr] ... | [INFO] [stderr] 73 | | &CellType::Cross => [true; 4], [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *self { [INFO] [stderr] 68 | CellType::Empty => [false; 4], [INFO] [stderr] 69 | CellType::Peg => [true, false, false, false], [INFO] [stderr] 70 | CellType::Line => [true, false, true, false], [INFO] [stderr] 71 | CellType::Corner => [true, true, false, false], [INFO] [stderr] 72 | CellType::Three => [true, true, true, false], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:79:19 [INFO] [stderr] | [INFO] [stderr] 79 | let arr = match self { [INFO] [stderr] | ___________________^ [INFO] [stderr] 80 | | &CellType::Empty => [false; 7], [INFO] [stderr] 81 | | &CellType::Peg => [true, false, false, false, true, false, false], [INFO] [stderr] 82 | | &CellType::Line => [true, false, true, false, true, false, true], [INFO] [stderr] ... | [INFO] [stderr] 85 | | &CellType::Cross => [true; 7], [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 79 | let arr = match *self { [INFO] [stderr] 80 | CellType::Empty => [false; 7], [INFO] [stderr] 81 | CellType::Peg => [true, false, false, false, true, false, false], [INFO] [stderr] 82 | CellType::Line => [true, false, true, false, true, false, true], [INFO] [stderr] 83 | CellType::Corner => [true, true, false, false, true, true, false], [INFO] [stderr] 84 | CellType::Three => [true, true, true, false, true, true, true], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | array_ref!(arr, rot, 4).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | *{ [INFO] [stderr] 88 | { [INFO] [stderr] 89 | # [ inline ] unsafe fn as_array < T > ( slice : & [ T ] ) -> & [ T ; $ len ] { [INFO] [stderr] 90 | & * ( slice . as_ptr ( ) as * const [ _ ; $ len ] ) } let offset = $ offset ; [INFO] [stderr] 91 | let slice = & $ arr [ offset .. offset + $ len ] ; unsafe { as_array ( slice ) [INFO] [stderr] 92 | } } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:90:38 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn solve_sides(&self, sides: &[Option; 4]) -> Result<[Option; 4], ()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[Option; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/solver.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &CellType::Empty => { [INFO] [stderr] 93 | | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] 94 | | else { Ok([Some(false); 4]) } [INFO] [stderr] ... | [INFO] [stderr] 142 | | }, [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | CellType::Empty => { [INFO] [stderr] 93 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] 94 | else { Ok([Some(false); 4]) } [INFO] [stderr] 95 | }, [INFO] [stderr] 96 | CellType::Peg => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/solver.rs:93:68 [INFO] [stderr] | [INFO] [stderr] 93 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == true) { Err(()) } [INFO] [stderr] | ^^^^^^^^^^ help: try simplifying it as shown: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `sides` [INFO] [stderr] --> src/solver.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for (i, ) in sides.iter().enumerate().take(4) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | } else { Ok(sides.clone()) } [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*sides` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/solver.rs:140:68 [INFO] [stderr] | [INFO] [stderr] 140 | if sides.iter().filter_map(Option::as_ref).any(|v| *v == false) { Err(()) } [INFO] [stderr] | ^^^^^^^^^^^ help: try simplifying it as shown: `!(*v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.45s [INFO] running `"docker" "inspect" "0524b05635f19b3cd88f8afb01519d77498e708dc814b000fbf02aecb288820f"` [INFO] running `"docker" "rm" "-f" "0524b05635f19b3cd88f8afb01519d77498e708dc814b000fbf02aecb288820f"` [INFO] [stdout] 0524b05635f19b3cd88f8afb01519d77498e708dc814b000fbf02aecb288820f