[INFO] updating cached repository samrayleung/rspotify [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samrayleung/rspotify [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samrayleung/rspotify" "work/ex/clippy-test-run/sources/stable/gh/samrayleung/rspotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samrayleung/rspotify'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samrayleung/rspotify" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samrayleung/rspotify"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samrayleung/rspotify'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8463a302f1df9393cf4e05a27252ffd2b3ff2c3 [INFO] sha for GitHub repo samrayleung/rspotify: f8463a302f1df9393cf4e05a27252ffd2b3ff2c3 [INFO] validating manifest of samrayleung/rspotify on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samrayleung/rspotify on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samrayleung/rspotify [INFO] finished frobbing samrayleung/rspotify [INFO] frobbed toml for samrayleung/rspotify written to work/ex/clippy-test-run/sources/stable/gh/samrayleung/rspotify/Cargo.toml [INFO] started frobbing samrayleung/rspotify [INFO] finished frobbing samrayleung/rspotify [INFO] frobbed toml for samrayleung/rspotify written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samrayleung/rspotify/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samrayleung/rspotify against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samrayleung/rspotify:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89826dd438c29841d448af86285800a17533e390bf785662cf1870411e65e8de [INFO] running `"docker" "start" "-a" "89826dd438c29841d448af86285800a17533e390bf785662cf1870411e65e8de"` [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling cc v1.0.28 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Checking string v0.1.3 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling encoding_rs v0.8.14 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking webbrowser v0.2.2 [INFO] [stderr] Checking random v0.12.2 [INFO] [stderr] Checking crossbeam-utils v0.6.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking regex-syntax v0.6.5 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Compiling rand_os v0.1.1 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking mime v0.3.13 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking http v0.1.15 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking h2 v0.1.16 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking rspotify v0.2.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | client_id: client_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | client_secret: client_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | client_id: client_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | client_secret: client_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | redirect_uri: redirect_uri, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redirect_uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | client_id: client_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | client_secret: client_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | client_id: client_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | client_secret: client_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spotify/oauth2.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | redirect_uri: redirect_uri, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `redirect_uri` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spotify/oauth2.rs:287:24 [INFO] [stderr] | [INFO] [stderr] 287 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 288 | | if self.is_token_expired(&token_info) { [INFO] [stderr] 289 | | if let Some(refresh_token) = token_info.refresh_token { [INFO] [stderr] 290 | | self.refresh_access_token(&refresh_token) [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 287 | } else if self.is_token_expired(&token_info) { [INFO] [stderr] 288 | if let Some(refresh_token) = token_info.refresh_token { [INFO] [stderr] 289 | self.refresh_access_token(&refresh_token) [INFO] [stderr] 290 | } else { [INFO] [stderr] 291 | None [INFO] [stderr] 292 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spotify/model/offset.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return Some(Offset { position: Some(position), uri: None }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: Some(position), uri: None })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spotify/model/offset.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Some(Offset { position: None, uri: Some(uri) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: None, uri: Some(uri) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/spotify/oauth2.rs:287:24 [INFO] [stderr] | [INFO] [stderr] 287 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 288 | | if self.is_token_expired(&token_info) { [INFO] [stderr] 289 | | if let Some(refresh_token) = token_info.refresh_token { [INFO] [stderr] 290 | | self.refresh_access_token(&refresh_token) [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 287 | } else if self.is_token_expired(&token_info) { [INFO] [stderr] 288 | if let Some(refresh_token) = token_info.refresh_token { [INFO] [stderr] 289 | self.refresh_access_token(&refresh_token) [INFO] [stderr] 290 | } else { [INFO] [stderr] 291 | None [INFO] [stderr] 292 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/spotify/oauth2.rs:495:25 [INFO] [stderr] | [INFO] [stderr] 495 | .expires_at(1515841743) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_515_841_743` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spotify/model/offset.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return Some(Offset { position: Some(position), uri: None }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: Some(position), uri: None })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/spotify/model/offset.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return Some(Offset { position: None, uri: Some(uri) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Offset { position: None, uri: Some(uri) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spotify/oauth2.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn set_expires_at(&mut self, expires_at: &i64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/spotify/oauth2.rs:249:45 [INFO] [stderr] | [INFO] [stderr] 249 | } else if self.client_id.is_empty() { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 250 | | true [INFO] [stderr] 251 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/spotify/oauth2.rs:247:58 [INFO] [stderr] | [INFO] [stderr] 247 | let empty_flag = if self.redirect_uri.is_empty() { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 248 | | true [INFO] [stderr] 249 | | } else if self.client_id.is_empty() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:283:26 [INFO] [stderr] | [INFO] [stderr] 283 | .expect(&format!("convert [{:?}] to json failed", [INFO] [stderr] | __________________________^ [INFO] [stderr] 284 | | self.cache_path.display())); [INFO] [stderr] | |___________________________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("convert [{:?}] to json failed", self.cache_path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:420:10 [INFO] [stderr] | [INFO] [stderr] 420 | .expect(&format!("create file {:?} error", path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create file {:?} error", path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:422:10 [INFO] [stderr] | [INFO] [stderr] 422 | .expect(&format!("clear original spoitfy-token-cache file [{:?}] failed", [INFO] [stderr] | __________^ [INFO] [stderr] 423 | | path.display())); [INFO] [stderr] | |________________________________________^ help: try this: `unwrap_or_else(|_| panic!("clear original spoitfy-token-cache file [{:?}] failed", path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/spotify/util.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | V: Debug+ToString>(map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 33 | pub fn convert_map_to_string(map: &HashMap) -> String{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 14 | | match s { [INFO] [stderr] 15 | | "album" => Some(AlbumType::Album), [INFO] [stderr] 16 | | "single" => Some(AlbumType::Single), [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 55 | | match s { [INFO] [stderr] 56 | | "artist" => Some(Type::Artist), [INFO] [stderr] 57 | | "album" => Some(Type::Album), [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 98 | | match s { [INFO] [stderr] 99 | | "long_term" => Some(TimeRange::LongTerm), [INFO] [stderr] 100 | | "medium_term" => Some(TimeRange::MediumTerm), [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 379 | | match s { [INFO] [stderr] 380 | | "AF" => Some(Country::Afghanistan), [INFO] [stderr] 381 | | "AX" => Some(Country::AlandIslands), [INFO] [stderr] ... | [INFO] [stderr] 631 | | } [INFO] [stderr] 632 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:1157:5 [INFO] [stderr] | [INFO] [stderr] 1157 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 1158 | | match s { [INFO] [stderr] 1159 | | "off" => Some(RepeatState::Off), [INFO] [stderr] 1160 | | "track" => Some(RepeatState::Track), [INFO] [stderr] ... | [INFO] [stderr] 1163 | | } [INFO] [stderr] 1164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:1185:5 [INFO] [stderr] | [INFO] [stderr] 1185 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 1186 | | match s { [INFO] [stderr] 1187 | | "artist" => Some(SearchType::Artist), [INFO] [stderr] 1188 | | "album" => Some(SearchType::Album), [INFO] [stderr] ... | [INFO] [stderr] 1192 | | } [INFO] [stderr] 1193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/spotify/oauth2.rs:86:50 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn set_expires_at(&mut self, expires_at: &i64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/spotify/oauth2.rs:249:45 [INFO] [stderr] | [INFO] [stderr] 249 | } else if self.client_id.is_empty() { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 250 | | true [INFO] [stderr] 251 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/spotify/oauth2.rs:247:58 [INFO] [stderr] | [INFO] [stderr] 247 | let empty_flag = if self.redirect_uri.is_empty() { [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 248 | | true [INFO] [stderr] 249 | | } else if self.client_id.is_empty() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:283:26 [INFO] [stderr] | [INFO] [stderr] 283 | .expect(&format!("convert [{:?}] to json failed", [INFO] [stderr] | __________________________^ [INFO] [stderr] 284 | | self.cache_path.display())); [INFO] [stderr] | |___________________________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("convert [{:?}] to json failed", self.cache_path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:420:10 [INFO] [stderr] | [INFO] [stderr] 420 | .expect(&format!("create file {:?} error", path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("create file {:?} error", path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/spotify/oauth2.rs:422:10 [INFO] [stderr] | [INFO] [stderr] 422 | .expect(&format!("clear original spoitfy-token-cache file [{:?}] failed", [INFO] [stderr] | __________^ [INFO] [stderr] 423 | | path.display())); [INFO] [stderr] | |________________________________________^ help: try this: `unwrap_or_else(|_| panic!("clear original spoitfy-token-cache file [{:?}] failed", path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference [INFO] [stderr] --> src/spotify/client.rs:1672:47 [INFO] [stderr] | [INFO] [stderr] 1672 | let id = spotify.get_id(Type::Artist, &mut artist_id); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference [INFO] [stderr] --> src/spotify/client.rs:1678:54 [INFO] [stderr] | [INFO] [stderr] 1678 | &spotify.get_id(Type::Album, &mut artist_id_a) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference [INFO] [stderr] --> src/spotify/client.rs:1685:55 [INFO] [stderr] | [INFO] [stderr] 1685 | &spotify.get_id(Type::Artist, &mut artist_id_b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference [INFO] [stderr] --> src/spotify/client.rs:1692:55 [INFO] [stderr] | [INFO] [stderr] 1692 | &spotify.get_id(Type::Artist, &mut artist_id_c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `get_id` doesn't need a mutable reference [INFO] [stderr] --> src/spotify/client.rs:1698:57 [INFO] [stderr] | [INFO] [stderr] 1698 | &spotify.get_id(Type::Playlist, &mut playlist_id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/spotify/util.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | V: Debug+ToString>(map: &HashMap) -> String{ [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 33 | pub fn convert_map_to_string(map: &HashMap) -> String{ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 14 | | match s { [INFO] [stderr] 15 | | "album" => Some(AlbumType::Album), [INFO] [stderr] 16 | | "single" => Some(AlbumType::Single), [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 55 | | match s { [INFO] [stderr] 56 | | "artist" => Some(Type::Artist), [INFO] [stderr] 57 | | "album" => Some(Type::Album), [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 98 | | match s { [INFO] [stderr] 99 | | "long_term" => Some(TimeRange::LongTerm), [INFO] [stderr] 100 | | "medium_term" => Some(TimeRange::MediumTerm), [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 379 | | match s { [INFO] [stderr] 380 | | "AF" => Some(Country::Afghanistan), [INFO] [stderr] 381 | | "AX" => Some(Country::AlandIslands), [INFO] [stderr] ... | [INFO] [stderr] 631 | | } [INFO] [stderr] 632 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:1157:5 [INFO] [stderr] | [INFO] [stderr] 1157 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 1158 | | match s { [INFO] [stderr] 1159 | | "off" => Some(RepeatState::Off), [INFO] [stderr] 1160 | | "track" => Some(RepeatState::Track), [INFO] [stderr] ... | [INFO] [stderr] 1163 | | } [INFO] [stderr] 1164 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/spotify/senum.rs:1185:5 [INFO] [stderr] | [INFO] [stderr] 1185 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 1186 | | match s { [INFO] [stderr] 1187 | | "artist" => Some(SearchType::Artist), [INFO] [stderr] 1188 | | "album" => Some(SearchType::Album), [INFO] [stderr] ... | [INFO] [stderr] 1192 | | } [INFO] [stderr] 1193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rspotify`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rspotify`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "89826dd438c29841d448af86285800a17533e390bf785662cf1870411e65e8de"` [INFO] running `"docker" "rm" "-f" "89826dd438c29841d448af86285800a17533e390bf785662cf1870411e65e8de"` [INFO] [stdout] 89826dd438c29841d448af86285800a17533e390bf785662cf1870411e65e8de