[INFO] updating cached repository samkellett/battles [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samkellett/battles [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samkellett/battles" "work/ex/clippy-test-run/sources/stable/gh/samkellett/battles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samkellett/battles'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samkellett/battles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samkellett/battles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samkellett/battles'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8df3ba14f715d4799059a43b4bb6aa0cc7adbf96 [INFO] sha for GitHub repo samkellett/battles: 8df3ba14f715d4799059a43b4bb6aa0cc7adbf96 [INFO] validating manifest of samkellett/battles on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samkellett/battles on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samkellett/battles [INFO] finished frobbing samkellett/battles [INFO] frobbed toml for samkellett/battles written to work/ex/clippy-test-run/sources/stable/gh/samkellett/battles/Cargo.toml [INFO] started frobbing samkellett/battles [INFO] finished frobbing samkellett/battles [INFO] frobbed toml for samkellett/battles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samkellett/battles/Cargo.toml [INFO] crate samkellett/battles has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samkellett/battles against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samkellett/battles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 285caf236a8aef6499980702ae48abc5a68ba3dda1649a8e5244c002ba845d10 [INFO] running `"docker" "start" "-a" "285caf236a8aef6499980702ae48abc5a68ba3dda1649a8e5244c002ba845d10"` [INFO] [stderr] Compiling serde v0.9.12 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Compiling syn v0.11.10 [INFO] [stderr] Compiling glium v0.16.0 [INFO] [stderr] Checking x11-dl v2.12.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Compiling serde_derive v0.9.13 [INFO] [stderr] Compiling serde_json v0.9.9 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking battles v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/004-new_renderer.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | facade: facade, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `facade` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/004-new_renderer.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | vertex_buffer: vertex_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/004-new_renderer.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | index_buffer: index_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/sprites/mesh.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | verts: verts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/sprites/mesh.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/gliumwindow.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | GliumWindow { facade: facade } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `facade` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/game_object.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | transform: transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/sprites/mesh.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | verts: verts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verts` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/003-textures.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | TextureCollection { textures: textures, views: views } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/003-textures.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | TextureCollection { textures: textures, views: views } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/sprites/mesh.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/gliumwindow.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | GliumWindow { facade: facade } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `facade` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/game_object.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | transform: transform, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transform` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/002-materials.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/002-materials.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/002-materials.rs:106:30 [INFO] [stderr] | [INFO] [stderr] 106 | MaterialCollection { materials: materials } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `materials` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/001-renderer.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | verts: verts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/001-renderer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/001-renderer.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | mesh: mesh, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mesh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Rotation` [INFO] [stderr] --> examples/003-transform.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | enum Rotation { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rotate_z` [INFO] [stderr] --> examples/003-transform.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn rotate_z (&mut self, rotation: Rotation) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/004-new_renderer.rs:27:47 [INFO] [stderr] | [INFO] [stderr] 27 | fn create_vertex_buffer (&self, vertices: &Vec) -> glium::VertexBuffer { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Vertex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/004-new_renderer.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / match ev { [INFO] [stderr] 110 | | glium::glutin::Event::Closed => return, [INFO] [stderr] 111 | | _ => () [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ help: try this: `if let glium::glutin::Event::Closed = ev { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/001-renderer.rs:162:24 [INFO] [stderr] | [INFO] [stderr] 162 | &perspective.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `perspective` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> examples/001-renderer.rs:171:24 [INFO] [stderr] | [INFO] [stderr] 171 | &perspective.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `perspective` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/001-renderer.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | / match ev { [INFO] [stderr] 177 | | glium::glutin::Event::Closed => return, [INFO] [stderr] 178 | | _ => (), [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ help: try this: `if let glium::glutin::Event::Closed = ev { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut game_object = game_objects.first_mut().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let mut game_object = game_objects.first_mut().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square_slice` [INFO] [stderr] --> src/render/sprites/mesh.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn square_slice(size: f32, [INFO] [stderr] 43 | | origin: &cgmath::Vector2, [INFO] [stderr] 44 | | dimensions: &cgmath::Vector2, [INFO] [stderr] 45 | | parent_dimensions: &cgmath::Vector2) [INFO] [stderr] ... | [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `square_slice` [INFO] [stderr] --> src/render/sprites/mesh.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn square_slice(size: f32, [INFO] [stderr] 43 | | origin: &cgmath::Vector2, [INFO] [stderr] 44 | | dimensions: &cgmath::Vector2, [INFO] [stderr] 45 | | parent_dimensions: &cgmath::Vector2) [INFO] [stderr] ... | [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | origin: &cgmath::Vector2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | dimensions: &cgmath::Vector2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | parent_dimensions: &cgmath::Vector2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/window.rs:4:49 [INFO] [stderr] | [INFO] [stderr] 4 | fn create_vertex_buffer(&self, vertices: &Vec) -> VertexBuffer where T: Vertex; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/window.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | fn create_index_buffer(&self, indices: &Vec) -> IndexBuffer; [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | origin: &cgmath::Vector2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | dimensions: &cgmath::Vector2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render/sprites/mesh.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | parent_dimensions: &cgmath::Vector2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `cgmath::Vector2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/window.rs:4:49 [INFO] [stderr] | [INFO] [stderr] 4 | fn create_vertex_buffer(&self, vertices: &Vec) -> VertexBuffer where T: Vertex; [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/window.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | fn create_index_buffer(&self, indices: &Vec) -> IndexBuffer; [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match event { [INFO] [stderr] 38 | | // The window has been closed. [INFO] [stderr] 39 | | glium::glutin::Event::Closed => return, [INFO] [stderr] 40 | | _ => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try this: `if let glium::glutin::Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match event { [INFO] [stderr] 38 | | // The window has been closed. [INFO] [stderr] 39 | | glium::glutin::Event::Closed => return, [INFO] [stderr] 40 | | _ => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: try this: `if let glium::glutin::Event::Closed = event { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `"docker" "inspect" "285caf236a8aef6499980702ae48abc5a68ba3dda1649a8e5244c002ba845d10"` [INFO] running `"docker" "rm" "-f" "285caf236a8aef6499980702ae48abc5a68ba3dda1649a8e5244c002ba845d10"` [INFO] [stdout] 285caf236a8aef6499980702ae48abc5a68ba3dda1649a8e5244c002ba845d10