[INFO] updating cached repository sami-badawi/shapelogic-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sami-badawi/shapelogic-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sami-badawi/shapelogic-rust" "work/ex/clippy-test-run/sources/stable/gh/sami-badawi/shapelogic-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sami-badawi/shapelogic-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sami-badawi/shapelogic-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sami-badawi/shapelogic-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sami-badawi/shapelogic-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1c64c067161cb605b2379c7c3ad2d109fb901ed8 [INFO] sha for GitHub repo sami-badawi/shapelogic-rust: 1c64c067161cb605b2379c7c3ad2d109fb901ed8 [INFO] validating manifest of sami-badawi/shapelogic-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sami-badawi/shapelogic-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sami-badawi/shapelogic-rust [INFO] finished frobbing sami-badawi/shapelogic-rust [INFO] frobbed toml for sami-badawi/shapelogic-rust written to work/ex/clippy-test-run/sources/stable/gh/sami-badawi/shapelogic-rust/Cargo.toml [INFO] started frobbing sami-badawi/shapelogic-rust [INFO] finished frobbing sami-badawi/shapelogic-rust [INFO] frobbed toml for sami-badawi/shapelogic-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sami-badawi/shapelogic-rust/Cargo.toml [INFO] crate sami-badawi/shapelogic-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sami-badawi/shapelogic-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sami-badawi/shapelogic-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c96ea5908d0b2e965e601524ccd66939c16aa12426f4be7c182d893ef4d4436c [INFO] running `"docker" "start" "-a" "c96ea5908d0b2e965e601524ccd66939c16aa12426f4be7c182d893ef4d4436c"` [INFO] [stderr] Checking either v1.2.0 [INFO] [stderr] Checking png v0.10.0 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking shapelogic-rust v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | inverted: inverted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inverted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | fg_color: fg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `fg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | inverted: inverted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inverted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/morphology/skeletonize.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | fg_color: fg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `fg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/dilate_erode.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/dilate_erode.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | let res = image::ImageLuma8(imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/dilate_erode.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/dilate_erode.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | let res = image::ImageLuma8(imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/image_create.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | imgbuf [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/image_create.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | let imgbuf = image::ImageBuffer::new(imgx, imgy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/skeletonize.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | buffer [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/skeletonize.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let buffer = image_create::make_raw_buffer(width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/image_macro.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/image_macro.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let res = match index_pt { [INFO] [stderr] | _______________^ [INFO] [stderr] 19 | | Some(index) => ImageCommand { [INFO] [stderr] 20 | | command: ¯o_input[0..index].trim(), [INFO] [stderr] 21 | | parameter: ¯o_input[index..string_len].trim(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/dilate_erode.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/dilate_erode.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | let res = image::ImageLuma8(imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/dilate_erode.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/dilate_erode.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | let res = image::ImageLuma8(imgbuf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/image_create.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | imgbuf [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/image_create.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | let imgbuf = image::ImageBuffer::new(imgx, imgy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/morphology/skeletonize.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | buffer [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/morphology/skeletonize.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | let buffer = image_create::make_raw_buffer(width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/image_macro.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/image_macro.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | let res = match index_pt { [INFO] [stderr] | _______________^ [INFO] [stderr] 19 | | Some(index) => ImageCommand { [INFO] [stderr] 20 | | command: ¯o_input[0..index].trim(), [INFO] [stderr] 21 | | parameter: ¯o_input[index..string_len].trim(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let x_c = x as i32 + xy.0 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let y_c = y as i32 + xy.1 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | let x_c = x as i32 + xy.0 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | let y_c = y as i32 + xy.1 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/morphology/image_create.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 25 | let mut vec = Vec::with_capacity(final_length); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; final_length]` [INFO] [stderr] 26 | vec.resize(final_length, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/morphology/skeletonize.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn skeletonize<'a>(image: &'a GrayImage, invert: bool) -> DynamicImage { [INFO] [stderr] 25 | | let mut skeletonize = Skeletonize::new(image, invert); [INFO] [stderr] 26 | | let (width, height) = image.dimensions(); [INFO] [stderr] 27 | | skeletonize.skeletonize(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:24:38 [INFO] [stderr] | [INFO] [stderr] 24 | let x_c = x as i32 + xy.0 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:25:38 [INFO] [stderr] | [INFO] [stderr] 25 | let y_c = y as i32 + xy.1 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | let x_c = x as i32 + xy.0 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/morphology/dilate_erode.rs:64:38 [INFO] [stderr] | [INFO] [stderr] 64 | let y_c = y as i32 + xy.1 as i32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(xy.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/morphology/image_create.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 25 | let mut vec = Vec::with_capacity(final_length); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; final_length]` [INFO] [stderr] 26 | vec.resize(final_length, 0u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/morphology/skeletonize.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn skeletonize<'a>(image: &'a GrayImage, invert: bool) -> DynamicImage { [INFO] [stderr] 25 | | let mut skeletonize = Skeletonize::new(image, invert); [INFO] [stderr] 26 | | let (width, height) = image.dimensions(); [INFO] [stderr] 27 | | skeletonize.skeletonize(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/morphology/skeletonize.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | if pixels_removed <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using pixels_removed == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/morphology/skeletonize.rs:210:16 [INFO] [stderr] | [INFO] [stderr] 210 | if pixels_removed <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using pixels_removed == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/morphology/skeletonize.rs:197:16 [INFO] [stderr] | [INFO] [stderr] 197 | if pixels_removed <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using pixels_removed == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/morphology/skeletonize.rs:210:16 [INFO] [stderr] | [INFO] [stderr] 210 | if pixels_removed <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using pixels_removed == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/image_macro.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | .filter(|line_e| 0 < line_e.trim().len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line_e.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/image_macro.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | .filter(|line_e| 0 < line_e.trim().len()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line_e.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | if macro_input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `macro_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | if macro_input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `macro_input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `shapelogic-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `shapelogic-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c96ea5908d0b2e965e601524ccd66939c16aa12426f4be7c182d893ef4d4436c"` [INFO] running `"docker" "rm" "-f" "c96ea5908d0b2e965e601524ccd66939c16aa12426f4be7c182d893ef4d4436c"` [INFO] [stdout] c96ea5908d0b2e965e601524ccd66939c16aa12426f4be7c182d893ef4d4436c