[INFO] updating cached repository samgwise/osc-gpio-bridge
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/samgwise/osc-gpio-bridge
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/samgwise/osc-gpio-bridge" "work/ex/clippy-test-run/sources/stable/gh/samgwise/osc-gpio-bridge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samgwise/osc-gpio-bridge'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/samgwise/osc-gpio-bridge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samgwise/osc-gpio-bridge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samgwise/osc-gpio-bridge'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0d7a014c7ec482fc8acb26dc7b8f2047f6b7083b
[INFO] sha for GitHub repo samgwise/osc-gpio-bridge: 0d7a014c7ec482fc8acb26dc7b8f2047f6b7083b
[INFO] validating manifest of samgwise/osc-gpio-bridge on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of samgwise/osc-gpio-bridge on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing samgwise/osc-gpio-bridge
[INFO] finished frobbing samgwise/osc-gpio-bridge
[INFO] frobbed toml for samgwise/osc-gpio-bridge written to work/ex/clippy-test-run/sources/stable/gh/samgwise/osc-gpio-bridge/Cargo.toml
[INFO] started frobbing samgwise/osc-gpio-bridge
[INFO] finished frobbing samgwise/osc-gpio-bridge
[INFO] frobbed toml for samgwise/osc-gpio-bridge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samgwise/osc-gpio-bridge/Cargo.toml
[INFO] crate samgwise/osc-gpio-bridge has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting samgwise/osc-gpio-bridge against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samgwise/osc-gpio-bridge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 95e251941d8ac6cddcbfe71dfccb0eda6b09cad26b97140f500eaf026082ecc8
[INFO] running `"docker" "start" "-a" "95e251941d8ac6cddcbfe71dfccb0eda6b09cad26b97140f500eaf026082ecc8"`
[INFO] [stderr]     Checking rosc v0.1.5
[INFO] [stderr]     Checking serde_yaml v0.7.3
[INFO] [stderr]     Checking rppal v0.4.0
[INFO] [stderr]     Checking osc-gpio-bridge v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:181:29
[INFO] [stderr]     |
[INFO] [stderr] 181 |                             ()
[INFO] [stderr]     |                             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:181:29
[INFO] [stderr]     |
[INFO] [stderr] 181 |                             ()
[INFO] [stderr]     |                             ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:36:34
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn load_from_file(file_name: &String) -> Result<OscConfig, String> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             format!("{}", args[1])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:106:55
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let socket_in  = UdpSocket::bind(host_address_in).expect( format!("Unable to provision socket: {}", host_address_in).as_str() );
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to provision socket: {}", host_address_in))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:107:56
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let socket_out = UdpSocket::bind(host_address_out).expect( format!("Unable to provision socket: {}", host_address_out).as_str() );
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to provision socket: {}", host_address_out))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:190:25
[INFO] [stderr]     |
[INFO] [stderr] 190 | fn level_to_bool(level: &Level) -> bool {
[INFO] [stderr]     |                         ^^^^^^ help: consider passing by value instead: `Level`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:191:5
[INFO] [stderr]     |
[INFO] [stderr] 191 | /     match level {
[INFO] [stderr] 192 | |         &Level::Low  => false,
[INFO] [stderr] 193 | |         &Level::High => true,
[INFO] [stderr] 194 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 191 |     match *level {
[INFO] [stderr] 192 |         Level::Low  => false,
[INFO] [stderr] 193 |         Level::High => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:197:25
[INFO] [stderr]     |
[INFO] [stderr] 197 | fn bool_to_level(level: &bool) -> Level {
[INFO] [stderr]     |                         ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 | /     match level {
[INFO] [stderr] 199 | |         &false => Level::Low,
[INFO] [stderr] 200 | |         &true  => Level::High,
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 198 |     match *level {
[INFO] [stderr] 199 |         false => Level::Low,
[INFO] [stderr] 200 |         true  => Level::High,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 | /     match osc_arg {
[INFO] [stderr] 247 | |         &OscType::Int(int32)    => Some(int32 as u8),
[INFO] [stderr] 248 | |         &OscType::Char(int8)    => Some(int8 as u8),
[INFO] [stderr] 249 | |         _                       => None
[INFO] [stderr] 250 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 246 |     match *osc_arg {
[INFO] [stderr] 247 |         OscType::Int(int32)    => Some(int32 as u8),
[INFO] [stderr] 248 |         OscType::Char(int8)    => Some(int8 as u8),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:254:5
[INFO] [stderr]     |
[INFO] [stderr] 254 | /     match osc_arg {
[INFO] [stderr] 255 | |         &OscType::Bool(boolean) => Some(boolean),
[INFO] [stderr] 256 | |         _                       => None
[INFO] [stderr] 257 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 254 |     match *osc_arg {
[INFO] [stderr] 255 |         OscType::Bool(boolean) => Some(boolean),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/config/mod.rs:36:34
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn load_from_file(file_name: &String) -> Result<OscConfig, String> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:41:13
[INFO] [stderr]    |
[INFO] [stderr] 41 |             format!("{}", args[1])
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:106:55
[INFO] [stderr]     |
[INFO] [stderr] 106 |     let socket_in  = UdpSocket::bind(host_address_in).expect( format!("Unable to provision socket: {}", host_address_in).as_str() );
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to provision socket: {}", host_address_in))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:107:56
[INFO] [stderr]     |
[INFO] [stderr] 107 |     let socket_out = UdpSocket::bind(host_address_out).expect( format!("Unable to provision socket: {}", host_address_out).as_str() );
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to provision socket: {}", host_address_out))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:190:25
[INFO] [stderr]     |
[INFO] [stderr] 190 | fn level_to_bool(level: &Level) -> bool {
[INFO] [stderr]     |                         ^^^^^^ help: consider passing by value instead: `Level`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:191:5
[INFO] [stderr]     |
[INFO] [stderr] 191 | /     match level {
[INFO] [stderr] 192 | |         &Level::Low  => false,
[INFO] [stderr] 193 | |         &Level::High => true,
[INFO] [stderr] 194 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 191 |     match *level {
[INFO] [stderr] 192 |         Level::Low  => false,
[INFO] [stderr] 193 |         Level::High => true,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:197:25
[INFO] [stderr]     |
[INFO] [stderr] 197 | fn bool_to_level(level: &bool) -> Level {
[INFO] [stderr]     |                         ^^^^^ help: consider passing by value instead: `bool`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 | /     match level {
[INFO] [stderr] 199 | |         &false => Level::Low,
[INFO] [stderr] 200 | |         &true  => Level::High,
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 198 |     match *level {
[INFO] [stderr] 199 |         false => Level::Low,
[INFO] [stderr] 200 |         true  => Level::High,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 | /     match osc_arg {
[INFO] [stderr] 247 | |         &OscType::Int(int32)    => Some(int32 as u8),
[INFO] [stderr] 248 | |         &OscType::Char(int8)    => Some(int8 as u8),
[INFO] [stderr] 249 | |         _                       => None
[INFO] [stderr] 250 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 246 |     match *osc_arg {
[INFO] [stderr] 247 |         OscType::Int(int32)    => Some(int32 as u8),
[INFO] [stderr] 248 |         OscType::Char(int8)    => Some(int8 as u8),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/main.rs:254:5
[INFO] [stderr]     |
[INFO] [stderr] 254 | /     match osc_arg {
[INFO] [stderr] 255 | |         &OscType::Bool(boolean) => Some(boolean),
[INFO] [stderr] 256 | |         _                       => None
[INFO] [stderr] 257 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 254 |     match *osc_arg {
[INFO] [stderr] 255 |         OscType::Bool(boolean) => Some(boolean),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.59s
[INFO] running `"docker" "inspect" "95e251941d8ac6cddcbfe71dfccb0eda6b09cad26b97140f500eaf026082ecc8"`
[INFO] running `"docker" "rm" "-f" "95e251941d8ac6cddcbfe71dfccb0eda6b09cad26b97140f500eaf026082ecc8"`
[INFO] [stdout] 95e251941d8ac6cddcbfe71dfccb0eda6b09cad26b97140f500eaf026082ecc8