[INFO] updating cached repository samfoo/carto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samfoo/carto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samfoo/carto" "work/ex/clippy-test-run/sources/stable/gh/samfoo/carto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samfoo/carto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samfoo/carto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samfoo/carto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samfoo/carto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8b6b29c9e7e9a5d8d2e7d6b0551ba1ea0b8f148a [INFO] sha for GitHub repo samfoo/carto: 8b6b29c9e7e9a5d8d2e7d6b0551ba1ea0b8f148a [INFO] validating manifest of samfoo/carto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samfoo/carto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samfoo/carto [INFO] finished frobbing samfoo/carto [INFO] frobbed toml for samfoo/carto written to work/ex/clippy-test-run/sources/stable/gh/samfoo/carto/Cargo.toml [INFO] started frobbing samfoo/carto [INFO] finished frobbing samfoo/carto [INFO] frobbed toml for samfoo/carto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samfoo/carto/Cargo.toml [INFO] crate samfoo/carto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samfoo/carto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samfoo/carto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a18f79f7de6ec3effbc615725be0f748260658c407dc7337a5fb3953a94ef828 [INFO] running `"docker" "start" "-a" "a18f79f7de6ec3effbc615725be0f748260658c407dc7337a5fb3953a94ef828"` [INFO] [stderr] Compiling rayon-core v1.0.2 [INFO] [stderr] Checking deque v0.3.2 [INFO] [stderr] Checking gif v0.9.1 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking carto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | fn smooth_noise(base_noise: &WhiteNoise, octave: u32) -> Octave { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Octave]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perlin.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | for _ in 0..height { cols.push(0 as f64); } [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rows`. [INFO] [stderr] --> src/perlin.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in rows.iter_mut().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `hm`. [INFO] [stderr] --> src/perlin.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in hm.iter().take(10) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `o`. [INFO] [stderr] --> src/perlin.rs:183:18 [INFO] [stderr] | [INFO] [stderr] 183 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 183 | for in o.iter().take(10) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `o`. [INFO] [stderr] --> src/perlin.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 205 | for in o.iter().take(100) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | fn smooth_noise(base_noise: &WhiteNoise, octave: u32) -> Octave { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Octave]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perlin.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | for _ in 0..height { cols.push(0 as f64); } [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rows`. [INFO] [stderr] --> src/perlin.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in rows.iter_mut().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | fn smooth_noise(base_noise: &WhiteNoise, octave: u32) -> Octave { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Octave]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perlin.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | for _ in 0..height { cols.push(0 as f64); } [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rows`. [INFO] [stderr] --> src/perlin.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in rows.iter_mut().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref mut fout = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:58:29 [INFO] [stderr] | [INFO] [stderr] 58 | fn smooth_noise(base_noise: &WhiteNoise, octave: u32) -> Octave { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/perlin.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | fn blend(base_noise: &WhiteNoise, octaves: &Vec) -> HeightMap { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Octave]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/perlin.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | for _ in 0..height { cols.push(0 as f64); } [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rows`. [INFO] [stderr] --> src/perlin.rs:127:14 [INFO] [stderr] | [INFO] [stderr] 127 | for i in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 127 | for in rows.iter_mut().take(width) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `hm`. [INFO] [stderr] --> src/perlin.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in hm.iter().take(10) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `o`. [INFO] [stderr] --> src/perlin.rs:183:18 [INFO] [stderr] | [INFO] [stderr] 183 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 183 | for in o.iter().take(10) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `o`. [INFO] [stderr] --> src/perlin.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 0..100 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 205 | for in o.iter().take(100) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref mut fout = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------ help: try: `let fout = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.73s [INFO] running `"docker" "inspect" "a18f79f7de6ec3effbc615725be0f748260658c407dc7337a5fb3953a94ef828"` [INFO] running `"docker" "rm" "-f" "a18f79f7de6ec3effbc615725be0f748260658c407dc7337a5fb3953a94ef828"` [INFO] [stdout] a18f79f7de6ec3effbc615725be0f748260658c407dc7337a5fb3953a94ef828