[INFO] updating cached repository samdoiron/plasma [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samdoiron/plasma [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samdoiron/plasma" "work/ex/clippy-test-run/sources/stable/gh/samdoiron/plasma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samdoiron/plasma'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samdoiron/plasma" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samdoiron/plasma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samdoiron/plasma'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9b1e7fb9ededfe6cbb8c49860d873fb99bca68b4 [INFO] sha for GitHub repo samdoiron/plasma: 9b1e7fb9ededfe6cbb8c49860d873fb99bca68b4 [INFO] validating manifest of samdoiron/plasma on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samdoiron/plasma on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samdoiron/plasma [INFO] finished frobbing samdoiron/plasma [INFO] frobbed toml for samdoiron/plasma written to work/ex/clippy-test-run/sources/stable/gh/samdoiron/plasma/Cargo.toml [INFO] started frobbing samdoiron/plasma [INFO] finished frobbing samdoiron/plasma [INFO] frobbed toml for samdoiron/plasma written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samdoiron/plasma/Cargo.toml [INFO] crate samdoiron/plasma has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samdoiron/plasma against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/samdoiron/plasma:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed6b2fc0dbdd9719cd6fd4ac98209cd4b4c86660f18ee167e054b0cf608be64b [INFO] running `"docker" "start" "-a" "ed6b2fc0dbdd9719cd6fd4ac98209cd4b4c86660f18ee167e054b0cf608be64b"` [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking pest v2.0.2 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking plasma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: struct is never constructed: `PlasmaParser` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | struct PlasmaParser; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Expressions` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Expressions(Vec>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Assignment` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Assignment(&'a str, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Number(i64), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Identifier` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Identifier(&'a str) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Pair` [INFO] [stderr] --> src/main.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | type Pair<'a> = pest::iterators::Pair<'a, Rule>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_number` [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_number(pair: Pair) -> AstNode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_identifier` [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | fn parse_identifier<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_assignment` [INFO] [stderr] --> src/main.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | fn parse_assignment<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_expression` [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | fn parse_expression<'a>(expression: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse` [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | fn parse<'a>(code: &'a str) -> AstNode<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `assert_parses_to` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | fn assert_parses_to(input: &str, output: AstNode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn parse_identifier<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 26 | | AstNode::Identifier(pair.as_str()) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / fn parse_assignment<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 30 | | let mut inner = pair.into_inner(); [INFO] [stderr] 31 | | let ident = inner.next().expect("identifier").as_str(); [INFO] [stderr] 32 | | let expression = parse_expression(inner.next().expect("expression")); [INFO] [stderr] 33 | | AstNode::Assignment(ident, Box::new(expression)) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn parse_expression<'a>(expression: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 37 | | match expression.as_rule() { [INFO] [stderr] 38 | | Rule::number => parse_number(expression), [INFO] [stderr] 39 | | Rule::identifier => parse_identifier(expression), [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / fn parse<'a>(code: &'a str) -> AstNode<'a> { [INFO] [stderr] 46 | | let mut pairs = PlasmaParser::parse(Rule::expressions, code) [INFO] [stderr] 47 | | .expect("initial parse"); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 62 | | AstNode::Expressions(expressions_vec) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let expressions_vec = expressions [INFO] [stderr] | ___________________________^ [INFO] [stderr] 53 | | .into_inner().into_iter() [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 52 | let expressions_vec = expressions [INFO] [stderr] 53 | .into_inner() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn parse_identifier<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 26 | | AstNode::Identifier(pair.as_str()) [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / fn parse_assignment<'a>(pair: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 30 | | let mut inner = pair.into_inner(); [INFO] [stderr] 31 | | let ident = inner.next().expect("identifier").as_str(); [INFO] [stderr] 32 | | let expression = parse_expression(inner.next().expect("expression")); [INFO] [stderr] 33 | | AstNode::Assignment(ident, Box::new(expression)) [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn parse_expression<'a>(expression: Pair<'a>) -> AstNode<'a> { [INFO] [stderr] 37 | | match expression.as_rule() { [INFO] [stderr] 38 | | Rule::number => parse_number(expression), [INFO] [stderr] 39 | | Rule::identifier => parse_identifier(expression), [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / fn parse<'a>(code: &'a str) -> AstNode<'a> { [INFO] [stderr] 46 | | let mut pairs = PlasmaParser::parse(Rule::expressions, code) [INFO] [stderr] 47 | | .expect("initial parse"); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 62 | | AstNode::Expressions(expressions_vec) [INFO] [stderr] 63 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | let expressions_vec = expressions [INFO] [stderr] | ___________________________^ [INFO] [stderr] 53 | | .into_inner().into_iter() [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 52 | let expressions_vec = expressions [INFO] [stderr] 53 | .into_inner() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.49s [INFO] running `"docker" "inspect" "ed6b2fc0dbdd9719cd6fd4ac98209cd4b4c86660f18ee167e054b0cf608be64b"` [INFO] running `"docker" "rm" "-f" "ed6b2fc0dbdd9719cd6fd4ac98209cd4b4c86660f18ee167e054b0cf608be64b"` [INFO] [stdout] ed6b2fc0dbdd9719cd6fd4ac98209cd4b4c86660f18ee167e054b0cf608be64b