[INFO] updating cached repository saghm/monger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saghm/monger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saghm/monger" "work/ex/clippy-test-run/sources/stable/gh/saghm/monger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saghm/monger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saghm/monger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/monger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/monger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2b088ae8bcda01213bc3eba03991eedf55718d4c [INFO] sha for GitHub repo saghm/monger: 2b088ae8bcda01213bc3eba03991eedf55718d4c [INFO] validating manifest of saghm/monger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saghm/monger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saghm/monger [INFO] finished frobbing saghm/monger [INFO] frobbed toml for saghm/monger written to work/ex/clippy-test-run/sources/stable/gh/saghm/monger/Cargo.toml [INFO] started frobbing saghm/monger [INFO] finished frobbing saghm/monger [INFO] frobbed toml for saghm/monger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/monger/Cargo.toml [INFO] crate saghm/monger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saghm/monger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saghm/monger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5094cd3c21cbec9afeea4c29aec3dc80e4f74d365c97126fd747ff4036dd3903 [INFO] running `"docker" "start" "-a" "5094cd3c21cbec9afeea4c29aec3dc80e4f74d365c97126fd747ff4036dd3903"` [INFO] [stderr] Checking rs-release v0.1.7 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking encoding_rs v0.8.10 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking openssl v0.10.12 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking hyperx v0.13.1 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking native-tls v0.2.1 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking monger v0.5.7 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monger.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return Ok(processed_args); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(processed_args)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/monger.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | return Ok(processed_args); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(processed_args)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/fs.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> FsBuilder { [INFO] [stderr] 31 | | Default::default() [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/os/arch.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/url.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | version >= &FIRST_MACOS_VERSION && version < &LAST_MACOS_VERSION [INFO] [stderr] | ^^^^^^^^^^^-------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `FIRST_MACOS_VERSION` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/url.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | version >= &FIRST_MACOS_VERSION && version < &LAST_MACOS_VERSION [INFO] [stderr] | ^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `LAST_MACOS_VERSION` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/fs.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> FsBuilder { [INFO] [stderr] 31 | | Default::default() [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/os/arch.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn name(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/url.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | version >= &FIRST_MACOS_VERSION && version < &LAST_MACOS_VERSION [INFO] [stderr] | ^^^^^^^^^^^-------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `FIRST_MACOS_VERSION` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/url.rs:9:40 [INFO] [stderr] | [INFO] [stderr] 9 | version >= &FIRST_MACOS_VERSION && version < &LAST_MACOS_VERSION [INFO] [stderr] | ^^^^^^^^^^------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `LAST_MACOS_VERSION` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.02s [INFO] running `"docker" "inspect" "5094cd3c21cbec9afeea4c29aec3dc80e4f74d365c97126fd747ff4036dd3903"` [INFO] running `"docker" "rm" "-f" "5094cd3c21cbec9afeea4c29aec3dc80e4f74d365c97126fd747ff4036dd3903"` [INFO] [stdout] 5094cd3c21cbec9afeea4c29aec3dc80e4f74d365c97126fd747ff4036dd3903