[INFO] updating cached repository sagebind/winenv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sagebind/winenv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sagebind/winenv" "work/ex/clippy-test-run/sources/stable/gh/sagebind/winenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sagebind/winenv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sagebind/winenv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sagebind/winenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sagebind/winenv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b04e8eb9ccc1a68fabec10c0d4a179fbe9eeb076 [INFO] sha for GitHub repo sagebind/winenv: b04e8eb9ccc1a68fabec10c0d4a179fbe9eeb076 [INFO] validating manifest of sagebind/winenv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sagebind/winenv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sagebind/winenv [INFO] finished frobbing sagebind/winenv [INFO] frobbed toml for sagebind/winenv written to work/ex/clippy-test-run/sources/stable/gh/sagebind/winenv/Cargo.toml [INFO] started frobbing sagebind/winenv [INFO] finished frobbing sagebind/winenv [INFO] frobbed toml for sagebind/winenv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sagebind/winenv/Cargo.toml [INFO] crate sagebind/winenv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sagebind/winenv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sagebind/winenv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6870531a36a5f58b24b26f43cd6969c4ae2c82822fb33db417bb91bfb71ff9f4 [INFO] running `"docker" "start" "-a" "6870531a36a5f58b24b26f43cd6969c4ae2c82822fb33db417bb91bfb71ff9f4"` [INFO] [stderr] Checking ringtail v0.1.1 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.2 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Compiling filetime v0.1.15 [INFO] [stderr] Checking ar v0.6.0 [INFO] [stderr] Checking socket2 v0.3.5 [INFO] [stderr] Checking filetime v0.2.0 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking clogger v0.1.0 [INFO] [stderr] Compiling lzma-sys v0.1.9 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking tar v0.4.15 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking xz2 v0.1.4 [INFO] [stderr] Checking config v0.9.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.7 [INFO] [stderr] Checking structopt v0.2.7 [INFO] [stderr] Checking curl v0.4.12 [INFO] [stderr] Checking chttp v0.1.4 [INFO] [stderr] Checking winenv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wine.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wine.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Config`, `self` [INFO] [stderr] --> src/prefix.rs:2:14 [INFO] [stderr] | [INFO] [stderr] 2 | use config::{self, Config}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Config`, `self` [INFO] [stderr] --> src/prefix.rs:2:14 [INFO] [stderr] | [INFO] [stderr] 2 | use config::{self, Config}; [INFO] [stderr] | ^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/install.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | let mut spinner = indicatif::ProgressBar::new_spinner(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `downloads_dir` [INFO] [stderr] --> src/paths.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn downloads_dir() -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wine.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match self { [INFO] [stderr] 113 | | &Channel::Devel => write!(f, "devel"), [INFO] [stderr] 114 | | &Channel::Staging => write!(f, "staging"), [INFO] [stderr] 115 | | &Channel::Stable => write!(f, "stable"), [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 112 | match *self { [INFO] [stderr] 113 | Channel::Devel => write!(f, "devel"), [INFO] [stderr] 114 | Channel::Staging => write!(f, "staging"), [INFO] [stderr] 115 | Channel::Stable => write!(f, "stable"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / let mut args = args.to_vec(); [INFO] [stderr] 192 | | if *help { [INFO] [stderr] 193 | | args = vec![String::from("--help")]; [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let args = if *help { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { args.to_vec() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/install.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | let mut spinner = indicatif::ProgressBar::new_spinner(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `downloads_dir` [INFO] [stderr] --> src/paths.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn downloads_dir() -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wine.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / match self { [INFO] [stderr] 113 | | &Channel::Devel => write!(f, "devel"), [INFO] [stderr] 114 | | &Channel::Staging => write!(f, "staging"), [INFO] [stderr] 115 | | &Channel::Stable => write!(f, "stable"), [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 112 | match *self { [INFO] [stderr] 113 | Channel::Devel => write!(f, "devel"), [INFO] [stderr] 114 | Channel::Staging => write!(f, "staging"), [INFO] [stderr] 115 | Channel::Stable => write!(f, "stable"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | / let mut args = args.to_vec(); [INFO] [stderr] 192 | | if *help { [INFO] [stderr] 193 | | args = vec![String::from("--help")]; [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let args = if *help { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { args.to_vec() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 20s [INFO] running `"docker" "inspect" "6870531a36a5f58b24b26f43cd6969c4ae2c82822fb33db417bb91bfb71ff9f4"` [INFO] running `"docker" "rm" "-f" "6870531a36a5f58b24b26f43cd6969c4ae2c82822fb33db417bb91bfb71ff9f4"` [INFO] [stdout] 6870531a36a5f58b24b26f43cd6969c4ae2c82822fb33db417bb91bfb71ff9f4