[INFO] updating cached repository saf/completers
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/saf/completers
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/saf/completers" "work/ex/clippy-test-run/sources/stable/gh/saf/completers"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saf/completers'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/saf/completers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saf/completers"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saf/completers'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 346ac87d10f0d726daad4211bdba1ffc672e47b2
[INFO] sha for GitHub repo saf/completers: 346ac87d10f0d726daad4211bdba1ffc672e47b2
[INFO] validating manifest of saf/completers on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of saf/completers on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing saf/completers
[INFO] finished frobbing saf/completers
[INFO] frobbed toml for saf/completers written to work/ex/clippy-test-run/sources/stable/gh/saf/completers/Cargo.toml
[INFO] started frobbing saf/completers
[INFO] finished frobbing saf/completers
[INFO] frobbed toml for saf/completers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saf/completers/Cargo.toml
[INFO] crate saf/completers has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting saf/completers against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saf/completers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1c5494c8787c661d715c66fa8e8b522c79b377c76924c53eca7cd052096a9850
[INFO] running `"docker" "start" "-a" "1c5494c8787c661d715c66fa8e8b522c79b377c76924c53eca7cd052096a9850"`
[INFO] [stderr]     Checking time v0.1.40
[INFO] [stderr]     Checking termion v1.3.0
[INFO] [stderr]     Checking termios v0.2.2
[INFO] [stderr]     Checking log v0.4.3
[INFO] [stderr]     Checking term v0.5.1
[INFO] [stderr]     Checking itertools v0.6.0
[INFO] [stderr]     Checking chrono v0.4.4
[INFO] [stderr]     Checking simplelog v0.5.2
[INFO] [stderr]     Checking completers v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             entry_type: entry_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:180:13
[INFO] [stderr]     |
[INFO] [stderr] 180 |             thread: thread,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             request_send: request_send,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_send`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             response_recv: response_recv,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_recv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             dir_path: dir_path,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ui/model.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             completer: completer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:102:13
[INFO] [stderr]     |
[INFO] [stderr] 102 |             entry_type: entry_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entry_type`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ui/model.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             stacks: stacks,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stacks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:180:13
[INFO] [stderr]     |
[INFO] [stderr] 180 |             thread: thread,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `thread`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:181:13
[INFO] [stderr]     |
[INFO] [stderr] 181 |             request_send: request_send,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `request_send`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:182:13
[INFO] [stderr]     |
[INFO] [stderr] 182 |             response_recv: response_recv,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_recv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/completers/filesystem.rs:186:13
[INFO] [stderr]     |
[INFO] [stderr] 186 |             dir_path: dir_path,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ui/model.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             completer: completer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `completer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/ui/model.rs:166:13
[INFO] [stderr]     |
[INFO] [stderr] 166 |             stacks: stacks,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stacks`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/config.rs:4:29
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const WORD_BOUNDARIES: &'static [char] = &[' ', '(', ')', ':', '`'];
[INFO] [stderr]   |                            -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/terminal.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return Result::Ok(original_term_settings);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(original_term_settings)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/terminal.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     return Result::Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/mod.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return Result::Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ui/mod.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |     return Result::Ok((result_line, query_start + result.len()));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok((result_line, query_start + result.len()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ui/mod.rs:191:5
[INFO] [stderr]     |
[INFO] [stderr] 191 |     return Result::Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/lib.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/config.rs:4:29
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub const WORD_BOUNDARIES: &'static [char] = &[' ', '(', ')', ':', '`'];
[INFO] [stderr]   |                            -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/terminal.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return Result::Ok(original_term_settings);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(original_term_settings)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/terminal.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     return Result::Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ui/mod.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 |     return Result::Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ui/mod.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |     return Result::Ok((result_line, query_start + result.len()));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok((result_line, query_start + result.len()))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ui/mod.rs:191:5
[INFO] [stderr]     |
[INFO] [stderr] 191 |     return Result::Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/completers/filesystem.rs:64:12
[INFO] [stderr]    |
[INFO] [stderr] 64 |       if let None = queue_entry {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 65 | |         return vec![];
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____- help: try this: `if queue_entry.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/completers/filesystem.rs:70:12
[INFO] [stderr]    |
[INFO] [stderr] 70 |       if let Err(_) = read_dir_result {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 71 | |         return vec![];
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____- help: try this: `if read_dir_result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/completers/filesystem.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |             if s.starts_with(".") {
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/completers/filesystem.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 | /         match self.fetching_thread {
[INFO] [stderr] 216 | |             Some(_) => false,
[INFO] [stderr] 217 | |             None    => true,
[INFO] [stderr] 218 | |         }
[INFO] [stderr]     | |_________^ help: try this: `self.fetching_thread.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `completers::git::GitBranchCompleter`
[INFO] [stderr]   --> src/completers/git.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn new() -> GitBranchCompleter {
[INFO] [stderr] 55 | |         GitBranchCompleter {
[INFO] [stderr] 56 | |             all_completions: vec![],
[INFO] [stderr] 57 | |             query: String::new(),
[INFO] [stderr] 58 | |             filtered_completions: vec![],
[INFO] [stderr] 59 | |         }
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ui/model.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |             self.view_offset = self.view_offset - 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.view_offset -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ui/model.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             self.view_offset = self.view_offset + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.view_offset += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/completers/filesystem.rs:64:12
[INFO] [stderr]    |
[INFO] [stderr] 64 |       if let None = queue_entry {
[INFO] [stderr]    |  _____-      ^^^^
[INFO] [stderr] 65 | |         return vec![];
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____- help: try this: `if queue_entry.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]   --> src/completers/filesystem.rs:70:12
[INFO] [stderr]    |
[INFO] [stderr] 70 |       if let Err(_) = read_dir_result {
[INFO] [stderr]    |  _____-      ^^^^^^
[INFO] [stderr] 71 | |         return vec![];
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____- help: try this: `if read_dir_result.is_err()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/completers/filesystem.rs:91:30
[INFO] [stderr]    |
[INFO] [stderr] 91 |             if s.starts_with(".") {
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]    --> src/completers/filesystem.rs:215:9
[INFO] [stderr]     |
[INFO] [stderr] 215 | /         match self.fetching_thread {
[INFO] [stderr] 216 | |             Some(_) => false,
[INFO] [stderr] 217 | |             None    => true,
[INFO] [stderr] 218 | |         }
[INFO] [stderr]     | |_________^ help: try this: `self.fetching_thread.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/ui/mod.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |     for _ in 0..(CHOOSER_HEIGHT + 1) {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=CHOOSER_HEIGHT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `completers::git::GitBranchCompleter`
[INFO] [stderr]   --> src/completers/git.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     pub fn new() -> GitBranchCompleter {
[INFO] [stderr] 55 | |         GitBranchCompleter {
[INFO] [stderr] 56 | |             all_completions: vec![],
[INFO] [stderr] 57 | |             query: String::new(),
[INFO] [stderr] 58 | |             filtered_completions: vec![],
[INFO] [stderr] 59 | |         }
[INFO] [stderr] 60 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ui/model.rs:47:13
[INFO] [stderr]    |
[INFO] [stderr] 47 |             self.view_offset = self.view_offset - 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.view_offset -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ui/model.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 |             self.view_offset = self.view_offset + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.view_offset += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/ui/mod.rs:186:14
[INFO] [stderr]     |
[INFO] [stderr] 186 |     for _ in 0..(CHOOSER_HEIGHT + 1) {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=CHOOSER_HEIGHT`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return ui::get_completion(line, point, completers);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ui::get_completion(line, point, completers)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     return ui::get_completion(line, point, completers);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ui::get_completion(line, point, completers)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     let log_level: log::LevelFilter;
[INFO] [stderr] 46 | |     if arguments.is_present("debug") {
[INFO] [stderr] 47 | |         log_level = log::LevelFilter::Debug;
[INFO] [stderr] 48 | |     } else {
[INFO] [stderr] 49 | |         log_level = log::LevelFilter::Warn;
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let log_level = if arguments.is_present("debug") { log::LevelFilter::Debug } else { log::LevelFilter::Warn };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     let log_level: log::LevelFilter;
[INFO] [stderr] 46 | |     if arguments.is_present("debug") {
[INFO] [stderr] 47 | |         log_level = log::LevelFilter::Debug;
[INFO] [stderr] 48 | |     } else {
[INFO] [stderr] 49 | |         log_level = log::LevelFilter::Warn;
[INFO] [stderr] 50 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let log_level = if arguments.is_present("debug") { log::LevelFilter::Debug } else { log::LevelFilter::Warn };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.49s
[INFO] running `"docker" "inspect" "1c5494c8787c661d715c66fa8e8b522c79b377c76924c53eca7cd052096a9850"`
[INFO] running `"docker" "rm" "-f" "1c5494c8787c661d715c66fa8e8b522c79b377c76924c53eca7cd052096a9850"`
[INFO] [stdout] 1c5494c8787c661d715c66fa8e8b522c79b377c76924c53eca7cd052096a9850