[INFO] updating cached repository saebs/ipsniff [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saebs/ipsniff [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saebs/ipsniff" "work/ex/clippy-test-run/sources/stable/gh/saebs/ipsniff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saebs/ipsniff'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saebs/ipsniff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/ipsniff"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/ipsniff'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 55b09a2703742fe98d17cd212eda64595117117a [INFO] sha for GitHub repo saebs/ipsniff: 55b09a2703742fe98d17cd212eda64595117117a [INFO] validating manifest of saebs/ipsniff on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saebs/ipsniff on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saebs/ipsniff [INFO] finished frobbing saebs/ipsniff [INFO] frobbed toml for saebs/ipsniff written to work/ex/clippy-test-run/sources/stable/gh/saebs/ipsniff/Cargo.toml [INFO] started frobbing saebs/ipsniff [INFO] finished frobbing saebs/ipsniff [INFO] frobbed toml for saebs/ipsniff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/ipsniff/Cargo.toml [INFO] crate saebs/ipsniff has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saebs/ipsniff against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saebs/ipsniff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae53ed2314c65f04955aae11a8727790d549a3b8539768f0befa824c7091f907 [INFO] running `"docker" "start" "-a" "ae53ed2314c65f04955aae11a8727790d549a3b8539768f0befa824c7091f907"` [INFO] [stderr] Checking ipsniff v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match TcpStream::connect((addr, port)) { [INFO] [stderr] 65 | | Ok(_) => { [INFO] [stderr] 66 | | print!("."); [INFO] [stderr] 67 | | io::stdout().flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 70 | | Err(_) => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let Ok(_) = TcpStream::connect((addr, port)) { [INFO] [stderr] 65 | print!("."); [INFO] [stderr] 66 | io::stdout().flush().unwrap(); [INFO] [stderr] 67 | tx.send(port).unwrap(); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `flag` [INFO] [stderr] --> src/main.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | flag: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match TcpStream::connect((addr, port)) { [INFO] [stderr] 65 | | Ok(_) => { [INFO] [stderr] 66 | | print!("."); [INFO] [stderr] 67 | | io::stdout().flush().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 70 | | Err(_) => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let Ok(_) = TcpStream::connect((addr, port)) { [INFO] [stderr] 65 | print!("."); [INFO] [stderr] 66 | io::stdout().flush().unwrap(); [INFO] [stderr] 67 | tx.send(port).unwrap(); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `"docker" "inspect" "ae53ed2314c65f04955aae11a8727790d549a3b8539768f0befa824c7091f907"` [INFO] running `"docker" "rm" "-f" "ae53ed2314c65f04955aae11a8727790d549a3b8539768f0befa824c7091f907"` [INFO] [stdout] ae53ed2314c65f04955aae11a8727790d549a3b8539768f0befa824c7091f907