[INFO] updating cached repository saebs/cs50rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saebs/cs50rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saebs/cs50rs" "work/ex/clippy-test-run/sources/stable/gh/saebs/cs50rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saebs/cs50rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saebs/cs50rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/cs50rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/cs50rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff76e3b854b629608993a1d78013f4de60e431d8 [INFO] sha for GitHub repo saebs/cs50rs: ff76e3b854b629608993a1d78013f4de60e431d8 [INFO] validating manifest of saebs/cs50rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saebs/cs50rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saebs/cs50rs [INFO] finished frobbing saebs/cs50rs [INFO] frobbed toml for saebs/cs50rs written to work/ex/clippy-test-run/sources/stable/gh/saebs/cs50rs/Cargo.toml [INFO] started frobbing saebs/cs50rs [INFO] finished frobbing saebs/cs50rs [INFO] frobbed toml for saebs/cs50rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saebs/cs50rs/Cargo.toml [INFO] crate saebs/cs50rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saebs/cs50rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/saebs/cs50rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71e5ba96128bd9b88e7efa75e9b15294c3b0254e32aa1aa952e3cfc7fa5a4857 [INFO] running `"docker" "start" "-a" "71e5ba96128bd9b88e7efa75e9b15294c3b0254e32aa1aa952e3cfc7fa5a4857"` [INFO] [stderr] Checking cs50rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/pset1_rust/mario_more.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | print!("{}",' '); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/pset2_crypto/caesar.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/pset1_rust/mario_more.rs:30:25 [INFO] [stderr] | [INFO] [stderr] 30 | print!("{}",' '); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/pset2_crypto/caesar.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/pset2_crypto/crack.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/pset2_crypto/crack.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `gen_word` is never read [INFO] [stderr] --> src/pset2_crypto/crack.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut gen_word = String::new(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `gen_word` is never read [INFO] [stderr] --> src/pset2_crypto/crack.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut gen_word = String::new(); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `crypt` [INFO] [stderr] --> src/pset2_crypto/crack.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | fn crypt<'a>(key: *const u8, salt: *const u8) -> *const u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: foreign function is never used: `crypt` [INFO] [stderr] --> src/pset2_crypto/crack.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | fn crypt<'a>(key: *const u8, salt: *const u8) -> *const u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/pset2_crypto/caesar.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | writeln!(io::stderr(), "Usage:: cs50rs caesar k").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/pset2_crypto/caesar.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | ((pi as i32 + key ) % LETTERS) as u8 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(pi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/pset2_crypto/crack.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | #[repr(C)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/pset2_crypto/caesar.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | writeln!(io::stderr(), "Usage:: cs50rs caesar k").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pset2_crypto/crack.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | gen_word = format!("{}", first ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `first.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/pset2_crypto/caesar.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | ((pi as i32 + key ) % LETTERS) as u8 [INFO] [stderr] | ^^^^^^^^^ help: try: `i32::from(pi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused attribute [INFO] [stderr] --> src/pset2_crypto/crack.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | #[repr(C)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_attributes)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn run(query: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | _ => { writeln!(std::io::stderr(),"Something went wrong Or pset not implemented yet!!").unwrap(); process::exit(1)}, //, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pset2_crypto/crack.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | gen_word = format!("{}", first ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `first.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn run(query: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/lib.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | _ => { writeln!(std::io::stderr(),"Something went wrong Or pset not implemented yet!!").unwrap(); process::exit(1)}, //, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | / writeln!(std::io::stderr(), [INFO] [stderr] 29 | | r##"Usage.. cs50rs "pset name" [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | [Options] [INFO] [stderr] ... | [INFO] [stderr] 37 | | "vigenere" [INFO] [stderr] 38 | | "##).unwrap(); process::exit(1) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:28:14 [INFO] [stderr] | [INFO] [stderr] 28 | / writeln!(std::io::stderr(), [INFO] [stderr] 29 | | r##"Usage.. cs50rs "pset name" [INFO] [stderr] 30 | | [INFO] [stderr] 31 | | [Options] [INFO] [stderr] ... | [INFO] [stderr] 37 | | "vigenere" [INFO] [stderr] 38 | | "##).unwrap(); process::exit(1) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "71e5ba96128bd9b88e7efa75e9b15294c3b0254e32aa1aa952e3cfc7fa5a4857"` [INFO] running `"docker" "rm" "-f" "71e5ba96128bd9b88e7efa75e9b15294c3b0254e32aa1aa952e3cfc7fa5a4857"` [INFO] [stdout] 71e5ba96128bd9b88e7efa75e9b15294c3b0254e32aa1aa952e3cfc7fa5a4857