[INFO] updating cached repository s-panferov/lseq [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/s-panferov/lseq [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/s-panferov/lseq" "work/ex/clippy-test-run/sources/stable/gh/s-panferov/lseq"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/s-panferov/lseq'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/s-panferov/lseq" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-panferov/lseq"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-panferov/lseq'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f6400024b9602f0fa3194b0f7ad358d7f3d0341 [INFO] sha for GitHub repo s-panferov/lseq: 6f6400024b9602f0fa3194b0f7ad358d7f3d0341 [INFO] validating manifest of s-panferov/lseq on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of s-panferov/lseq on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing s-panferov/lseq [INFO] finished frobbing s-panferov/lseq [INFO] frobbed toml for s-panferov/lseq written to work/ex/clippy-test-run/sources/stable/gh/s-panferov/lseq/Cargo.toml [INFO] started frobbing s-panferov/lseq [INFO] finished frobbing s-panferov/lseq [INFO] frobbed toml for s-panferov/lseq written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-panferov/lseq/Cargo.toml [INFO] crate s-panferov/lseq has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting s-panferov/lseq against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/s-panferov/lseq:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 257cd6c08ecb1d527a75f0322246c88e3174cb3841e100db7636878cd4b0aa0a [INFO] running `"docker" "start" "-a" "257cd6c08ecb1d527a75f0322246c88e3174cb3841e100db7636878cd4b0aa0a"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.1 [INFO] [stderr] Compiling rug v1.0.1 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking serde v1.0.36 [INFO] [stderr] Checking quickersort v3.0.1 [INFO] [stderr] Checking skiplist v0.2.10 [INFO] [stderr] Checking conv v0.3.3 [INFO] [stderr] Checking average v0.7.0 [INFO] [stderr] Checking uuid v0.6.2 [INFO] [stderr] Checking lseq v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lseq.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lseq.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | base: base, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `base` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lseq.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return strategy.unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strategy.unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lseq.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lseq.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | let res = match strategy { [INFO] [stderr] | _______________^ [INFO] [stderr] 95 | | LSEQStrategy::AddFromLeft => { [INFO] [stderr] 96 | | let left_n = self.base.normalize(left_v, depth); [INFO] [stderr] 97 | | Ident::new(replica.clone(), left_n + delta) [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ident.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return self_length.cmp(&other_length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self_length.cmp(&other_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lseq.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return strategy.unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `strategy.unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lseq.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lseq.rs:94:15 [INFO] [stderr] | [INFO] [stderr] 94 | let res = match strategy { [INFO] [stderr] | _______________^ [INFO] [stderr] 95 | | LSEQStrategy::AddFromLeft => { [INFO] [stderr] 96 | | let left_n = self.base.normalize(left_v, depth); [INFO] [stderr] 97 | | Ident::new(replica.clone(), left_n + delta) [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ident.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return self_length.cmp(&other_length); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self_length.cmp(&other_length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..(depth + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | digit = digit << (total - digit_len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `digit <<= (total - digit_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | digit = digit >> (digit_len - total) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `digit >>= (digit_len - total)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/base.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..(depth + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `0..=depth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base.rs:73:7 [INFO] [stderr] | [INFO] [stderr] 73 | digit = digit << (total - digit_len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `digit <<= (total - digit_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/base.rs:75:7 [INFO] [stderr] | [INFO] [stderr] 75 | digit = digit >> (digit_len - total) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `digit >>= (digit_len - total)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 15s [INFO] running `"docker" "inspect" "257cd6c08ecb1d527a75f0322246c88e3174cb3841e100db7636878cd4b0aa0a"` [INFO] running `"docker" "rm" "-f" "257cd6c08ecb1d527a75f0322246c88e3174cb3841e100db7636878cd4b0aa0a"` [INFO] [stdout] 257cd6c08ecb1d527a75f0322246c88e3174cb3841e100db7636878cd4b0aa0a