[INFO] updating cached repository s-knibbs/pyvalico [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/s-knibbs/pyvalico [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/s-knibbs/pyvalico" "work/ex/clippy-test-run/sources/stable/gh/s-knibbs/pyvalico"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/s-knibbs/pyvalico'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/s-knibbs/pyvalico" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-knibbs/pyvalico"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-knibbs/pyvalico'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e42da7c2f8bb7a609ddca55b167429ae286fe0d [INFO] sha for GitHub repo s-knibbs/pyvalico: 8e42da7c2f8bb7a609ddca55b167429ae286fe0d [INFO] validating manifest of s-knibbs/pyvalico on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of s-knibbs/pyvalico on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing s-knibbs/pyvalico [INFO] finished frobbing s-knibbs/pyvalico [INFO] frobbed toml for s-knibbs/pyvalico written to work/ex/clippy-test-run/sources/stable/gh/s-knibbs/pyvalico/Cargo.toml [INFO] started frobbing s-knibbs/pyvalico [INFO] finished frobbing s-knibbs/pyvalico [INFO] frobbed toml for s-knibbs/pyvalico written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s-knibbs/pyvalico/Cargo.toml [INFO] crate s-knibbs/pyvalico has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting s-knibbs/pyvalico against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/s-knibbs/pyvalico:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29406f9696891a128fb7b7894e9e5fc5cdb379da02c3c4b2e9acde0954c56ccd [INFO] running `"docker" "start" "-a" "29406f9696891a128fb7b7894e9e5fc5cdb379da02c3c4b2e9acde0954c56ccd"` [INFO] [stderr] Compiling winapi v0.2.8 [INFO] [stderr] Compiling utf8-ranges v0.1.3 [INFO] [stderr] Compiling regex-syntax v0.3.9 [INFO] [stderr] Compiling serde v1.0.77 [INFO] [stderr] Compiling cpython v0.1.0 [INFO] [stderr] Checking traitobject v0.0.3 [INFO] [stderr] Compiling memchr v0.1.11 [INFO] [stderr] Compiling phf_shared v0.7.23 [INFO] [stderr] Compiling aho-corasick v0.5.3 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Compiling thread_local v0.2.7 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling valico v2.1.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Compiling python3-sys v0.1.3 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking jsonway v2.0.0 [INFO] [stderr] Checking cpython-json v0.2.0 [INFO] [stderr] Checking pyvalico v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | py_exception!(valico, ValidationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | fn valico_err_to_string(err: &Box) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&common::error::ValicoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | if validation.errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!validation.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | py_exception!(valico, ValidationError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | fn valico_err_to_string(err: &Box) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&common::error::ValicoError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | if validation.errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!validation.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.29s [INFO] running `"docker" "inspect" "29406f9696891a128fb7b7894e9e5fc5cdb379da02c3c4b2e9acde0954c56ccd"` [INFO] running `"docker" "rm" "-f" "29406f9696891a128fb7b7894e9e5fc5cdb379da02c3c4b2e9acde0954c56ccd"` [INFO] [stdout] 29406f9696891a128fb7b7894e9e5fc5cdb379da02c3c4b2e9acde0954c56ccd