[INFO] updating cached repository ryym/rust-heroku-sample [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ryym/rust-heroku-sample [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ryym/rust-heroku-sample" "work/ex/clippy-test-run/sources/stable/gh/ryym/rust-heroku-sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ryym/rust-heroku-sample'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ryym/rust-heroku-sample" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-heroku-sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-heroku-sample'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e82bb235b26fc3d99651353abbc9e225b42258c9 [INFO] sha for GitHub repo ryym/rust-heroku-sample: e82bb235b26fc3d99651353abbc9e225b42258c9 [INFO] validating manifest of ryym/rust-heroku-sample on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ryym/rust-heroku-sample on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ryym/rust-heroku-sample [INFO] finished frobbing ryym/rust-heroku-sample [INFO] frobbed toml for ryym/rust-heroku-sample written to work/ex/clippy-test-run/sources/stable/gh/ryym/rust-heroku-sample/Cargo.toml [INFO] started frobbing ryym/rust-heroku-sample [INFO] finished frobbing ryym/rust-heroku-sample [INFO] frobbed toml for ryym/rust-heroku-sample written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-heroku-sample/Cargo.toml [INFO] crate ryym/rust-heroku-sample has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ryym/rust-heroku-sample against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ryym/rust-heroku-sample:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e185fa42a0719143ad3c8b5a7d6b028504b489fdf1ae8af5d889ebe358540a6 [INFO] running `"docker" "start" "-a" "3e185fa42a0719143ad3c8b5a7d6b028504b489fdf1ae8af5d889ebe358540a6"` [INFO] [stderr] Compiling serde v1.0.77 [INFO] [stderr] Compiling actix-web v0.7.5 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking http v0.1.12 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking diesel v1.3.2 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.4 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking sample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | let port = env::var("PORT").unwrap_or("8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | let port = env::var("PORT").unwrap_or("8080".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "8080".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 58s [INFO] running `"docker" "inspect" "3e185fa42a0719143ad3c8b5a7d6b028504b489fdf1ae8af5d889ebe358540a6"` [INFO] running `"docker" "rm" "-f" "3e185fa42a0719143ad3c8b5a7d6b028504b489fdf1ae8af5d889ebe358540a6"` [INFO] [stdout] 3e185fa42a0719143ad3c8b5a7d6b028504b489fdf1ae8af5d889ebe358540a6