[INFO] updating cached repository ryym/rust-actix-realworld-example-app [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ryym/rust-actix-realworld-example-app [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ryym/rust-actix-realworld-example-app" "work/ex/clippy-test-run/sources/stable/gh/ryym/rust-actix-realworld-example-app"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ryym/rust-actix-realworld-example-app'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ryym/rust-actix-realworld-example-app" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-actix-realworld-example-app"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-actix-realworld-example-app'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9cdb7dd50842b87de8b46d749d368d019c139b4d [INFO] sha for GitHub repo ryym/rust-actix-realworld-example-app: 9cdb7dd50842b87de8b46d749d368d019c139b4d [INFO] validating manifest of ryym/rust-actix-realworld-example-app on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ryym/rust-actix-realworld-example-app on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ryym/rust-actix-realworld-example-app [INFO] finished frobbing ryym/rust-actix-realworld-example-app [INFO] frobbed toml for ryym/rust-actix-realworld-example-app written to work/ex/clippy-test-run/sources/stable/gh/ryym/rust-actix-realworld-example-app/Cargo.toml [INFO] started frobbing ryym/rust-actix-realworld-example-app [INFO] finished frobbing ryym/rust-actix-realworld-example-app [INFO] frobbed toml for ryym/rust-actix-realworld-example-app written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/rust-actix-realworld-example-app/Cargo.toml [INFO] crate ryym/rust-actix-realworld-example-app has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ryym/rust-actix-realworld-example-app against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ryym/rust-actix-realworld-example-app:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b1a5ef0e84da0adcbdfd25a7b476e319d32799c45a0eb3bbb6cc353db2d7588 [INFO] running `"docker" "start" "-a" "1b1a5ef0e84da0adcbdfd25a7b476e319d32799c45a0eb3bbb6cc353db2d7588"` [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking opaque-debug v0.2.1 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling actix-web v0.7.13 [INFO] [stderr] Checking block-padding v0.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking crossbeam-epoch v0.6.0 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking hmac v0.7.0 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-signal v0.2.5 [INFO] [stderr] Checking pbkdf2 v0.3.0 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0-alpha.5 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.0-alpha.3 [INFO] [stderr] Checking actix v0.7.5 [INFO] [stderr] Checking actix-net v0.1.1 [INFO] [stderr] Checking conduit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/articles.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/articles.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/app/mod.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | scope [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/app/mod.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | let scope = scope.resource("tags", |r| r.get().with(tags::list)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/app/mod.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | scope [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/app/mod.rs:70:25 [INFO] [stderr] | [INFO] [stderr] 70 | let scope = scope.resource("tags", |r| r.get().with(tags::list)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app/articles/build_article_list.rs:51:58 [INFO] [stderr] | [INFO] [stderr] 51 | let tags = tag_lists.remove(&article.id).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/app/articles/build_article_list.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | map.entry(row.0).or_insert(Vec::new()).push(row.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/feed_articles.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let limit = cmp::min(p.limit.unwrap_or(20), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.limit.unwrap_or(20), 500))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/feed_articles.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | let offset = cmp::min(p.offset.unwrap_or(0), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.offset.unwrap_or(0), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app/articles/build_article_list.rs:51:58 [INFO] [stderr] | [INFO] [stderr] 51 | let tags = tag_lists.remove(&article.id).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/list_articles.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let limit = cmp::min(p.limit.unwrap_or(20), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.limit.unwrap_or(20), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/list_articles.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | let offset = cmp::min(p.offset.unwrap_or(0), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.offset.unwrap_or(0), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/app/articles/build_article_list.rs:99:26 [INFO] [stderr] | [INFO] [stderr] 99 | map.entry(row.0).or_insert(Vec::new()).push(row.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app/articles/update_article.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | let tag_list = change.tag_list.unwrap_or(Vec::with_capacity(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/feed_articles.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let limit = cmp::min(p.limit.unwrap_or(20), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.limit.unwrap_or(20), 500))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/feed_articles.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | let offset = cmp::min(p.offset.unwrap_or(0), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.offset.unwrap_or(0), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/list_articles.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let limit = cmp::min(p.limit.unwrap_or(20), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.limit.unwrap_or(20), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/app/articles/list_articles.rs:66:18 [INFO] [stderr] | [INFO] [stderr] 66 | let offset = cmp::min(p.offset.unwrap_or(0), 500) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cmp::min(p.offset.unwrap_or(0), 500))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/app/articles/update_article.rs:41:40 [INFO] [stderr] | [INFO] [stderr] 41 | let tag_list = change.tag_list.unwrap_or(Vec::with_capacity(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(0))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | inner: ctx.map(|k| ErrorKind::Auth(k)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorKind::Auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/jwt.rs:42:54 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode_jwt(&self, token: &String) -> Result>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error.rs:98:28 [INFO] [stderr] | [INFO] [stderr] 98 | inner: ctx.map(|k| ErrorKind::Auth(k)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ErrorKind::Auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/mdl/user.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | pub bio: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/mdl/user.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | pub image: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/jwt.rs:42:54 [INFO] [stderr] | [INFO] [stderr] 42 | fn decode_jwt(&self, token: &String) -> Result>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/mdl/user.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | pub bio: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/mdl/user.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | pub image: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | let port = env::var("PORT").unwrap_or("3000".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | env::var(key).expect(&format!("{} must be set", key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} must be set", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:77:33 [INFO] [stderr] | [INFO] [stderr] 77 | let port = env::var("PORT").unwrap_or("3000".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:91:19 [INFO] [stderr] | [INFO] [stderr] 91 | env::var(key).expect(&format!("{} must be set", key)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} must be set", key))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 52s [INFO] running `"docker" "inspect" "1b1a5ef0e84da0adcbdfd25a7b476e319d32799c45a0eb3bbb6cc353db2d7588"` [INFO] running `"docker" "rm" "-f" "1b1a5ef0e84da0adcbdfd25a7b476e319d32799c45a0eb3bbb6cc353db2d7588"` [INFO] [stdout] 1b1a5ef0e84da0adcbdfd25a7b476e319d32799c45a0eb3bbb6cc353db2d7588