[INFO] updating cached repository ryym/fores
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ryym/fores
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ryym/fores" "work/ex/clippy-test-run/sources/stable/gh/ryym/fores"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ryym/fores'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ryym/fores" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/fores"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/fores'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a87538c4f7fbeba367162f03323787d958d4d306
[INFO] sha for GitHub repo ryym/fores: a87538c4f7fbeba367162f03323787d958d4d306
[INFO] validating manifest of ryym/fores on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ryym/fores on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ryym/fores
[INFO] finished frobbing ryym/fores
[INFO] frobbed toml for ryym/fores written to work/ex/clippy-test-run/sources/stable/gh/ryym/fores/Cargo.toml
[INFO] started frobbing ryym/fores
[INFO] finished frobbing ryym/fores
[INFO] frobbed toml for ryym/fores written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryym/fores/Cargo.toml
[INFO] crate ryym/fores has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ryym/fores against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ryym/fores:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4cf9dbc722d4a34ccf7f330a2ad74b46226ea90e7fcb1d43479fd844acf14c35
[INFO] running `"docker" "start" "-a" "4cf9dbc722d4a34ccf7f330a2ad74b46226ea90e7fcb1d43479fd844acf14c35"`
[INFO] [stderr]    Compiling actix-web v0.7.14
[INFO] [stderr]     Checking signal-hook v0.1.6
[INFO] [stderr]     Checking smallvec v0.6.6
[INFO] [stderr]     Checking crossbeam-epoch v0.6.1
[INFO] [stderr]     Checking bytes v0.4.11
[INFO] [stderr]     Checking ring v0.13.5
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling actix_derive v0.3.2
[INFO] [stderr]     Checking regex v1.0.6
[INFO] [stderr]     Checking crossbeam-deque v0.6.2
[INFO] [stderr]     Checking parking_lot_core v0.3.1
[INFO] [stderr]     Checking tokio-io v0.1.10
[INFO] [stderr]     Checking http v0.1.13
[INFO] [stderr]     Checking tokio-threadpool v0.1.8
[INFO] [stderr]     Checking parking_lot v0.6.4
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking diesel v1.3.3
[INFO] [stderr]     Checking tokio-codec v0.1.1
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking tokio-reactor v0.1.6
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]     Checking tokio-fs v0.1.4
[INFO] [stderr]     Checking tokio-uds v0.2.3
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio-tcp v0.1.2
[INFO] [stderr]     Checking tokio-signal v0.2.6
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking dotenv v0.13.0
[INFO] [stderr]     Checking trust-dns-proto v0.5.0
[INFO] [stderr]     Checking tokio v0.1.11
[INFO] [stderr]     Checking h2 v0.1.13
[INFO] [stderr]     Checking trust-dns-resolver v0.10.0
[INFO] [stderr]     Checking actix v0.7.6
[INFO] [stderr]     Checking actix-net v0.2.2
[INFO] [stderr]     Checking fores v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/svc/files/all_files.rs:27:35
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 let parent_path = id_to_path.get(&parent_id).unwrap();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&id_to_path[&parent_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/svc/files/get.rs:56:31
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 let content = content.unwrap_or(String::new());
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `content.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/svc/tree.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |     path.split("/").filter(|s| s.len() > 0).collect()
[INFO] [stderr]    |                ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/svc/tree.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |     path.split("/").filter(|s| s.len() > 0).collect()
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/svc/tree.rs:16:26
[INFO] [stderr]    |
[INFO] [stderr] 16 |     split_path_opt(path).ok_or(Error::invalid("path is empty"))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::invalid("path is empty"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:40:33
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let port = env::var("PORT").unwrap_or("3000".to_owned());
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |     env::var(key).expect(&format!("{} must be set", key))
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} must be set", key))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/svc/files/all_files.rs:27:35
[INFO] [stderr]    |
[INFO] [stderr] 27 |                 let parent_path = id_to_path.get(&parent_id).unwrap();
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&id_to_path[&parent_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/svc/files/get.rs:56:31
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 let content = content.unwrap_or(String::new());
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `content.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/svc/tree.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 |     path.split("/").filter(|s| s.len() > 0).collect()
[INFO] [stderr]    |                ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/svc/tree.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |     path.split("/").filter(|s| s.len() > 0).collect()
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/svc/tree.rs:16:26
[INFO] [stderr]    |
[INFO] [stderr] 16 |     split_path_opt(path).ok_or(Error::invalid("path is empty"))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::invalid("path is empty"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/lib.rs:40:33
[INFO] [stderr]    |
[INFO] [stderr] 40 |     let port = env::var("PORT").unwrap_or("3000".to_owned());
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "3000".to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/lib.rs:55:19
[INFO] [stderr]    |
[INFO] [stderr] 55 |     env::var(key).expect(&format!("{} must be set", key))
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} must be set", key))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 39s
[INFO] running `"docker" "inspect" "4cf9dbc722d4a34ccf7f330a2ad74b46226ea90e7fcb1d43479fd844acf14c35"`
[INFO] running `"docker" "rm" "-f" "4cf9dbc722d4a34ccf7f330a2ad74b46226ea90e7fcb1d43479fd844acf14c35"`
[INFO] [stdout] 4cf9dbc722d4a34ccf7f330a2ad74b46226ea90e7fcb1d43479fd844acf14c35