[INFO] updating cached repository ryanpbrewster/task-queue [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ryanpbrewster/task-queue [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ryanpbrewster/task-queue" "work/ex/clippy-test-run/sources/stable/gh/ryanpbrewster/task-queue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ryanpbrewster/task-queue'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ryanpbrewster/task-queue" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanpbrewster/task-queue"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanpbrewster/task-queue'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca4b09dd97f1fabaeb4a2c8730961faa283f551a [INFO] sha for GitHub repo ryanpbrewster/task-queue: ca4b09dd97f1fabaeb4a2c8730961faa283f551a [INFO] validating manifest of ryanpbrewster/task-queue on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ryanpbrewster/task-queue on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ryanpbrewster/task-queue [INFO] finished frobbing ryanpbrewster/task-queue [INFO] frobbed toml for ryanpbrewster/task-queue written to work/ex/clippy-test-run/sources/stable/gh/ryanpbrewster/task-queue/Cargo.toml [INFO] started frobbing ryanpbrewster/task-queue [INFO] finished frobbing ryanpbrewster/task-queue [INFO] frobbed toml for ryanpbrewster/task-queue written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanpbrewster/task-queue/Cargo.toml [INFO] crate ryanpbrewster/task-queue has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ryanpbrewster/task-queue against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ryanpbrewster/task-queue:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 33058f48fe5f4938c085b3abe8682970cdc6fb329aed45616f65efe02f8203f7 [INFO] running `"docker" "start" "-a" "33058f48fe5f4938c085b3abe8682970cdc6fb329aed45616f65efe02f8203f7"` [INFO] [stderr] Compiling libsqlite3-sys v0.9.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking rusqlite v0.13.0 [INFO] [stderr] Checking task-queue v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | location [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | let location = { [INFO] [stderr] | ________________________^ [INFO] [stderr] 158 | | let mut path = dir; [INFO] [stderr] 159 | | path.push("tq.sqlite"); [INFO] [stderr] 160 | | path [INFO] [stderr] 161 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | let home = std::env::home_dir().expect("$HOME not defined"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | location [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:157:24 [INFO] [stderr] | [INFO] [stderr] 157 | let location = { [INFO] [stderr] | ________________________^ [INFO] [stderr] 158 | | let mut path = dir; [INFO] [stderr] 159 | | path.push("tq.sqlite"); [INFO] [stderr] 160 | | path [INFO] [stderr] 161 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | let home = std::env::home_dir().expect("$HOME not defined"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `task_id` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | task_id: i64, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `updated_at` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | updated_at: DateTime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `task_id` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | task_id: i64, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `updated_at` [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | updated_at: DateTime, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.77s [INFO] running `"docker" "inspect" "33058f48fe5f4938c085b3abe8682970cdc6fb329aed45616f65efe02f8203f7"` [INFO] running `"docker" "rm" "-f" "33058f48fe5f4938c085b3abe8682970cdc6fb329aed45616f65efe02f8203f7"` [INFO] [stdout] 33058f48fe5f4938c085b3abe8682970cdc6fb329aed45616f65efe02f8203f7