[INFO] updating cached repository ryanc414/msw-rust-club [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ryanc414/msw-rust-club [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ryanc414/msw-rust-club" "work/ex/clippy-test-run/sources/stable/gh/ryanc414/msw-rust-club"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ryanc414/msw-rust-club'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ryanc414/msw-rust-club" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanc414/msw-rust-club"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanc414/msw-rust-club'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a093c98647474e1b9300d2fc942fa3f3cea87e6c [INFO] sha for GitHub repo ryanc414/msw-rust-club: a093c98647474e1b9300d2fc942fa3f3cea87e6c [INFO] validating manifest of ryanc414/msw-rust-club on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ryanc414/msw-rust-club on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ryanc414/msw-rust-club [INFO] finished frobbing ryanc414/msw-rust-club [INFO] frobbed toml for ryanc414/msw-rust-club written to work/ex/clippy-test-run/sources/stable/gh/ryanc414/msw-rust-club/Cargo.toml [INFO] started frobbing ryanc414/msw-rust-club [INFO] finished frobbing ryanc414/msw-rust-club [INFO] frobbed toml for ryanc414/msw-rust-club written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ryanc414/msw-rust-club/Cargo.toml [INFO] crate ryanc414/msw-rust-club has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ryanc414/msw-rust-club against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ryanc414/msw-rust-club:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67c89a86e71261317d742b62d8437edf8ba3e621f4e607aedaf2893119d8f765 [INFO] running `"docker" "start" "-a" "67c89a86e71261317d742b62d8437edf8ba3e621f4e607aedaf2893119d8f765"` [INFO] [stderr] Checking cute v0.3.0 [INFO] [stderr] Checking petals_around_the_rose v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | match s.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `s.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | fn print_dice(dice: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | fn score_dice(dice: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | fn score_die(die: &u16) -> u16 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:29:11 [INFO] [stderr] | [INFO] [stderr] 29 | match s.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `s.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | fn print_dice(dice: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | fn score_dice(dice: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | fn score_die(die: &u16) -> u16 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "67c89a86e71261317d742b62d8437edf8ba3e621f4e607aedaf2893119d8f765"` [INFO] running `"docker" "rm" "-f" "67c89a86e71261317d742b62d8437edf8ba3e621f4e607aedaf2893119d8f765"` [INFO] [stdout] 67c89a86e71261317d742b62d8437edf8ba3e621f4e607aedaf2893119d8f765