[INFO] updating cached repository rwblickhan/RayTracingInOneWeekendRust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rwblickhan/RayTracingInOneWeekendRust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rwblickhan/RayTracingInOneWeekendRust" "work/ex/clippy-test-run/sources/stable/gh/rwblickhan/RayTracingInOneWeekendRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rwblickhan/RayTracingInOneWeekendRust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rwblickhan/RayTracingInOneWeekendRust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rwblickhan/RayTracingInOneWeekendRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rwblickhan/RayTracingInOneWeekendRust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e65274f056246e78650c8f8a060a424fe57f3d86 [INFO] sha for GitHub repo rwblickhan/RayTracingInOneWeekendRust: e65274f056246e78650c8f8a060a424fe57f3d86 [INFO] validating manifest of rwblickhan/RayTracingInOneWeekendRust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rwblickhan/RayTracingInOneWeekendRust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rwblickhan/RayTracingInOneWeekendRust [INFO] finished frobbing rwblickhan/RayTracingInOneWeekendRust [INFO] frobbed toml for rwblickhan/RayTracingInOneWeekendRust written to work/ex/clippy-test-run/sources/stable/gh/rwblickhan/RayTracingInOneWeekendRust/Cargo.toml [INFO] started frobbing rwblickhan/RayTracingInOneWeekendRust [INFO] finished frobbing rwblickhan/RayTracingInOneWeekendRust [INFO] frobbed toml for rwblickhan/RayTracingInOneWeekendRust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rwblickhan/RayTracingInOneWeekendRust/Cargo.toml [INFO] crate rwblickhan/RayTracingInOneWeekendRust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rwblickhan/RayTracingInOneWeekendRust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rwblickhan/RayTracingInOneWeekendRust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a2e33e1b77b5520246b9b23ac355896dc97c7764d9165b73a6597ae9ace3121 [INFO] running `"docker" "start" "-a" "9a2e33e1b77b5520246b9b23ac355896dc97c7764d9165b73a6597ae9ace3121"` [INFO] [stderr] Checking rtracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Some((uv - n.scale_up(dt)).scale_up(ni_over_nt) - n.scale_up(discriminant.sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((uv - n.scale_up(dt)).scale_up(ni_over_nt) - n.scale_up(discriminant.sqrt()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Some((uv - n.scale_up(dt)).scale_up(ni_over_nt) - n.scale_up(discriminant.sqrt())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((uv - n.scale_up(dt)).scale_up(ni_over_nt) - n.scale_up(discriminant.sqrt()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/material.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | attenuation: albedo.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | attenuation: albedo.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:33:34 [INFO] [stderr] | [INFO] [stderr] 33 | attenuation: albedo.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/material.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | attenuation: albedo.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*albedo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if let None = rec.mat { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 20 | | return Vec3::new(0.0, 0.0, 0.0); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________- help: try this: `if rec.mat.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if let None = rec.mat { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 20 | | return Vec3::new(0.0, 0.0, 0.0); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________- help: try this: `if rec.mat.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.08s [INFO] running `"docker" "inspect" "9a2e33e1b77b5520246b9b23ac355896dc97c7764d9165b73a6597ae9ace3121"` [INFO] running `"docker" "rm" "-f" "9a2e33e1b77b5520246b9b23ac355896dc97c7764d9165b73a6597ae9ace3121"` [INFO] [stdout] 9a2e33e1b77b5520246b9b23ac355896dc97c7764d9165b73a6597ae9ace3121