[INFO] updating cached repository ruuda/noblit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ruuda/noblit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ruuda/noblit" "work/ex/clippy-test-run/sources/stable/gh/ruuda/noblit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ruuda/noblit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ruuda/noblit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruuda/noblit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruuda/noblit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8bf09b4731929f13c72fcc75cf8110efc4eaba64 [INFO] sha for GitHub repo ruuda/noblit: 8bf09b4731929f13c72fcc75cf8110efc4eaba64 [INFO] validating manifest of ruuda/noblit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ruuda/noblit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ruuda/noblit [INFO] finished frobbing ruuda/noblit [INFO] frobbed toml for ruuda/noblit written to work/ex/clippy-test-run/sources/stable/gh/ruuda/noblit/Cargo.toml [INFO] started frobbing ruuda/noblit [INFO] finished frobbing ruuda/noblit [INFO] frobbed toml for ruuda/noblit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruuda/noblit/Cargo.toml [INFO] crate ruuda/noblit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ruuda/noblit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ruuda/noblit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b5d30775c9ff204cabb7aa9787d942bc0a6a7e6c0e9415ce07e01a7af060d99 [INFO] running `"docker" "start" "-a" "0b5d30775c9ff204cabb7aa9787d942bc0a6a7e6c0e9415ce07e01a7af060d99"` [INFO] [stderr] Checking noblit v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/htree.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/htree.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | definitions: definitions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | select: select, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `select` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | select_types: select_types, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `select_types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | plan: plan, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:272:13 [INFO] [stderr] | [INFO] [stderr] 272 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datom.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/htree.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/htree.rs:164:25 [INFO] [stderr] | [INFO] [stderr] 164 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | entity: entity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | definitions: definitions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definitions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | select: select, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `select` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | select_types: select_types, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `select_types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | database: database, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `database` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | plan: plan, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `plan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query_plan.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | iters: iters, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `iters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | let value = self [INFO] [stderr] | _____________________^ [INFO] [stderr] 310 | | .lookup_value(entity, self.builtins.attribute_db_attribute_name) [INFO] [stderr] 311 | | .expect("All attributes must have a name."); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/query_plan.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | plan [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/query_plan.rs:244:20 [INFO] [stderr] | [INFO] [stderr] 244 | let plan = QueryPlan { [INFO] [stderr] | ____________________^ [INFO] [stderr] 245 | | definitions: definitions, [INFO] [stderr] 246 | | variable_types: types, [INFO] [stderr] 247 | | variable_names: names, [INFO] [stderr] 248 | | select: select, [INFO] [stderr] 249 | | select_types: select_types, [INFO] [stderr] 250 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:309:21 [INFO] [stderr] | [INFO] [stderr] 309 | let value = self [INFO] [stderr] | _____________________^ [INFO] [stderr] 310 | | .lookup_value(entity, self.builtins.attribute_db_attribute_name) [INFO] [stderr] 311 | | .expect("All attributes must have a name."); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/query_plan.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | plan [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/query_plan.rs:244:20 [INFO] [stderr] | [INFO] [stderr] 244 | let plan = QueryPlan { [INFO] [stderr] | ____________________^ [INFO] [stderr] 245 | | definitions: definitions, [INFO] [stderr] 246 | | variable_types: types, [INFO] [stderr] 247 | | variable_names: names, [INFO] [stderr] 248 | | select: select, [INFO] [stderr] 249 | | select_types: select_types, [INFO] [stderr] 250 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/datom.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match value { [INFO] [stderr] 126 | | false => Value(0), [INFO] [stderr] 127 | | true => Value(1), [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value { Value(1) } else { Value(0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0b10_u64 << 62` [INFO] [stderr] --> src/datom.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | let bits = 0_u64 [INFO] [stderr] | ____________________^ [INFO] [stderr] 140 | | | 0b10_u64 << 62 [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:142:15 [INFO] [stderr] | [INFO] [stderr] 142 | | (bytes[6] as u64) << 48 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:143:15 [INFO] [stderr] | [INFO] [stderr] 143 | | (bytes[5] as u64) << 40 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:144:15 [INFO] [stderr] | [INFO] [stderr] 144 | | (bytes[4] as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:145:15 [INFO] [stderr] | [INFO] [stderr] 145 | | (bytes[3] as u64) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:146:15 [INFO] [stderr] | [INFO] [stderr] 146 | | (bytes[2] as u64) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | | (bytes[1] as u64) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | | (bytes[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/datom.rs:157:40 [INFO] [stderr] | [INFO] [stderr] 157 | let bytes: &[u8; 8] = unsafe { mem::transmute(&self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.0 as *const u64 as *const [u8; 8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:163:19 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn as_eid(&self) -> Eid { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn as_bool(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/htree.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | slice::from_raw_parts(mem::transmute(ptr), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *const U` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/htree.rs:136:11 [INFO] [stderr] | [INFO] [stderr] 136 | while left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/htree.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/query_plan.rs:539:9 [INFO] [stderr] | [INFO] [stderr] 539 | / match self.increment(i) { [INFO] [stderr] 540 | | false => None, [INFO] [stderr] 541 | | true => { [INFO] [stderr] 542 | | let results: Vec = self [INFO] [stderr] ... | [INFO] [stderr] 550 | | } [INFO] [stderr] 551 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 539 | if self.increment(i) { [INFO] [stderr] 540 | let results: Vec = self [INFO] [stderr] 541 | .plan [INFO] [stderr] 542 | .select [INFO] [stderr] 543 | .iter() [INFO] [stderr] 544 | .map(|&v| self.get_value(v)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/datom.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | / match value { [INFO] [stderr] 126 | | false => Value(0), [INFO] [stderr] 127 | | true => Value(1), [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if value { Value(1) } else { Value(0) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0b10_u64 << 62` [INFO] [stderr] --> src/datom.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | let bits = 0_u64 [INFO] [stderr] | ____________________^ [INFO] [stderr] 140 | | | 0b10_u64 << 62 [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:142:15 [INFO] [stderr] | [INFO] [stderr] 142 | | (bytes[6] as u64) << 48 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[6])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:143:15 [INFO] [stderr] | [INFO] [stderr] 143 | | (bytes[5] as u64) << 40 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:144:15 [INFO] [stderr] | [INFO] [stderr] 144 | | (bytes[4] as u64) << 32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:145:15 [INFO] [stderr] | [INFO] [stderr] 145 | | (bytes[3] as u64) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:146:15 [INFO] [stderr] | [INFO] [stderr] 146 | | (bytes[2] as u64) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | | (bytes[1] as u64) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/datom.rs:148:15 [INFO] [stderr] | [INFO] [stderr] 148 | | (bytes[0] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/datom.rs:157:40 [INFO] [stderr] | [INFO] [stderr] 157 | let bytes: &[u8; 8] = unsafe { mem::transmute(&self.0) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.0 as *const u64 as *const [u8; 8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:163:19 [INFO] [stderr] | [INFO] [stderr] 163 | pub fn as_u64(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | pub fn as_eid(&self) -> Eid { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/datom.rs:173:20 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn as_bool(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/htree.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | slice::from_raw_parts(mem::transmute(ptr), len) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *const U` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/htree.rs:136:11 [INFO] [stderr] | [INFO] [stderr] 136 | while left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/htree.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | if left.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/query_plan.rs:539:9 [INFO] [stderr] | [INFO] [stderr] 539 | / match self.increment(i) { [INFO] [stderr] 540 | | false => None, [INFO] [stderr] 541 | | true => { [INFO] [stderr] 542 | | let results: Vec = self [INFO] [stderr] ... | [INFO] [stderr] 550 | | } [INFO] [stderr] 551 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 539 | if self.increment(i) { [INFO] [stderr] 540 | let results: Vec = self [INFO] [stderr] 541 | .plan [INFO] [stderr] 542 | .select [INFO] [stderr] 543 | .iter() [INFO] [stderr] 544 | .map(|&v| self.get_value(v)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.40s [INFO] running `"docker" "inspect" "0b5d30775c9ff204cabb7aa9787d942bc0a6a7e6c0e9415ce07e01a7af060d99"` [INFO] running `"docker" "rm" "-f" "0b5d30775c9ff204cabb7aa9787d942bc0a6a7e6c0e9415ce07e01a7af060d99"` [INFO] [stdout] 0b5d30775c9ff204cabb7aa9787d942bc0a6a7e6c0e9415ce07e01a7af060d99