[INFO] updating cached repository rustybox/devops-build-counter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rustybox/devops-build-counter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rustybox/devops-build-counter" "work/ex/clippy-test-run/sources/stable/gh/rustybox/devops-build-counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustybox/devops-build-counter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rustybox/devops-build-counter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustybox/devops-build-counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustybox/devops-build-counter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9757e2dfc6e149d202e9f4cecccc0cc569ea4e14 [INFO] sha for GitHub repo rustybox/devops-build-counter: 9757e2dfc6e149d202e9f4cecccc0cc569ea4e14 [INFO] validating manifest of rustybox/devops-build-counter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustybox/devops-build-counter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustybox/devops-build-counter [INFO] finished frobbing rustybox/devops-build-counter [INFO] frobbed toml for rustybox/devops-build-counter written to work/ex/clippy-test-run/sources/stable/gh/rustybox/devops-build-counter/Cargo.toml [INFO] started frobbing rustybox/devops-build-counter [INFO] finished frobbing rustybox/devops-build-counter [INFO] frobbed toml for rustybox/devops-build-counter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustybox/devops-build-counter/Cargo.toml [INFO] crate rustybox/devops-build-counter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustybox/devops-build-counter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rustybox/devops-build-counter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c477df149a1cb1f680159e863dfaa47dfb6c69efd58e89b7e27a48bfd217823b [INFO] running `"docker" "start" "-a" "c477df149a1cb1f680159e863dfaa47dfb6c69efd58e89b7e27a48bfd217823b"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking dobc v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return path.to_str().expect("").to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path.to_str().expect("").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | fn init_project_dir(project: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return next.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return text.parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `text.parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match file.write_all(count.to_string().as_bytes()) { [INFO] [stderr] 107 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 108 | | Ok(_) => {} [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(count.to_string().as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return path.to_str().expect("").to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `path.to_str().expect("").to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | fn init_project_dir(project: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return hasher.result_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return next.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `next.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return text.parse().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `text.parse().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match file.write_all(count.to_string().as_bytes()) { [INFO] [stderr] 107 | | Err(why) => panic!("couldn't write to {}: {}", display, why.description()), [INFO] [stderr] 108 | | Ok(_) => {} [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.write_all(count.to_string().as_bytes()) { panic!("couldn't write to {}: {}", display, why.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.57s [INFO] running `"docker" "inspect" "c477df149a1cb1f680159e863dfaa47dfb6c69efd58e89b7e27a48bfd217823b"` [INFO] running `"docker" "rm" "-f" "c477df149a1cb1f680159e863dfaa47dfb6c69efd58e89b7e27a48bfd217823b"` [INFO] [stdout] c477df149a1cb1f680159e863dfaa47dfb6c69efd58e89b7e27a48bfd217823b