[INFO] updating cached repository rustwasm/wasm-pack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rustwasm/wasm-pack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rustwasm/wasm-pack" "work/ex/clippy-test-run/sources/stable/gh/rustwasm/wasm-pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustwasm/wasm-pack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rustwasm/wasm-pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustwasm/wasm-pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustwasm/wasm-pack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51e6351c28fbd40745719e6d4a7bf26dadd30c85 [INFO] sha for GitHub repo rustwasm/wasm-pack: 51e6351c28fbd40745719e6d4a7bf26dadd30c85 [INFO] validating manifest of rustwasm/wasm-pack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustwasm/wasm-pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustwasm/wasm-pack [INFO] finished frobbing rustwasm/wasm-pack [INFO] frobbed toml for rustwasm/wasm-pack written to work/ex/clippy-test-run/sources/stable/gh/rustwasm/wasm-pack/Cargo.toml [INFO] started frobbing rustwasm/wasm-pack [INFO] finished frobbing rustwasm/wasm-pack [INFO] frobbed toml for rustwasm/wasm-pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustwasm/wasm-pack/Cargo.toml [INFO] crate rustwasm/wasm-pack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustwasm/wasm-pack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rustwasm/wasm-pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6749dd9aed324bcbd069ad08f7192cad0117405d49f67aec6873720caad8cd59 [INFO] running `"docker" "start" "-a" "6749dd9aed324bcbd069ad08f7192cad0117405d49f67aec6873720caad8cd59"` [INFO] [stderr] Compiling proc-macro2 v0.4.21 [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Compiling miniz_oxide_c_api v0.2.0 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Checking filetime v0.2.2 [INFO] [stderr] Checking regex-syntax v0.6.3 [INFO] [stderr] Checking miniz_oxide v0.2.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking tar v0.4.18 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking os_type v2.2.0 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking which v2.0.0 [INFO] [stderr] Checking human-panic v1.0.1 [INFO] [stderr] Checking cargo_metadata v0.6.1 [INFO] [stderr] Checking wasm-pack v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/binaries.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return Ok(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/binaries.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/child.rs:171:9 [INFO] [stderr] | [INFO] [stderr] 171 | return Ok(stdout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stdout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/mod.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/mod.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | let status = match command { [INFO] [stderr] | __________________^ [INFO] [stderr] 90 | | Command::Build(build_opts) => { [INFO] [stderr] 91 | | info!(&log, "Running build command..."); [INFO] [stderr] 92 | | Build::try_from_opts(build_opts).and_then(|mut b| b.run(&log)) [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/command/mod.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/command/mod.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | let status = match command { [INFO] [stderr] | __________________^ [INFO] [stderr] 90 | | Command::Build(build_opts) => { [INFO] [stderr] 91 | | info!(&log, "Running build command..."); [INFO] [stderr] 92 | | Build::try_from_opts(build_opts).and_then(|mut b| b.run(&log)) [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/logger.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | Command::Publish { path, access: _ } => path, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Publish { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/logger.rs:41:34 [INFO] [stderr] | [INFO] [stderr] 41 | Command::Publish { path, access: _ } => path, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Publish { path, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manifest/mod.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return err; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manifest/mod.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | return err; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm.rs:10:34 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_NPM_REGISTRY: &'static str = "https://registry.npmjs.org/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/npm.rs:10:34 [INFO] [stderr] | [INFO] [stderr] 10 | pub const DEFAULT_NPM_REGISTRY: &'static str = "https://registry.npmjs.org/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `result` [INFO] [stderr] --> src/binaries.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | (result >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/binaries.rs:130:49 [INFO] [stderr] | [INFO] [stderr] 130 | let mut binaries: HashSet<_> = binaries.into_iter().map(ffi::OsStr::new).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/binaries.rs:162:49 [INFO] [stderr] | [INFO] [stderr] 162 | let mut binaries: HashSet<_> = binaries.into_iter().map(ffi::OsStr::new).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bindgen.rs:143:1 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn wasm_bindgen_build( [INFO] [stderr] 144 | | data: &CrateData, [INFO] [stderr] 145 | | bindgen: &Download, [INFO] [stderr] 146 | | out_dir: &Path, [INFO] [stderr] ... | [INFO] [stderr] 200 | | Ok(()) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/child.rs:89:45 [INFO] [stderr] | [INFO] [stderr] 89 | let next_in_progress: Vec = self.in_progress[last_newline + 1..] [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 90 | | .iter() [INFO] [stderr] 91 | | .cloned() [INFO] [stderr] 92 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/build.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | self.out_dir.canonicalize().unwrap_or(self.out_dir.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.out_dir.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/build.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | fn get_process_steps(mode: &BuildMode) -> Vec<(&'static str, BuildStep)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BuildMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/login.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | let registry = registry.unwrap_or(npm::DEFAULT_NPM_REGISTRY.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| npm::DEFAULT_NPM_REGISTRY.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/login.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | PBAR.message(&format!("👋 logged you in!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"👋 logged you in!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/utils.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(path.unwrap_or(PathBuf::from("."))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/npm.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | .arg(&format!("{}", a.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `a.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/npm.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | registry: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/npm.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | if always_auth == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `always_auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progressbar::ProgressOutput` [INFO] [stderr] --> src/progressbar.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | spinner: RwLock::new(ProgressBar::new_spinner()), [INFO] [stderr] 20 | | messages: RwLock::new(String::from("")), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for progressbar::ProgressOutput { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/readme.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(_) = fs::copy(&crate_readme_path, &new_readme_path) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 27 | | PBAR.warn("origin crate has no README"); [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____- help: try this: `if fs::copy(&crate_readme_path, &new_readme_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `result` [INFO] [stderr] --> src/binaries.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | (result >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/binaries.rs:130:49 [INFO] [stderr] | [INFO] [stderr] 130 | let mut binaries: HashSet<_> = binaries.into_iter().map(ffi::OsStr::new).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/binaries.rs:162:49 [INFO] [stderr] | [INFO] [stderr] 162 | let mut binaries: HashSet<_> = binaries.into_iter().map(ffi::OsStr::new).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/bindgen.rs:143:1 [INFO] [stderr] | [INFO] [stderr] 143 | / pub fn wasm_bindgen_build( [INFO] [stderr] 144 | | data: &CrateData, [INFO] [stderr] 145 | | bindgen: &Download, [INFO] [stderr] 146 | | out_dir: &Path, [INFO] [stderr] ... | [INFO] [stderr] 200 | | Ok(()) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/child.rs:89:45 [INFO] [stderr] | [INFO] [stderr] 89 | let next_in_progress: Vec = self.in_progress[last_newline + 1..] [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 90 | | .iter() [INFO] [stderr] 91 | | .cloned() [INFO] [stderr] 92 | | .collect(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/build.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | self.out_dir.canonicalize().unwrap_or(self.out_dir.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| self.out_dir.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/command/build.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | fn get_process_steps(mode: &BuildMode) -> Vec<(&'static str, BuildStep)> { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `BuildMode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/login.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | let registry = registry.unwrap_or(npm::DEFAULT_NPM_REGISTRY.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| npm::DEFAULT_NPM_REGISTRY.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/command/login.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | PBAR.message(&format!("👋 logged you in!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"👋 logged you in!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/command/utils.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(path.unwrap_or(PathBuf::from("."))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/npm.rs:27:19 [INFO] [stderr] | [INFO] [stderr] 27 | .arg(&format!("{}", a.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `a.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/npm.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | registry: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/npm.rs:57:8 [INFO] [stderr] | [INFO] [stderr] 57 | if always_auth == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `always_auth` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `progressbar::ProgressOutput` [INFO] [stderr] --> src/progressbar.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | spinner: RwLock::new(ProgressBar::new_spinner()), [INFO] [stderr] 20 | | messages: RwLock::new(String::from("")), [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | impl Default for progressbar::ProgressOutput { [INFO] [stderr] 16 | fn default() -> Self { [INFO] [stderr] 17 | Self::new() [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/readme.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(_) = fs::copy(&crate_readme_path, &new_readme_path) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 27 | | PBAR.warn("origin crate has no README"); [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_____- help: try this: `if fs::copy(&crate_readme_path, &new_readme_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'y'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'Y'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:25 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'y'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/installer.rs:117:50 [INFO] [stderr] | [INFO] [stderr] 117 | if line.starts_with("y") || line.starts_with("Y") { [INFO] [stderr] | ^^^ help: try using a char instead: `'Y'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.85s [INFO] running `"docker" "inspect" "6749dd9aed324bcbd069ad08f7192cad0117405d49f67aec6873720caad8cd59"` [INFO] running `"docker" "rm" "-f" "6749dd9aed324bcbd069ad08f7192cad0117405d49f67aec6873720caad8cd59"` [INFO] [stdout] 6749dd9aed324bcbd069ad08f7192cad0117405d49f67aec6873720caad8cd59