[INFO] updating cached repository rustodo/rustodo
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rustodo/rustodo
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rustodo/rustodo" "work/ex/clippy-test-run/sources/stable/gh/rustodo/rustodo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustodo/rustodo'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rustodo/rustodo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustodo/rustodo"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustodo/rustodo'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2e0197b401d442a091024137245f36d7fbbcd232
[INFO] sha for GitHub repo rustodo/rustodo: 2e0197b401d442a091024137245f36d7fbbcd232
[INFO] validating manifest of rustodo/rustodo on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rustodo/rustodo on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rustodo/rustodo
[INFO] finished frobbing rustodo/rustodo
[INFO] frobbed toml for rustodo/rustodo written to work/ex/clippy-test-run/sources/stable/gh/rustodo/rustodo/Cargo.toml
[INFO] started frobbing rustodo/rustodo
[INFO] finished frobbing rustodo/rustodo
[INFO] frobbed toml for rustodo/rustodo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustodo/rustodo/Cargo.toml
[INFO] crate rustodo/rustodo has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting rustodo/rustodo against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rustodo/rustodo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d73ae09958db3d6017afde5e100f6ef5273d966736620870008e830235b3f345
[INFO] running `"docker" "start" "-a" "d73ae09958db3d6017afde5e100f6ef5273d966736620870008e830235b3f345"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking rustodo v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:114:14
[INFO] [stderr]     |
[INFO] [stderr] 114 |             .or(NormalTextParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| NormalTextParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:113:14
[INFO] [stderr]     |
[INFO] [stderr] 113 |             .or(KeyValueParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| KeyValueParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:112:14
[INFO] [stderr]     |
[INFO] [stderr] 112 |             .or(ContextParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ContextParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/description_component.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         match self {
[INFO] [stderr] 142 | |             &DescriptionComponent::Text(ref text) => write!(formatter, "{}", text),
[INFO] [stderr] 143 | |             &DescriptionComponent::Project(ref project) => write!(formatter, "+{}", project),
[INFO] [stderr] 144 | |             &DescriptionComponent::Context(ref context) => write!(formatter, "@{}", context),
[INFO] [stderr] 145 | |             &DescriptionComponent::KeyValue(ref key, ref value) => write!(formatter, "{}:{}", key, value)
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 141 |         match *self {
[INFO] [stderr] 142 |             DescriptionComponent::Text(ref text) => write!(formatter, "{}", text),
[INFO] [stderr] 143 |             DescriptionComponent::Project(ref project) => write!(formatter, "+{}", project),
[INFO] [stderr] 144 |             DescriptionComponent::Context(ref context) => write!(formatter, "@{}", context),
[INFO] [stderr] 145 |             DescriptionComponent::KeyValue(ref key, ref value) => write!(formatter, "{}:{}", key, value)
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/description_component.rs:150:53
[INFO] [stderr]     |
[INFO] [stderr] 150 | pub fn description_components_to_string(components: &Vec<DescriptionComponent>) -> String {
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DescriptionComponent]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:114:14
[INFO] [stderr]     |
[INFO] [stderr] 114 |             .or(NormalTextParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| NormalTextParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:113:14
[INFO] [stderr]     |
[INFO] [stderr] 113 |             .or(KeyValueParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| KeyValueParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/description_component.rs:112:14
[INFO] [stderr]     |
[INFO] [stderr] 112 |             .or(ContextParser::parse(input))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ContextParser::parse(input))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/description_component.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         match self {
[INFO] [stderr] 142 | |             &DescriptionComponent::Text(ref text) => write!(formatter, "{}", text),
[INFO] [stderr] 143 | |             &DescriptionComponent::Project(ref project) => write!(formatter, "+{}", project),
[INFO] [stderr] 144 | |             &DescriptionComponent::Context(ref context) => write!(formatter, "@{}", context),
[INFO] [stderr] 145 | |             &DescriptionComponent::KeyValue(ref key, ref value) => write!(formatter, "{}:{}", key, value)
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 141 |         match *self {
[INFO] [stderr] 142 |             DescriptionComponent::Text(ref text) => write!(formatter, "{}", text),
[INFO] [stderr] 143 |             DescriptionComponent::Project(ref project) => write!(formatter, "+{}", project),
[INFO] [stderr] 144 |             DescriptionComponent::Context(ref context) => write!(formatter, "@{}", context),
[INFO] [stderr] 145 |             DescriptionComponent::KeyValue(ref key, ref value) => write!(formatter, "{}:{}", key, value)
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/description_component.rs:150:53
[INFO] [stderr]     |
[INFO] [stderr] 150 | pub fn description_components_to_string(components: &Vec<DescriptionComponent>) -> String {
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DescriptionComponent]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.88s
[INFO] running `"docker" "inspect" "d73ae09958db3d6017afde5e100f6ef5273d966736620870008e830235b3f345"`
[INFO] running `"docker" "rm" "-f" "d73ae09958db3d6017afde5e100f6ef5273d966736620870008e830235b3f345"`
[INFO] [stdout] d73ae09958db3d6017afde5e100f6ef5273d966736620870008e830235b3f345