[INFO] updating cached repository rustindia/mpw-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rustindia/mpw-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rustindia/mpw-rs" "work/ex/clippy-test-run/sources/stable/gh/rustindia/mpw-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustindia/mpw-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rustindia/mpw-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustindia/mpw-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustindia/mpw-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a209356347506a129209a24ae6dcf8eefba89043 [INFO] sha for GitHub repo rustindia/mpw-rs: a209356347506a129209a24ae6dcf8eefba89043 [INFO] validating manifest of rustindia/mpw-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustindia/mpw-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustindia/mpw-rs [INFO] finished frobbing rustindia/mpw-rs [INFO] frobbed toml for rustindia/mpw-rs written to work/ex/clippy-test-run/sources/stable/gh/rustindia/mpw-rs/Cargo.toml [INFO] started frobbing rustindia/mpw-rs [INFO] finished frobbing rustindia/mpw-rs [INFO] frobbed toml for rustindia/mpw-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustindia/mpw-rs/Cargo.toml [INFO] crate rustindia/mpw-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustindia/mpw-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rustindia/mpw-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4de7f45756886e6e15d1d420ecbb98000fedadbc64e890a3afddf3153a82b3e5 [INFO] running `"docker" "start" "-a" "4de7f45756886e6e15d1d420ecbb98000fedadbc64e890a3afddf3153a82b3e5"` [INFO] [stderr] Compiling scopeguard v0.3.2 [INFO] [stderr] Compiling libc v0.2.31 [INFO] [stderr] Compiling futures v0.1.16 [INFO] [stderr] Compiling lazy_static v0.2.8 [INFO] [stderr] Checking data-encoding v1.2.0 [INFO] [stderr] Checking rprompt v1.0.3 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking blake2-rfc v0.2.17 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking base64 v0.7.0 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking rpassword v1.0.2 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking argon2rs v0.2.5 [INFO] [stderr] Compiling num_cpus v1.6.2 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Compiling ring v0.11.0 [INFO] [stderr] Checking bcrypt v0.1.4 [INFO] [stderr] Checking ring-pwhash v0.11.0 [INFO] [stderr] Checking mpw-rs v2.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | "hmac-sha-256"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | println!("### Performing {} iterations of {}:", iterations, "bcrypt9"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | "scrypt_mpw"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:84:65 [INFO] [stderr] | [INFO] [stderr] 84 | println!("### Performing {} iterations of {}:", iterations, "mpw"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | "hmac-sha-256"); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | println!("### Performing {} iterations of {}:", iterations, "bcrypt9"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:76:14 [INFO] [stderr] | [INFO] [stderr] 76 | "scrypt_mpw"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/benchmark/mod.rs:84:65 [INFO] [stderr] | [INFO] [stderr] 84 | println!("### Performing {} iterations of {}:", iterations, "mpw"); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common/mod.rs:159:34 [INFO] [stderr] | [INFO] [stderr] 159 | let inst = Argon2::new(1, 4, 131072, Variant::Argon2i); [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/benchmark/mod.rs:30:81 [INFO] [stderr] | [INFO] [stderr] 30 | let seconds = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/common/mod.rs:159:34 [INFO] [stderr] | [INFO] [stderr] 159 | let inst = Argon2::new(1, 4, 131072, Variant::Argon2i); [INFO] [stderr] | ^^^^^^ help: consider: `131_072` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/benchmark/mod.rs:30:81 [INFO] [stderr] | [INFO] [stderr] 30 | let seconds = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/mpw_v3.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | site_counter: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/core/mpw_v3.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | .zip(1..template_bytes.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=template_bytes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/mod.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | site_counter: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:80:59 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn template_for_type(site_type: &SiteType, seed_byte: &u8) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/benchmark/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let seconds = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/benchmark/mod.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let speed = iterations as f64 / seconds; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/mpw_v3.rs:47:40 [INFO] [stderr] | [INFO] [stderr] 47 | site_counter: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/benchmark/mod.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | "".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/core/mpw_v3.rs:76:22 [INFO] [stderr] | [INFO] [stderr] 76 | .zip(1..template_bytes.len() + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=template_bytes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/mod.rs:39:40 [INFO] [stderr] | [INFO] [stderr] 39 | site_counter: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/common/mod.rs:80:59 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn template_for_type(site_type: &SiteType, seed_byte: &u8) -> Option { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/benchmark/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let seconds = (elapsed.as_secs() as f64) + (elapsed.subsec_nanos() as f64 / 1000_000_000.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/benchmark/mod.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | let speed = iterations as f64 / seconds; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/benchmark/mod.rs:60:20 [INFO] [stderr] | [INFO] [stderr] 60 | "".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.70s [INFO] running `"docker" "inspect" "4de7f45756886e6e15d1d420ecbb98000fedadbc64e890a3afddf3153a82b3e5"` [INFO] running `"docker" "rm" "-f" "4de7f45756886e6e15d1d420ecbb98000fedadbc64e890a3afddf3153a82b3e5"` [INFO] [stdout] 4de7f45756886e6e15d1d420ecbb98000fedadbc64e890a3afddf3153a82b3e5