[INFO] updating cached repository rustation/cargo-test-junit
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rustation/cargo-test-junit
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rustation/cargo-test-junit" "work/ex/clippy-test-run/sources/stable/gh/rustation/cargo-test-junit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustation/cargo-test-junit'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rustation/cargo-test-junit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustation/cargo-test-junit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustation/cargo-test-junit'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9baa6b8f94f8a0d2c1357acd1411d0ee300a68c9
[INFO] sha for GitHub repo rustation/cargo-test-junit: 9baa6b8f94f8a0d2c1357acd1411d0ee300a68c9
[INFO] validating manifest of rustation/cargo-test-junit on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rustation/cargo-test-junit on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rustation/cargo-test-junit
[INFO] finished frobbing rustation/cargo-test-junit
[INFO] frobbed toml for rustation/cargo-test-junit written to work/ex/clippy-test-run/sources/stable/gh/rustation/cargo-test-junit/Cargo.toml
[INFO] started frobbing rustation/cargo-test-junit
[INFO] finished frobbing rustation/cargo-test-junit
[INFO] frobbed toml for rustation/cargo-test-junit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustation/cargo-test-junit/Cargo.toml
[INFO] crate rustation/cargo-test-junit has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rustation/cargo-test-junit against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rustation/cargo-test-junit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2576a3276503992b877e3f590f6210ba0bf78537e691cb179d8432151ec3733e
[INFO] running `"docker" "start" "-a" "2576a3276503992b877e3f590f6210ba0bf78537e691cb179d8432151ec3733e"`
[INFO] [stderr]     Checking peresil v0.3.0
[INFO] [stderr]     Checking unicode-segmentation v0.1.3
[INFO] [stderr]     Checking typed-arena v1.2.0
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking duct v0.4.0
[INFO] [stderr]     Checking nom v3.2.1
[INFO] [stderr]     Checking sxd-document v0.2.0
[INFO] [stderr]     Checking clap v2.19.2
[INFO] [stderr]     Checking test-to-vec v0.4.3
[INFO] [stderr]     Checking cargo-test-junit v0.6.7 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/args.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         .ok_or(io::Error::new(io::ErrorKind::NotFound, "Name arg not provided"))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Name arg not provided"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/args.rs:43:10
[INFO] [stderr]    |
[INFO] [stderr] 43 |         .ok_or(io::Error::new(io::ErrorKind::NotFound, "Could not parse current dir"))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Could not parse current dir"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref matches = args::get_args();
[INFO] [stderr]    |     ----^^^^^^^^^^^-------------------- help: try: `let matches = &args::get_args();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:24:10
[INFO] [stderr]    |
[INFO] [stderr] 24 |         .unwrap_or("".to_string());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let ref name = args::get_file_name(matches).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^----------------------------------------- help: try: `let name = &args::get_file_name(matches).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:80:47
[INFO] [stderr]    |
[INFO] [stderr] 80 |         fs::File::create(format!("{}", name)).expect(&format!("could not create file: {}", name));
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not create file: {}", name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:80:26
[INFO] [stderr]    |
[INFO] [stderr] 80 |         fs::File::create(format!("{}", name)).expect(&format!("could not create file: {}", name));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 | /     format_document(&d, &mut f)
[INFO] [stderr] 83 | |         .ok()
[INFO] [stderr] 84 | |         .expect(&format!("unable to output XML to {}", name));
[INFO] [stderr]    | |_____________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:10
[INFO] [stderr]    |
[INFO] [stderr] 84 |         .expect(&format!("unable to output XML to {}", name));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("unable to output XML to {}", name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/args.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         .ok_or(io::Error::new(io::ErrorKind::NotFound, "Name arg not provided"))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Name arg not provided"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/args.rs:43:10
[INFO] [stderr]    |
[INFO] [stderr] 43 |         .ok_or(io::Error::new(io::ErrorKind::NotFound, "Could not parse current dir"))
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "Could not parse current dir"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref matches = args::get_args();
[INFO] [stderr]    |     ----^^^^^^^^^^^-------------------- help: try: `let matches = &args::get_args();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:24:10
[INFO] [stderr]    |
[INFO] [stderr] 24 |         .unwrap_or("".to_string());
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let ref name = args::get_file_name(matches).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^----------------------------------------- help: try: `let name = &args::get_file_name(matches).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:80:47
[INFO] [stderr]    |
[INFO] [stderr] 80 |         fs::File::create(format!("{}", name)).expect(&format!("could not create file: {}", name));
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("could not create file: {}", name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:80:26
[INFO] [stderr]    |
[INFO] [stderr] 80 |         fs::File::create(format!("{}", name)).expect(&format!("could not create file: {}", name));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:82:5
[INFO] [stderr]    |
[INFO] [stderr] 82 | /     format_document(&d, &mut f)
[INFO] [stderr] 83 | |         .ok()
[INFO] [stderr] 84 | |         .expect(&format!("unable to output XML to {}", name));
[INFO] [stderr]    | |_____________________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:10
[INFO] [stderr]    |
[INFO] [stderr] 84 |         .expect(&format!("unable to output XML to {}", name));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("unable to output XML to {}", name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.24s
[INFO] running `"docker" "inspect" "2576a3276503992b877e3f590f6210ba0bf78537e691cb179d8432151ec3733e"`
[INFO] running `"docker" "rm" "-f" "2576a3276503992b877e3f590f6210ba0bf78537e691cb179d8432151ec3733e"`
[INFO] [stdout] 2576a3276503992b877e3f590f6210ba0bf78537e691cb179d8432151ec3733e