[INFO] updating cached repository rust-tic-tac-toe/tic-tac-toe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-tic-tac-toe/tic-tac-toe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-tic-tac-toe/tic-tac-toe" "work/ex/clippy-test-run/sources/stable/gh/rust-tic-tac-toe/tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-tic-tac-toe/tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-tic-tac-toe/tic-tac-toe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-tic-tac-toe/tic-tac-toe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-tic-tac-toe/tic-tac-toe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3158d5cf39509f31ba4f1264b266031ccc6eefe8 [INFO] sha for GitHub repo rust-tic-tac-toe/tic-tac-toe: 3158d5cf39509f31ba4f1264b266031ccc6eefe8 [INFO] validating manifest of rust-tic-tac-toe/tic-tac-toe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-tic-tac-toe/tic-tac-toe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-tic-tac-toe/tic-tac-toe [INFO] finished frobbing rust-tic-tac-toe/tic-tac-toe [INFO] frobbed toml for rust-tic-tac-toe/tic-tac-toe written to work/ex/clippy-test-run/sources/stable/gh/rust-tic-tac-toe/tic-tac-toe/Cargo.toml [INFO] started frobbing rust-tic-tac-toe/tic-tac-toe [INFO] finished frobbing rust-tic-tac-toe/tic-tac-toe [INFO] frobbed toml for rust-tic-tac-toe/tic-tac-toe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-tic-tac-toe/tic-tac-toe/Cargo.toml [INFO] crate rust-tic-tac-toe/tic-tac-toe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-tic-tac-toe/tic-tac-toe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-tic-tac-toe/tic-tac-toe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5f1555c3250ef838fc0595089b849eb0cf6cdc6663306fc59b91c94831c869f [INFO] running `"docker" "start" "-a" "f5f1555c3250ef838fc0595089b849eb0cf6cdc6663306fc59b91c94831c869f"` [INFO] [stderr] Compiling cc v1.0.1 [INFO] [stderr] Compiling libc v0.2.32 [INFO] [stderr] Compiling pulldown-cmark v0.1.0 [INFO] [stderr] Compiling serde v1.0.15 [INFO] [stderr] Compiling getopts v0.2.15 [INFO] [stderr] Checking environment v0.1.1 [INFO] [stderr] Checking difference v1.0.0 [INFO] [stderr] Checking assert_ne v0.3.0 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking colored v1.5.3 [INFO] [stderr] Checking tic_tac_toe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling rand v0.3.17 [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:31:36 [INFO] [stderr] | [INFO] [stderr] 31 | fn is_move_valid(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn is_space_available(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:39:41 [INFO] [stderr] | [INFO] [stderr] 39 | fn is_space_in_bounds(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/board.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | space >= &min_space && space < &max_space [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `min_space` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/board.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | space >= &min_space && space < &max_space [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `max_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Compiling backtrace-sys v0.1.15 [INFO] [stderr] Compiling tempdir v0.3.5 [INFO] [stderr] Compiling toml v0.4.5 [INFO] [stderr] Compiling serde_json v1.0.3 [INFO] [stderr] Compiling backtrace v0.3.3 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling skeptic v0.13.0 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/board_printer.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | format_row(&vec!["1".to_string(), "2".to_string(), "3".to_string()]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["1".to_string(), "2".to_string(), "3".to_string()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/board_printer.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | number_spaces(&vec![ [INFO] [stderr] | ___________________________^ [INFO] [stderr] 103 | | " ".to_string(), [INFO] [stderr] 104 | | " ".to_string(), [INFO] [stderr] 105 | | " ".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 111 | | " ".to_string(), [INFO] [stderr] 112 | | ]) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 102 | number_spaces(&[" ".to_string(), [INFO] [stderr] 103 | " ".to_string(), [INFO] [stderr] 104 | " ".to_string(), [INFO] [stderr] 105 | " ".to_string(), [INFO] [stderr] 106 | " ".to_string(), [INFO] [stderr] 107 | " ".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:31:36 [INFO] [stderr] | [INFO] [stderr] 31 | fn is_move_valid(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:35:45 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn is_space_available(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/board.rs:39:41 [INFO] [stderr] | [INFO] [stderr] 39 | fn is_space_in_bounds(&self, space: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/board.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | space >= &min_space && space < &max_space [INFO] [stderr] | ^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `min_space` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/board.rs:42:32 [INFO] [stderr] | [INFO] [stderr] 42 | space >= &min_space && space < &max_space [INFO] [stderr] | ^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `max_space` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.00s [INFO] running `"docker" "inspect" "f5f1555c3250ef838fc0595089b849eb0cf6cdc6663306fc59b91c94831c869f"` [INFO] running `"docker" "rm" "-f" "f5f1555c3250ef838fc0595089b849eb0cf6cdc6663306fc59b91c94831c869f"` [INFO] [stdout] f5f1555c3250ef838fc0595089b849eb0cf6cdc6663306fc59b91c94831c869f