[INFO] updating cached repository rust-osdev/bootimage
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rust-osdev/bootimage
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rust-osdev/bootimage" "work/ex/clippy-test-run/sources/stable/gh/rust-osdev/bootimage"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-osdev/bootimage'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rust-osdev/bootimage" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-osdev/bootimage"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-osdev/bootimage'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e08a6293f8bc1273bff9fe42a7b2c42310894228
[INFO] sha for GitHub repo rust-osdev/bootimage: e08a6293f8bc1273bff9fe42a7b2c42310894228
[INFO] validating manifest of rust-osdev/bootimage on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rust-osdev/bootimage on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rust-osdev/bootimage
[INFO] finished frobbing rust-osdev/bootimage
[INFO] frobbed toml for rust-osdev/bootimage written to work/ex/clippy-test-run/sources/stable/gh/rust-osdev/bootimage/Cargo.toml
[INFO] started frobbing rust-osdev/bootimage
[INFO] finished frobbing rust-osdev/bootimage
[INFO] frobbed toml for rust-osdev/bootimage written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-osdev/bootimage/Cargo.toml
[INFO] crate rust-osdev/bootimage has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rust-osdev/bootimage against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-osdev/bootimage:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 694cb8e53bdb2183498eaacbdee2c1d4a6c45e9f3be76bdae8a889518b76e708
[INFO] running `"docker" "start" "-a" "694cb8e53bdb2183498eaacbdee2c1d4a6c45e9f3be76bdae8a889518b76e708"`
[INFO] [stderr]    Compiling serde v1.0.70
[INFO] [stderr]     Checking error-chain v0.11.0
[INFO] [stderr]     Checking zero v0.1.2
[INFO] [stderr]    Compiling proc-macro2 v0.4.8
[INFO] [stderr]     Checking wait-timeout v0.1.5
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking xmas-elf v0.6.2
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]    Compiling quote v0.6.3
[INFO] [stderr]    Compiling syn v0.14.4
[INFO] [stderr]     Checking rayon v1.0.3
[INFO] [stderr]    Compiling serde_derive v1.0.70
[INFO] [stderr]     Checking serde_json v1.0.24
[INFO] [stderr]     Checking semver v0.9.0
[INFO] [stderr]     Checking toml v0.4.6
[INFO] [stderr]     Checking cargo_metadata v0.5.8
[INFO] [stderr]     Checking bootimage v0.5.7 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/test.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/test.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     println!("");
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/test.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/test.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     println!("");
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/args.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let mut arg_iter = args.into_iter();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/build.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         if let &Some(ref target) = args.target() {
[INFO] [stderr] 36 | |             out_dir.push(Path::new(target).file_stem().unwrap().to_str().unwrap());
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if let Some(ref target) = *args.target() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/build.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     if let &Some(ref target) = args.target() {
[INFO] [stderr] 64 | |         if !target.ends_with(".json") {
[INFO] [stderr] 65 | |             use std::io::{self, Write};
[INFO] [stderr] 66 | |             use std::process;
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 63 |     if let Some(ref target) = *args.target() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> src/build.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 | /             writeln!(
[INFO] [stderr] 69 | |                 io::stderr(),
[INFO] [stderr] 70 | |                 "Please pass a path to `--target` (with `.json` extension`): `--target {}.json`",
[INFO] [stderr] 71 | |                 target
[INFO] [stderr] 72 | |             ).unwrap();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/build.rs:336:1
[INFO] [stderr]     |
[INFO] [stderr] 336 | / fn create_disk_image(
[INFO] [stderr] 337 | |     root_dir: &Path,
[INFO] [stderr] 338 | |     out_dir: &Path,
[INFO] [stderr] 339 | |     bin_name: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 423 | |     Ok(output_path)
[INFO] [stderr] 424 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/build.rs:362:18
[INFO] [stderr]     |
[INFO] [stderr] 362 |                 .unwrap_or(output_path.as_path())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| output_path.as_path())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:48:47
[INFO] [stderr]    |
[INFO] [stderr] 48 |           Some(metadata) => metadata.as_table().ok_or(format_err!(
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 49 | |             "Bootimage configuration invalid: {:?}",
[INFO] [stderr] 50 | |             metadata
[INFO] [stderr] 51 | |         ))?,
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Some(metadata) => metadata.as_table().ok_or_else(|| format_err!(
[INFO] [stderr] 49 |             "Bootimage configuration invalid: {:?}",
[INFO] [stderr] 50 |             metadata
[INFO] [stderr] 51 |         ))?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/config.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 |           .and_then(|table| {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 62 | |             table
[INFO] [stderr] 63 | |                 .get("features")
[INFO] [stderr] 64 | |                 .or_else(|| table.get("default-features"))
[INFO] [stderr] 65 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:212:43
[INFO] [stderr]     |
[INFO] [stderr] 212 |               run_command: self.run_command.unwrap_or(vec![
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 213 | |                 "qemu-system-x86_64".into(),
[INFO] [stderr] 214 | |                 "-drive".into(),
[INFO] [stderr] 215 | |                 "format=raw,file={}".into(),
[INFO] [stderr] 216 | |             ]),
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 212 |             run_command: self.run_command.unwrap_or_else(|| vec![
[INFO] [stderr] 213 |                 "qemu-system-x86_64".into(),
[INFO] [stderr] 214 |                 "-drive".into(),
[INFO] [stderr] 215 |                 "format=raw,file={}".into(),
[INFO] [stderr] 216 |             ]),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:228:18
[INFO] [stderr]     |
[INFO] [stderr] 228 |                 .unwrap_or(PathBuf::from("x86_64-bootloader.json")),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("x86_64-bootloader.json"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:229:37
[INFO] [stderr]     |
[INFO] [stderr] 229 |             features: self.features.unwrap_or(Vec::with_capacity(0)),
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(0))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/test.rs:53:15
[INFO] [stderr]    |
[INFO] [stderr] 53 |             ).expect(&format!("Failed to build test: {}", target.name));
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to build test: {}", target.name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         writeln!(io::stderr(), "Error: {}", err).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:46:29
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Command::Help => Ok(help::help()),
[INFO] [stderr]    |                             ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Command::Help => Ok(()),
[INFO] [stderr]    |                             ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Command::BuildHelp => Ok(help::build_help()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Command::BuildHelp => Ok(()),
[INFO] [stderr]    |                                  ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Command::RunHelp => Ok(help::run_help()),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Command::RunHelp => Ok(()),
[INFO] [stderr]    |                                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Command::TestHelp => Ok(help::test_help()),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Command::TestHelp => Ok(()),
[INFO] [stderr]    |                                 ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:50:32
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Command::Version => Ok(println!("bootimage {}", env!("CARGO_PKG_VERSION"))),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/args.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let mut arg_iter = args.into_iter();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/build.rs:35:9
[INFO] [stderr]    |
[INFO] [stderr] 35 | /         if let &Some(ref target) = args.target() {
[INFO] [stderr] 36 | |             out_dir.push(Path::new(target).file_stem().unwrap().to_str().unwrap());
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if let Some(ref target) = *args.target() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/build.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     if let &Some(ref target) = args.target() {
[INFO] [stderr] 64 | |         if !target.ends_with(".json") {
[INFO] [stderr] 65 | |             use std::io::{self, Write};
[INFO] [stderr] 66 | |             use std::process;
[INFO] [stderr] ...  |
[INFO] [stderr] 74 | |         }
[INFO] [stderr] 75 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 63 |     if let Some(ref target) = *args.target() {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> src/build.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 | /             writeln!(
[INFO] [stderr] 69 | |                 io::stderr(),
[INFO] [stderr] 70 | |                 "Please pass a path to `--target` (with `.json` extension`): `--target {}.json`",
[INFO] [stderr] 71 | |                 target
[INFO] [stderr] 72 | |             ).unwrap();
[INFO] [stderr]    | |______________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (9/7)
[INFO] [stderr]    --> src/build.rs:336:1
[INFO] [stderr]     |
[INFO] [stderr] 336 | / fn create_disk_image(
[INFO] [stderr] 337 | |     root_dir: &Path,
[INFO] [stderr] 338 | |     out_dir: &Path,
[INFO] [stderr] 339 | |     bin_name: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 423 | |     Ok(output_path)
[INFO] [stderr] 424 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/build.rs:362:18
[INFO] [stderr]     |
[INFO] [stderr] 362 |                 .unwrap_or(output_path.as_path())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| output_path.as_path())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:48:47
[INFO] [stderr]    |
[INFO] [stderr] 48 |           Some(metadata) => metadata.as_table().ok_or(format_err!(
[INFO] [stderr]    |  _______________________________________________^
[INFO] [stderr] 49 | |             "Bootimage configuration invalid: {:?}",
[INFO] [stderr] 50 | |             metadata
[INFO] [stderr] 51 | |         ))?,
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Some(metadata) => metadata.as_table().ok_or_else(|| format_err!(
[INFO] [stderr] 49 |             "Bootimage configuration invalid: {:?}",
[INFO] [stderr] 50 |             metadata
[INFO] [stderr] 51 |         ))?,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let'
[INFO] [stderr]   --> src/config.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 |           .and_then(|table| {
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 62 | |             table
[INFO] [stderr] 63 | |                 .get("features")
[INFO] [stderr] 64 | |                 .or_else(|| table.get("default-features"))
[INFO] [stderr] 65 | |         })
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::block_in_if_condition_stmt)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:212:43
[INFO] [stderr]     |
[INFO] [stderr] 212 |               run_command: self.run_command.unwrap_or(vec![
[INFO] [stderr]     |  ___________________________________________^
[INFO] [stderr] 213 | |                 "qemu-system-x86_64".into(),
[INFO] [stderr] 214 | |                 "-drive".into(),
[INFO] [stderr] 215 | |                 "format=raw,file={}".into(),
[INFO] [stderr] 216 | |             ]),
[INFO] [stderr]     | |______________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 212 |             run_command: self.run_command.unwrap_or_else(|| vec![
[INFO] [stderr] 213 |                 "qemu-system-x86_64".into(),
[INFO] [stderr] 214 |                 "-drive".into(),
[INFO] [stderr] 215 |                 "format=raw,file={}".into(),
[INFO] [stderr] 216 |             ]),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:228:18
[INFO] [stderr]     |
[INFO] [stderr] 228 |                 .unwrap_or(PathBuf::from("x86_64-bootloader.json")),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("x86_64-bootloader.json"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:229:37
[INFO] [stderr]     |
[INFO] [stderr] 229 |             features: self.features.unwrap_or(Vec::with_capacity(0)),
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(0))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/test.rs:53:15
[INFO] [stderr]    |
[INFO] [stderr] 53 |             ).expect(&format!("Failed to build test: {}", target.name));
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to build test: {}", target.name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead
[INFO] [stderr]   --> src/main.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 |         writeln!(io::stderr(), "Error: {}", err).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:46:29
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Command::Help => Ok(help::help()),
[INFO] [stderr]    |                             ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 46 |         Command::Help => Ok(()),
[INFO] [stderr]    |                             ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:47:34
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Command::BuildHelp => Ok(help::build_help()),
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 47 |         Command::BuildHelp => Ok(()),
[INFO] [stderr]    |                                  ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:48:32
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Command::RunHelp => Ok(help::run_help()),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 48 |         Command::RunHelp => Ok(()),
[INFO] [stderr]    |                                ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Command::TestHelp => Ok(help::test_help()),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Command::TestHelp => Ok(()),
[INFO] [stderr]    |                                 ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/main.rs:50:32
[INFO] [stderr]    |
[INFO] [stderr] 50 |         Command::Version => Ok(println!("bootimage {}", env!("CARGO_PKG_VERSION"))),
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 45.17s
[INFO] running `"docker" "inspect" "694cb8e53bdb2183498eaacbdee2c1d4a6c45e9f3be76bdae8a889518b76e708"`
[INFO] running `"docker" "rm" "-f" "694cb8e53bdb2183498eaacbdee2c1d4a6c45e9f3be76bdae8a889518b76e708"`
[INFO] [stdout] 694cb8e53bdb2183498eaacbdee2c1d4a6c45e9f3be76bdae8a889518b76e708