[INFO] updating cached repository rust-lang/rust-playpen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-lang/rust-playpen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang/rust-playpen" "work/ex/clippy-test-run/sources/stable/gh/rust-lang/rust-playpen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-lang/rust-playpen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang/rust-playpen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/rust-playpen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/rust-playpen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d0975ed13716bbc1c242fdbdf75dc4c6e42f8d3 [INFO] sha for GitHub repo rust-lang/rust-playpen: 1d0975ed13716bbc1c242fdbdf75dc4c6e42f8d3 [INFO] validating manifest of rust-lang/rust-playpen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lang/rust-playpen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lang/rust-playpen [INFO] finished frobbing rust-lang/rust-playpen [INFO] frobbed toml for rust-lang/rust-playpen written to work/ex/clippy-test-run/sources/stable/gh/rust-lang/rust-playpen/Cargo.toml [INFO] started frobbing rust-lang/rust-playpen [INFO] finished frobbing rust-lang/rust-playpen [INFO] frobbed toml for rust-lang/rust-playpen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/rust-playpen/Cargo.toml [INFO] crate rust-lang/rust-playpen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lang/rust-playpen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-lang/rust-playpen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7430e342620dcc57d2c02a12cec8bb2181cb9ed7e0b72a211255ba67e62ab711 [INFO] running `"docker" "start" "-a" "7430e342620dcc57d2c02a12cec8bb2181cb9ed7e0b72a211255ba67e62ab711"` [INFO] [stderr] Compiling gcc v0.3.53 [INFO] [stderr] Checking futures v0.1.15 [INFO] [stderr] Compiling openssl v0.9.17 [INFO] [stderr] Checking serde v1.0.12 [INFO] [stderr] Checking sequence_trie v0.2.1 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking bytes v0.4.5 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking mime v0.3.3 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking mio v0.6.10 [INFO] [stderr] Compiling openssl-sys v0.9.17 [INFO] [stderr] Compiling backtrace-sys v0.1.12 [INFO] [stderr] Checking tokio-io v0.1.3 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.9 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking iron v0.5.1 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking router v0.5.1 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking irc v0.12.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking rust-playpen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const PLAYPEN_ENV_VAR_NAME: &'static str = "RUST_PLAYPEN_ENV"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cache` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Cache { [INFO] [stderr] 80 | | Cache { [INFO] [stderr] 81 | | cache: Mutex::new(LruCache::new(256)), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for Cache { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | cache.insert(key, (status.clone(), output.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | pub const PLAYPEN_ENV_VAR_NAME: &'static str = "RUST_PLAYPEN_ENV"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Cache` [INFO] [stderr] --> src/lib.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / pub fn new() -> Cache { [INFO] [stderr] 80 | | Cache { [INFO] [stderr] 81 | | cache: Mutex::new(LruCache::new(256)), [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | impl Default for Cache { [INFO] [stderr] 79 | fn default() -> Self { [INFO] [stderr] 80 | Self::new() [INFO] [stderr] 81 | } [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | cache.insert(key, (status.clone(), output.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/playpen.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate log; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/playpen.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | const ENV: &'static str = "web"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/playpen.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] extern crate log; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/playpen.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | const ENV: &'static str = "web"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/playpen.rs:308:43 [INFO] [stderr] | [INFO] [stderr] 308 | let addr = env::args().skip(1).next().unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/playpen.rs:308:16 [INFO] [stderr] | [INFO] [stderr] 308 | let addr = env::args().skip(1).next().unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/playpen.rs:308:43 [INFO] [stderr] | [INFO] [stderr] 308 | let addr = env::args().skip(1).next().unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/bin/playpen.rs:308:16 [INFO] [stderr] | [INFO] [stderr] 308 | let addr = env::args().skip(1).next().unwrap_or("127.0.0.1".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: unused imports: `AssertUnwindSafe`, `catch_unwind` [INFO] [stderr] --> src/bin/playbot.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | use std::panic::{AssertUnwindSafe, catch_unwind}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/playbot.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | const ENV: &'static str = "irc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/playbot.rs:253:52 [INFO] [stderr] | [INFO] [stderr] 253 | assert!(0 < port && port < u16::MAX as i64, "out of range for ports"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused imports: `AssertUnwindSafe`, `catch_unwind` [INFO] [stderr] --> src/bin/playbot.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | use std::panic::{AssertUnwindSafe, catch_unwind}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/playbot.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | const ENV: &'static str = "irc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/bin/playbot.rs:253:52 [INFO] [stderr] | [INFO] [stderr] 253 | assert!(0 < port && port < u16::MAX as i64, "out of range for ports"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `"docker" "inspect" "7430e342620dcc57d2c02a12cec8bb2181cb9ed7e0b72a211255ba67e62ab711"` [INFO] running `"docker" "rm" "-f" "7430e342620dcc57d2c02a12cec8bb2181cb9ed7e0b72a211255ba67e62ab711"` [INFO] [stdout] 7430e342620dcc57d2c02a12cec8bb2181cb9ed7e0b72a211255ba67e62ab711