[INFO] updating cached repository rust-lang/mailgun-mailmap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-lang/mailgun-mailmap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang/mailgun-mailmap" "work/ex/clippy-test-run/sources/stable/gh/rust-lang/mailgun-mailmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-lang/mailgun-mailmap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang/mailgun-mailmap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/mailgun-mailmap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/mailgun-mailmap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a700c4c4ee1251468a99475e661b9fd949da7839 [INFO] sha for GitHub repo rust-lang/mailgun-mailmap: a700c4c4ee1251468a99475e661b9fd949da7839 [INFO] validating manifest of rust-lang/mailgun-mailmap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lang/mailgun-mailmap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lang/mailgun-mailmap [INFO] finished frobbing rust-lang/mailgun-mailmap [INFO] frobbed toml for rust-lang/mailgun-mailmap written to work/ex/clippy-test-run/sources/stable/gh/rust-lang/mailgun-mailmap/Cargo.toml [INFO] started frobbing rust-lang/mailgun-mailmap [INFO] finished frobbing rust-lang/mailgun-mailmap [INFO] frobbed toml for rust-lang/mailgun-mailmap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang/mailgun-mailmap/Cargo.toml [INFO] crate rust-lang/mailgun-mailmap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lang/mailgun-mailmap against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-lang/mailgun-mailmap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77ae73db3e9d1da8c656f2036fe995202175a3a4abdab80401b0e3455e951b48 [INFO] running `"docker" "start" "-a" "77ae73db3e9d1da8c656f2036fe995202175a3a4abdab80401b0e3455e951b48"` [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling curl-sys v0.4.13 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Compiling syn v0.15.17 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking mailgun-mailmap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:11 [INFO] [stderr] | [INFO] [stderr] 79 | while response.items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:135:11 [INFO] [stderr] | [INFO] [stderr] 135 | while response.items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:147:8 [INFO] [stderr] | [INFO] [stderr] 147 | if to_add.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:11 [INFO] [stderr] | [INFO] [stderr] 79 | while response.items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:135:11 [INFO] [stderr] | [INFO] [stderr] 135 | while response.items.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!response.items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:147:8 [INFO] [stderr] | [INFO] [stderr] 147 | if to_add.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_add.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.97s [INFO] running `"docker" "inspect" "77ae73db3e9d1da8c656f2036fe995202175a3a4abdab80401b0e3455e951b48"` [INFO] running `"docker" "rm" "-f" "77ae73db3e9d1da8c656f2036fe995202175a3a4abdab80401b0e3455e951b48"` [INFO] [stdout] 77ae73db3e9d1da8c656f2036fe995202175a3a4abdab80401b0e3455e951b48