[INFO] updating cached repository rust-lang-nursery/mdBook [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-lang-nursery/mdBook [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/mdBook" "work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/mdBook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/mdBook'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/mdBook" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/mdBook"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/mdBook'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1052ee92e12872f7422d230c1f5b888a3f74e1aa [INFO] sha for GitHub repo rust-lang-nursery/mdBook: 1052ee92e12872f7422d230c1f5b888a3f74e1aa [INFO] validating manifest of rust-lang-nursery/mdBook on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lang-nursery/mdBook on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lang-nursery/mdBook [INFO] finished frobbing rust-lang-nursery/mdBook [INFO] frobbed toml for rust-lang-nursery/mdBook written to work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/mdBook/Cargo.toml [INFO] started frobbing rust-lang-nursery/mdBook [INFO] finished frobbing rust-lang-nursery/mdBook [INFO] frobbed toml for rust-lang-nursery/mdBook written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/mdBook/Cargo.toml [INFO] crate rust-lang-nursery/mdBook has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lang-nursery/mdBook against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/mdBook:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec921b562c33b5b0c19530506c40690877783371e28cb5d62106d0aca2fac1da [INFO] running `"docker" "start" "-a" "ec921b562c33b5b0c19530506c40690877783371e28cb5d62106d0aca2fac1da"` [INFO] [stderr] Compiling pulldown-cmark v0.1.2 [INFO] [stderr] Checking strum v0.9.0 [INFO] [stderr] Checking is-match v0.1.0 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking getopts v0.2.18 [INFO] [stderr] Checking pretty_assertions v0.5.1 [INFO] [stderr] Checking debug_unreachable v0.1.1 [INFO] [stderr] Checking toml v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.32 [INFO] [stderr] Compiling html5ever v0.18.0 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Compiling syn v0.15.12 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking toml-query v0.7.0 [INFO] [stderr] Checking handlebars v1.0.5 [INFO] [stderr] Checking pulldown-cmark-to-cmark v1.1.0 [INFO] [stderr] Compiling strum_macros v0.9.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking ws v0.7.9 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking string_cache v0.7.3 [INFO] [stderr] Checking notify v4.0.6 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking mount v0.4.0 [INFO] [stderr] Checking staticfile v0.5.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Compiling markup5ever v0.7.3 [INFO] [stderr] Checking elasticlunr-rs v2.3.3 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking ammonia v1.2.0 [INFO] [stderr] Checking mdbook v0.2.3-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/book/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod book; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/book/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | mod book; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/book/book.rs:304:23 [INFO] [stderr] | [INFO] [stderr] 304 | const DUMMY_SRC: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:563:28 [INFO] [stderr] | [INFO] [stderr] 563 | const COMPLEX_CONFIG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/book/book.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &mut BookItem::Chapter(ref mut ch) = item { [INFO] [stderr] 120 | | for_each_mut(func, &mut ch.sub_items); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let BookItem::Chapter(ref mut ch) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 81 | | toml::from_str(src).chain_err(|| Error::from("Invalid configuration file")) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::index::IndexPreprocessor` [INFO] [stderr] --> src/preprocess/index.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | IndexPreprocessor [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preprocess/index.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | let parent_dir = index_path.as_ref().parent().unwrap_or(index_path.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| index_path.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::links::LinkPreprocessor` [INFO] [stderr] --> src/preprocess/links.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | LinkPreprocessor [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/preprocess/links.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | / Range { [INFO] [stderr] 152 | | start, [INFO] [stderr] 153 | | end: start + 1, [INFO] [stderr] 154 | | }, [INFO] [stderr] | |_____________________^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/renderer/html_handlebars/helpers/theme.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | .ok_or(RenderError::new( [INFO] [stderr] | __________^ [INFO] [stderr] 16 | | "Param 0 with String type is required for theme_option helper.", [INFO] [stderr] 17 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | .ok_or_else(|| RenderError::new( [INFO] [stderr] 16 | "Param 0 with String type is required for theme_option helper.", [INFO] [stderr] 17 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let max_section_depth = search_config.heading_split_level as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(search_config.heading_split_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn collapse_whitespace<'a>(text: &'a str) -> Cow<'a, str> { [INFO] [stderr] 18 | | lazy_static! { [INFO] [stderr] 19 | | static ref RE: Regex = Regex::new(r"\s\s+").unwrap(); [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | RE.replace_all(text, " ") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/book/book.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / if let &mut BookItem::Chapter(ref mut ch) = item { [INFO] [stderr] 120 | | for_each_mut(func, &mut ch.sub_items); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | if let BookItem::Chapter(ref mut ch) = *item { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/book/book.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / File::create(&chapter_path) [INFO] [stderr] 319 | | .unwrap() [INFO] [stderr] 320 | | .write(DUMMY_SRC.as_bytes()) [INFO] [stderr] 321 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/book/book.rs:336:24 [INFO] [stderr] | [INFO] [stderr] 336 | .write_all("Hello World!".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello World!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn from_str(src: &str) -> Result { [INFO] [stderr] 81 | | toml::from_str(src).chain_err(|| Error::from("Invalid configuration file")) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/config.rs:604:15 [INFO] [stderr] | [INFO] [stderr] 604 | ..Default::default() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> src/config.rs:661:13 [INFO] [stderr] | [INFO] [stderr] 661 | let baz: Vec = cfg.get_deserialized("output.random.baz").unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/config.rs:789:58 [INFO] [stderr] | [INFO] [stderr] 789 | let value = json!({"array": [1, 2, 3], "number": 3.14}); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::index::IndexPreprocessor` [INFO] [stderr] --> src/preprocess/index.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | IndexPreprocessor [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/preprocess/index.rs:48:51 [INFO] [stderr] | [INFO] [stderr] 48 | let parent_dir = index_path.as_ref().parent().unwrap_or(index_path.as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| index_path.as_ref())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `preprocess::links::LinkPreprocessor` [INFO] [stderr] --> src/preprocess/links.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn new() -> Self { [INFO] [stderr] 23 | | LinkPreprocessor [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/preprocess/links.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | / Range { [INFO] [stderr] 152 | | start, [INFO] [stderr] 153 | | end: start + 1, [INFO] [stderr] 154 | | }, [INFO] [stderr] | |_____________________^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/renderer/html_handlebars/helpers/theme.rs:15:10 [INFO] [stderr] | [INFO] [stderr] 15 | .ok_or(RenderError::new( [INFO] [stderr] | __________^ [INFO] [stderr] 16 | | "Param 0 with String type is required for theme_option helper.", [INFO] [stderr] 17 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | .ok_or_else(|| RenderError::new( [INFO] [stderr] 16 | "Param 0 with String type is required for theme_option helper.", [INFO] [stderr] 17 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | fn call<'reg: 'rc, 'rc>( [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/renderer/html_handlebars/search.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let max_section_depth = search_config.heading_split_level as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(search_config.heading_split_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/utils/fs.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | Err(_) => panic!("Could not create a temp dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if let Err(_) = fs::File::create(&tmp.path().join("file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 204 | | panic!("Could not create file.txt") [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | if let Err(_) = fs::File::create(&tmp.path().join("file.md")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 207 | | panic!("Could not create file.md") [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.md")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:209:16 [INFO] [stderr] | [INFO] [stderr] 209 | if let Err(_) = fs::File::create(&tmp.path().join("file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 210 | | panic!("Could not create file.png") [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:212:16 [INFO] [stderr] | [INFO] [stderr] 212 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 213 | | panic!("Could not create sub_dir") [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:215:16 [INFO] [stderr] | [INFO] [stderr] 215 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir/file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 216 | | panic!("Could not create sub_dir/file.png") [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir/file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:218:16 [INFO] [stderr] | [INFO] [stderr] 218 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 219 | | panic!("Could not create sub_dir_exists") [INFO] [stderr] 220 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:221:16 [INFO] [stderr] | [INFO] [stderr] 221 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 222 | | panic!("Could not create sub_dir_exists/file.txt") [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:226:16 [INFO] [stderr] | [INFO] [stderr] 226 | if let Err(_) = fs::create_dir(&tmp.path().join("output")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 227 | | panic!("Could not create output") [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | if let Err(_) = fs::create_dir(&tmp.path().join("output/sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 230 | | panic!("Could not create output/sub_dir_exists") [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output/sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/fs.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / match copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { [INFO] [stderr] 234 | | Err(e) => panic!("Error while executing the function:\n{:?}", e), [INFO] [stderr] 235 | | Ok(_) => {} [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { panic!("Error while executing the function:\n{:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/utils/mod.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn collapse_whitespace<'a>(text: &'a str) -> Cow<'a, str> { [INFO] [stderr] 18 | | lazy_static! { [INFO] [stderr] 19 | | static ref RE: Regex = Regex::new(r"\s\s+").unwrap(); [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | RE.replace_all(text, " ") [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mdbook`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> examples/nop-preprocessor.rs:31:12 [INFO] [stderr] | [INFO] [stderr] 31 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 32 | | if let Err(e) = handle_preprocessing(&preprocessor) { [INFO] [stderr] 33 | | eprintln!("{}", e); [INFO] [stderr] 34 | | process::exit(1); [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | } else if let Err(e) = handle_preprocessing(&preprocessor) { [INFO] [stderr] 32 | eprintln!("{}", e); [INFO] [stderr] 33 | process::exit(1); [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ec921b562c33b5b0c19530506c40690877783371e28cb5d62106d0aca2fac1da"` [INFO] running `"docker" "rm" "-f" "ec921b562c33b5b0c19530506c40690877783371e28cb5d62106d0aca2fac1da"` [INFO] [stdout] ec921b562c33b5b0c19530506c40690877783371e28cb5d62106d0aca2fac1da