[INFO] updating cached repository rust-lang-nursery/crater [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-lang-nursery/crater [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/crater" "work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/crater"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/crater'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/crater" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/crater"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/crater'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24e9ce010a338045f6fcd6335dc34eb8d9f07930 [INFO] sha for GitHub repo rust-lang-nursery/crater: 24e9ce010a338045f6fcd6335dc34eb8d9f07930 [INFO] validating manifest of rust-lang-nursery/crater on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lang-nursery/crater on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lang-nursery/crater [INFO] finished frobbing rust-lang-nursery/crater [INFO] frobbed toml for rust-lang-nursery/crater written to work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/crater/Cargo.toml [INFO] started frobbing rust-lang-nursery/crater [INFO] finished frobbing rust-lang-nursery/crater [INFO] frobbed toml for rust-lang-nursery/crater written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/crater/Cargo.toml [INFO] crate rust-lang-nursery/crater has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lang-nursery/crater against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/crater:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da1748151671acf112de0fca69e8d1f9939d8a3ad43571a2d9158a1e3cc57a77 [INFO] running `"docker" "start" "-a" "da1748151671acf112de0fca69e8d1f9939d8a3ad43571a2d9158a1e3cc57a77"` [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Checking unic-common v0.7.0 [INFO] [stderr] Checking arc-swap v0.3.4 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking utf-8 v0.7.4 [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Compiling crater v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking ordermap v0.3.5 [INFO] [stderr] Checking urlencoding v1.0.0 [INFO] [stderr] Checking humansize v1.1.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking macro-utils v0.1.2 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking ref_slice v1.1.1 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Compiling curl-sys v0.4.13 [INFO] [stderr] Compiling libsqlite3-sys v0.10.0 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Checking unic-ucd-version v0.7.0 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking signal-hook v0.1.5 [INFO] [stderr] Checking pest v2.0.2 [INFO] [stderr] Checking walkdir v2.2.6 [INFO] [stderr] Checking lock_api v0.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking r2d2 v0.8.3 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking unic-ucd-segment v0.7.0 [INFO] [stderr] Checking tar v0.4.17 [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking headers-core v0.0.1 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking flate2 v1.0.4 [INFO] [stderr] Checking unic-segment v0.7.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Compiling proc-macro-hack v0.5.1 [INFO] [stderr] Compiling headers-derive v0.0.1 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Compiling paste-impl v0.1.3 [INFO] [stderr] Checking minifier v0.0.20 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking headers-ext v0.0.3 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking paste v0.1.3 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.6 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking serde_regex v0.3.1 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking toml v0.4.8 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking warp v0.1.9 [INFO] [stderr] Checking rusoto_credential v0.14.0 [INFO] [stderr] Checking chrono-humanize v0.0.11 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking tera v0.11.19 [INFO] [stderr] Checking assert_cmd v0.10.1 [INFO] [stderr] Checking rusoto_core v0.35.0 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking rusoto_s3 v0.35.0 [INFO] [stderr] Checking r2d2_sqlite v0.7.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking crates-index v0.12.0 [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/config.rs:248:40 [INFO] [stderr] | [INFO] [stderr] 248 | remove: Regex::new("^$").unwrap(), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::is_empty` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/report/archives.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / fn test_logs_archives_generation() { [INFO] [stderr] 110 | | let config = Config::default(); [INFO] [stderr] 111 | | let db = Database::temp().unwrap(); [INFO] [stderr] 112 | | let writer = DummyWriter::default(); [INFO] [stderr] ... | [INFO] [stderr] 224 | | }); [INFO] [stderr] 225 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> tests/minicrater/mod.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | let expected_report = ::std::fs::read(&expected_file).unwrap_or(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `::std::fs::read(&expected_file).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/report/mod.rs:533:5 [INFO] [stderr] | [INFO] [stderr] 533 | / fn test_compare() { [INFO] [stderr] 534 | | use crate::results::{FailureReason::*, TestResult::*}; [INFO] [stderr] 535 | | [INFO] [stderr] 536 | | macro_rules! test_compare { [INFO] [stderr] ... | [INFO] [stderr] 614 | | assert_eq!(compare(&config, ®, None, None), Comparison::Skipped); [INFO] [stderr] 615 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/results/db.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | shas.get(&repo1).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shas[&repo1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/results/db.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | shas.get(&repo2).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shas[&repo2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/results/db.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | shas.get(&repo1).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shas[&repo1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/results/db.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | shas.get(&repo2).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&shas[&repo2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/results/db.rs:423:18 [INFO] [stderr] | [INFO] [stderr] 423 | Some("foo".as_bytes().to_vec()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/toolchain.rs:238:5 [INFO] [stderr] | [INFO] [stderr] 238 | / fn test_string_repr() { [INFO] [stderr] 239 | | macro_rules! test_from_str { [INFO] [stderr] 240 | | ($($str:expr => $source:expr,)*) => { [INFO] [stderr] 241 | | $( [INFO] [stderr] ... | [INFO] [stderr] 294 | | assert!(Toolchain::from_str("stable+donotusethisflag=ever").is_err()) [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 07s [INFO] running `"docker" "inspect" "da1748151671acf112de0fca69e8d1f9939d8a3ad43571a2d9158a1e3cc57a77"` [INFO] running `"docker" "rm" "-f" "da1748151671acf112de0fca69e8d1f9939d8a3ad43571a2d9158a1e3cc57a77"` [INFO] [stdout] da1748151671acf112de0fca69e8d1f9939d8a3ad43571a2d9158a1e3cc57a77