[INFO] updating cached repository rust-lang-nursery/cargo-bisect-rustc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-lang-nursery/cargo-bisect-rustc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/cargo-bisect-rustc" "work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/cargo-bisect-rustc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/cargo-bisect-rustc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-lang-nursery/cargo-bisect-rustc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/cargo-bisect-rustc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/cargo-bisect-rustc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7cb072023362529a586966756c2d837ef3cdb779 [INFO] sha for GitHub repo rust-lang-nursery/cargo-bisect-rustc: 7cb072023362529a586966756c2d837ef3cdb779 [INFO] validating manifest of rust-lang-nursery/cargo-bisect-rustc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-lang-nursery/cargo-bisect-rustc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-lang-nursery/cargo-bisect-rustc [INFO] finished frobbing rust-lang-nursery/cargo-bisect-rustc [INFO] frobbed toml for rust-lang-nursery/cargo-bisect-rustc written to work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/cargo-bisect-rustc/Cargo.toml [INFO] started frobbing rust-lang-nursery/cargo-bisect-rustc [INFO] finished frobbing rust-lang-nursery/cargo-bisect-rustc [INFO] frobbed toml for rust-lang-nursery/cargo-bisect-rustc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-lang-nursery/cargo-bisect-rustc/Cargo.toml [INFO] crate rust-lang-nursery/cargo-bisect-rustc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-lang-nursery/cargo-bisect-rustc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-lang-nursery/cargo-bisect-rustc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 87d06ef0780ebda4aa313e623a17dcb86a1b7871367f44c8a4bc0bf2eb86fe5e [INFO] running `"docker" "start" "-a" "87d06ef0780ebda4aa313e623a17dcb86a1b7871367f44c8a4bc0bf2eb86fe5e"` [INFO] [stderr] Compiling arrayvec v0.4.9 [INFO] [stderr] Compiling encoding_rs v0.8.13 [INFO] [stderr] Checking rustc-demangle v0.1.11 [INFO] [stderr] Compiling cargo-bisect-rustc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking tee v0.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.40 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling lzma-sys v0.1.12 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking clicolors-control v0.3.1 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Checking crossbeam-epoch v0.7.0 [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking parking_lot v0.7.0 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking console v0.7.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking dialoguer v0.3.0 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking git2 v0.8.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | url_prefix: url_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:25 [INFO] [stderr] | [INFO] [stderr] 580 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:743:48 [INFO] [stderr] | [INFO] [stderr] 743 | spec: ToolchainSpec::Nightly { date: date }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:927:52 [INFO] [stderr] | [INFO] [stderr] 927 | spec: ToolchainSpec::Nightly { date: date }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | url_prefix: url_prefix, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:25 [INFO] [stderr] | [INFO] [stderr] 580 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:743:48 [INFO] [stderr] | [INFO] [stderr] 743 | spec: ToolchainSpec::Nightly { date: date }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:927:52 [INFO] [stderr] | [INFO] [stderr] 927 | spec: ToolchainSpec::Nightly { date: date }, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:486:16 [INFO] [stderr] | [INFO] [stderr] 486 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 487 | | if self.run_test(cfg).success() { [INFO] [stderr] 488 | | TestOutcome::Baseline [INFO] [stderr] 489 | | } else { [INFO] [stderr] 490 | | TestOutcome::Regressed [INFO] [stderr] 491 | | } [INFO] [stderr] 492 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 486 | } else if self.run_test(cfg).success() { [INFO] [stderr] 487 | TestOutcome::Baseline [INFO] [stderr] 488 | } else { [INFO] [stderr] 489 | TestOutcome::Regressed [INFO] [stderr] 490 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:542:9 [INFO] [stderr] | [INFO] [stderr] 542 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:535:22 [INFO] [stderr] | [INFO] [stderr] 535 | let status = match cmd.status() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 536 | | Ok(status) => status, [INFO] [stderr] 537 | | Err(err) => { [INFO] [stderr] 538 | | panic!("failed to run {:?}: {:?}", cmd, err); [INFO] [stderr] 539 | | } [INFO] [stderr] 540 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:648:32 [INFO] [stderr] | [INFO] [stderr] 648 | let mut home = env::home_dir().ok_or_else(|| format_err!("Could not find home."))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:486:16 [INFO] [stderr] | [INFO] [stderr] 486 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 487 | | if self.run_test(cfg).success() { [INFO] [stderr] 488 | | TestOutcome::Baseline [INFO] [stderr] 489 | | } else { [INFO] [stderr] 490 | | TestOutcome::Regressed [INFO] [stderr] 491 | | } [INFO] [stderr] 492 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 486 | } else if self.run_test(cfg).success() { [INFO] [stderr] 487 | TestOutcome::Baseline [INFO] [stderr] 488 | } else { [INFO] [stderr] 489 | TestOutcome::Regressed [INFO] [stderr] 490 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:542:9 [INFO] [stderr] | [INFO] [stderr] 542 | status [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:535:22 [INFO] [stderr] | [INFO] [stderr] 535 | let status = match cmd.status() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 536 | | Ok(status) => status, [INFO] [stderr] 537 | | Err(err) => { [INFO] [stderr] 538 | | panic!("failed to run {:?}: {:?}", cmd, err); [INFO] [stderr] 539 | | } [INFO] [stderr] 540 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:648:32 [INFO] [stderr] | [INFO] [stderr] 648 | let mut home = env::home_dir().ok_or_else(|| format_err!("Could not find home."))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | fn as_commit(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:196:36 [INFO] [stderr] | [INFO] [stderr] 196 | let (response, mut bar) = download_progress(&client, &name, &url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:259:38 [INFO] [stderr] | [INFO] [stderr] 259 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:287:38 [INFO] [stderr] | [INFO] [stderr] 287 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | let mut bar = ProgressBar::new(length); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:384:24 [INFO] [stderr] | [INFO] [stderr] 384 | let (response, mut bar) = download_progress(client, name, url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:398:24 [INFO] [stderr] | [INFO] [stderr] 398 | let (response, mut bar) = download_progress(client, name, url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:880:39 [INFO] [stderr] | [INFO] [stderr] 880 | let first_success = first_success.ok_or(format_err!("could not find a nightly that built"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("could not find a nightly that built"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | fn as_commit(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:196:36 [INFO] [stderr] | [INFO] [stderr] 196 | let (response, mut bar) = download_progress(&client, &name, &url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:259:38 [INFO] [stderr] | [INFO] [stderr] 259 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:287:38 [INFO] [stderr] | [INFO] [stderr] 287 | let alt_s = if alt { format!("-alt") } else { String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"-alt".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:370:13 [INFO] [stderr] | [INFO] [stderr] 370 | let mut bar = ProgressBar::new(length); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:384:24 [INFO] [stderr] | [INFO] [stderr] 384 | let (response, mut bar) = download_progress(client, name, url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/main.rs:398:24 [INFO] [stderr] | [INFO] [stderr] 398 | let (response, mut bar) = download_progress(client, name, url)?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:880:39 [INFO] [stderr] | [INFO] [stderr] 880 | let first_success = first_success.ok_or(format_err!("could not find a nightly that built"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("could not find a nightly that built"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 05s [INFO] running `"docker" "inspect" "87d06ef0780ebda4aa313e623a17dcb86a1b7871367f44c8a4bc0bf2eb86fe5e"` [INFO] running `"docker" "rm" "-f" "87d06ef0780ebda4aa313e623a17dcb86a1b7871367f44c8a4bc0bf2eb86fe5e"` [INFO] [stdout] 87d06ef0780ebda4aa313e623a17dcb86a1b7871367f44c8a4bc0bf2eb86fe5e