[INFO] updating cached repository rust-embedded/gpio-utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-embedded/gpio-utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-embedded/gpio-utils" "work/ex/clippy-test-run/sources/stable/gh/rust-embedded/gpio-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-embedded/gpio-utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-embedded/gpio-utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-embedded/gpio-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-embedded/gpio-utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c86a9fb00e222db58c623a56771967cc24ab9538 [INFO] sha for GitHub repo rust-embedded/gpio-utils: c86a9fb00e222db58c623a56771967cc24ab9538 [INFO] validating manifest of rust-embedded/gpio-utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-embedded/gpio-utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-embedded/gpio-utils [INFO] finished frobbing rust-embedded/gpio-utils [INFO] frobbed toml for rust-embedded/gpio-utils written to work/ex/clippy-test-run/sources/stable/gh/rust-embedded/gpio-utils/Cargo.toml [INFO] started frobbing rust-embedded/gpio-utils [INFO] finished frobbing rust-embedded/gpio-utils [INFO] frobbed toml for rust-embedded/gpio-utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-embedded/gpio-utils/Cargo.toml [INFO] crate rust-embedded/gpio-utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-embedded/gpio-utils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-embedded/gpio-utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a950f46c82d91950e227e06f2368f3236310c561a6df037e3cec4042607956a [INFO] running `"docker" "start" "-a" "8a950f46c82d91950e227e06f2368f3236310c561a6df037e3cec4042607956a"` [INFO] [stderr] Checking users v0.8.0 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Compiling syn v0.15.12 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking sysfs_gpio v0.5.3 [INFO] [stderr] Checking gpio-utils v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | const BASIC_CFG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:287:25 [INFO] [stderr] | [INFO] [stderr] 287 | const COMPACT_CFG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:297:32 [INFO] [stderr] | [INFO] [stderr] 297 | const MISSING_PINNUM_CFG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:302:34 [INFO] [stderr] | [INFO] [stderr] 302 | const DUPLICATED_NAMES_CFG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | const PARTIALLY_OVERLAPS_BASIC_CFG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:336:26 [INFO] [stderr] | [INFO] [stderr] 336 | let status_led = config.pins.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:345:28 [INFO] [stderr] | [INFO] [stderr] 345 | let reset_button = config.pins.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:390:26 [INFO] [stderr] | [INFO] [stderr] 390 | let status_led = config.pins.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:449:28 [INFO] [stderr] | [INFO] [stderr] 449 | let reset_button = config.pins.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:459:26 [INFO] [stderr] | [INFO] [stderr] 459 | let status_led = config.pins.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:470:24 [INFO] [stderr] | [INFO] [stderr] 470 | let wildcard = config.pins.get(2).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&config.pins[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.84s [INFO] running `"docker" "inspect" "8a950f46c82d91950e227e06f2368f3236310c561a6df037e3cec4042607956a"` [INFO] running `"docker" "rm" "-f" "8a950f46c82d91950e227e06f2368f3236310c561a6df037e3cec4042607956a"` [INFO] [stdout] 8a950f46c82d91950e227e06f2368f3236310c561a6df037e3cec4042607956a