[INFO] updating cached repository rust-bravo/rnginx [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-bravo/rnginx [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-bravo/rnginx" "work/ex/clippy-test-run/sources/stable/gh/rust-bravo/rnginx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-bravo/rnginx'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-bravo/rnginx" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bravo/rnginx"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bravo/rnginx'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ca419d651e3c4903c2ef1c740ea67ca7155946b [INFO] sha for GitHub repo rust-bravo/rnginx: 7ca419d651e3c4903c2ef1c740ea67ca7155946b [INFO] validating manifest of rust-bravo/rnginx on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-bravo/rnginx on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-bravo/rnginx [INFO] finished frobbing rust-bravo/rnginx [INFO] frobbed toml for rust-bravo/rnginx written to work/ex/clippy-test-run/sources/stable/gh/rust-bravo/rnginx/Cargo.toml [INFO] started frobbing rust-bravo/rnginx [INFO] finished frobbing rust-bravo/rnginx [INFO] frobbed toml for rust-bravo/rnginx written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bravo/rnginx/Cargo.toml [INFO] crate rust-bravo/rnginx has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-bravo/rnginx against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-bravo/rnginx:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c413f9e91cd99b298493a894264ab09f4d99fc5eecf3659e540ce74568167ab3 [INFO] running `"docker" "start" "-a" "c413f9e91cd99b298493a894264ab09f4d99fc5eecf3659e540ce74568167ab3"` [INFO] [stderr] Checking rnginx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | -- matches any value [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ unreachable pattern [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `OK` [INFO] [stderr] --> src/http/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | ^^ help: consider using `_OK` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `NotFound` [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ help: consider using `_NotFound` instead [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `PROTOCOL` [INFO] [stderr] --> src/http/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | static PROTOCOL: &'static str = "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/http/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | fn value(state: HTTP) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/worker/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | name: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num` [INFO] [stderr] --> src/worker/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | num: &'a u32 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `OK` should have a snake case name such as `ok` [INFO] [stderr] --> src/http/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `NotFound` should have a snake case name such as `not_found` [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/server/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/server/mod.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | } else if buffer.starts_with(sleep) { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 51 | | // thread::sleep(Duration::from_secs(5)); [INFO] [stderr] 52 | | ("HTTP/1.1 200 OK\r\n\r\n", "hello.html") [INFO] [stderr] 53 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/server/mod.rs:48:66 [INFO] [stderr] | [INFO] [stderr] 48 | let (status_line, filename) = if buffer.starts_with(get) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 49 | | ("HTTP/1.1 200 OK\r\n\r\n", "hello.html") [INFO] [stderr] 50 | | } else if buffer.starts_with(sleep) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | -- matches any value [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ unreachable pattern [INFO] [stderr] error: Could not compile `rnginx`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `OK` [INFO] [stderr] --> src/http/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | ^^ help: consider using `_OK` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `NotFound` [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ help: consider using `_NotFound` instead [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `PROTOCOL` [INFO] [stderr] --> src/http/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | static PROTOCOL: &'static str = "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/http/mod.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | fn value(state: HTTP) -> &'static str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/worker/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | name: &'a str, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `num` [INFO] [stderr] --> src/worker/mod.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | num: &'a u32 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `OK` should have a snake case name such as `ok` [INFO] [stderr] --> src/http/mod.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | OK => "200 OK\r\n\r\n", [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `NotFound` should have a snake case name such as `not_found` [INFO] [stderr] --> src/http/mod.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | NotFound => "404 OK\r\n\r\n", [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/server/mod.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | stream.read(&mut buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/server/mod.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | } else if buffer.starts_with(sleep) { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 51 | | // thread::sleep(Duration::from_secs(5)); [INFO] [stderr] 52 | | ("HTTP/1.1 200 OK\r\n\r\n", "hello.html") [INFO] [stderr] 53 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/server/mod.rs:48:66 [INFO] [stderr] | [INFO] [stderr] 48 | let (status_line, filename) = if buffer.starts_with(get) { [INFO] [stderr] | __________________________________________________________________^ [INFO] [stderr] 49 | | ("HTTP/1.1 200 OK\r\n\r\n", "hello.html") [INFO] [stderr] 50 | | } else if buffer.starts_with(sleep) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/server/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | stream.write(response.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rnginx`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c413f9e91cd99b298493a894264ab09f4d99fc5eecf3659e540ce74568167ab3"` [INFO] running `"docker" "rm" "-f" "c413f9e91cd99b298493a894264ab09f4d99fc5eecf3659e540ce74568167ab3"` [INFO] [stdout] c413f9e91cd99b298493a894264ab09f4d99fc5eecf3659e540ce74568167ab3