[INFO] updating cached repository rust-bratislava/mini_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rust-bratislava/mini_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rust-bratislava/mini_game" "work/ex/clippy-test-run/sources/stable/gh/rust-bratislava/mini_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rust-bratislava/mini_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rust-bratislava/mini_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bratislava/mini_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bratislava/mini_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 51b1474c433d25991772734617154ef3f6225968 [INFO] sha for GitHub repo rust-bratislava/mini_game: 51b1474c433d25991772734617154ef3f6225968 [INFO] validating manifest of rust-bratislava/mini_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rust-bratislava/mini_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rust-bratislava/mini_game [INFO] finished frobbing rust-bratislava/mini_game [INFO] frobbed toml for rust-bratislava/mini_game written to work/ex/clippy-test-run/sources/stable/gh/rust-bratislava/mini_game/Cargo.toml [INFO] started frobbing rust-bratislava/mini_game [INFO] finished frobbing rust-bratislava/mini_game [INFO] frobbed toml for rust-bratislava/mini_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rust-bratislava/mini_game/Cargo.toml [INFO] crate rust-bratislava/mini_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rust-bratislava/mini_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rust-bratislava/mini_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cfb59d489fe7e3b8b0e97b414b89d54dbc231fa9367f29f21945e51543199ad2 [INFO] running `"docker" "start" "-a" "cfb59d489fe7e3b8b0e97b414b89d54dbc231fa9367f29f21945e51543199ad2"` [INFO] [stderr] Compiling libc v0.2.24 [INFO] [stderr] Compiling num-traits v0.1.39 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking shared_library v0.1.6 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking rayon v0.8.1 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking num-integer v0.1.34 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.38 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking glutin v0.8.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking mini_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:53 [INFO] [stderr] | [INFO] [stderr] 40 | let transform = context.transform.trans(ball.x as f64, ball.y as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ball.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:68 [INFO] [stderr] | [INFO] [stderr] 40 | let transform = context.transform.trans(ball.x as f64, ball.y as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ball.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let (x, y) = (self.position as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | let transform = c.transform.trans(15.0 + 15.0 * i as f64, 5.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | fn update(&mut self, args: &UpdateArgs, entities: &mut Entities) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:53 [INFO] [stderr] | [INFO] [stderr] 40 | let transform = context.transform.trans(ball.x as f64, ball.y as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ball.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:68 [INFO] [stderr] | [INFO] [stderr] 40 | let transform = context.transform.trans(ball.x as f64, ball.y as f64) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(ball.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let (x, y) = (self.position as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | args.height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:65 [INFO] [stderr] | [INFO] [stderr] 78 | let transform = c.transform.trans(15.0 + 15.0 * i as f64, 5.0) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | fn update(&mut self, args: &UpdateArgs, entities: &mut Entities) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.05s [INFO] running `"docker" "inspect" "cfb59d489fe7e3b8b0e97b414b89d54dbc231fa9367f29f21945e51543199ad2"` [INFO] running `"docker" "rm" "-f" "cfb59d489fe7e3b8b0e97b414b89d54dbc231fa9367f29f21945e51543199ad2"` [INFO] [stdout] cfb59d489fe7e3b8b0e97b414b89d54dbc231fa9367f29f21945e51543199ad2