[INFO] updating cached repository rummolprod999/WebParserRust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rummolprod999/WebParserRust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rummolprod999/WebParserRust" "work/ex/clippy-test-run/sources/stable/gh/rummolprod999/WebParserRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rummolprod999/WebParserRust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rummolprod999/WebParserRust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rummolprod999/WebParserRust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rummolprod999/WebParserRust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f4ca2a2340dd19c933ca4c684546ab299d6b78ab [INFO] sha for GitHub repo rummolprod999/WebParserRust: f4ca2a2340dd19c933ca4c684546ab299d6b78ab [INFO] validating manifest of rummolprod999/WebParserRust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rummolprod999/WebParserRust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rummolprod999/WebParserRust [INFO] finished frobbing rummolprod999/WebParserRust [INFO] frobbed toml for rummolprod999/WebParserRust written to work/ex/clippy-test-run/sources/stable/gh/rummolprod999/WebParserRust/Cargo.toml [INFO] started frobbing rummolprod999/WebParserRust [INFO] finished frobbing rummolprod999/WebParserRust [INFO] frobbed toml for rummolprod999/WebParserRust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rummolprod999/WebParserRust/Cargo.toml [INFO] crate rummolprod999/WebParserRust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rummolprod999/WebParserRust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rummolprod999/WebParserRust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 84f0e617c71b885d32be7f3f2031009bf74169965bfe1d985160598134e92fa0 [INFO] running `"docker" "start" "-a" "84f0e617c71b885d32be7f3f2031009bf74169965bfe1d985160598134e92fa0"` [INFO] [stderr] Compiling crc32fast v1.1.1 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling num-bigint v0.2.1 [INFO] [stderr] Checking bit-vec v0.5.0 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking md5 v0.6.0 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.1 [INFO] [stderr] Checking debug_unreachable v0.1.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking futf v0.1.4 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking checked v0.5.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking mysql_common v0.10.0 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking mysql v11.3.1 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking web_parser_rust v1.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/toolslib/datetimetools.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | Some(r) => Some(r), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/toolslib/datetimetools.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | let m = match dtt.checked_sub_signed(Duration::hours(3)) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/toolslib/datetimetools.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | Some(r) => Some(r), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/toolslib/datetimetools.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | let m = match dtt.checked_sub_signed(Duration::hours(3)) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parsers/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod parsers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/parsers/parsers.rs:2:26 [INFO] [stderr] | [INFO] [stderr] 2 | fn parser(&mut self) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/settings/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod settings; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let s = FullSettingsParser { [INFO] [stderr] | _____________^ [INFO] [stderr] 73 | | database: set.database, [INFO] [stderr] 74 | | userdb: set.userdb, [INFO] [stderr] 75 | | passdb: set.passdb, [INFO] [stderr] ... | [INFO] [stderr] 79 | | log, [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/settings/settings.rs:138:22 [INFO] [stderr] | [INFO] [stderr] 138 | fn create_argument() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | k [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let k = ARGUMENT.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | a [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | let a = match matches.value_of("argument") { [INFO] [stderr] | _____________^ [INFO] [stderr] 167 | | None => { [INFO] [stderr] 168 | | println!("empty argument, use -h for help"); [INFO] [stderr] 169 | | process::exit(0x0100); [INFO] [stderr] ... | [INFO] [stderr] 182 | | }, [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_beeline.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_beeline.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 33 | | Ok(v) => v, [INFO] [stderr] 34 | | Err(e) => { [INFO] [stderr] 35 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 36 | | (0, 0) [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_beeline.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_beeline.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_kamgb.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_kamgb.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 32 | | Ok(v) => v, [INFO] [stderr] 33 | | Err(e) => { [INFO] [stderr] 34 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 35 | | (0, 0) [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_kamgb.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_kamgb.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_megafon.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_megafon.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 35 | | Ok(v) => v, [INFO] [stderr] 36 | | Err(e) => { [INFO] [stderr] 37 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 38 | | (0, 0) [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_megafon.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_megafon.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_mts.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_mts.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 29 | | Ok(v) => v, [INFO] [stderr] 30 | | Err(e) => { [INFO] [stderr] 31 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 32 | | (0, 0) [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_mts.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_mts.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_nefaz.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_nefaz.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 30 | | Ok(v) => v, [INFO] [stderr] 31 | | Err(e) => { [INFO] [stderr] 32 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 33 | | (0, 0) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_nefaz.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_nefaz.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_uds.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_uds.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 30 | | Ok(v) => v, [INFO] [stderr] 31 | | Err(e) => { [INFO] [stderr] 32 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 33 | | (0, 0) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_uds.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_uds.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tenders/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod tenders; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tenders.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tenders.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | let m = (tt)?; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tenders.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tenders.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | let m = (tt)?; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | dt [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let dt = match res { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | Ok(v) => { [INFO] [stderr] 15 | | let t = NaiveTime::from_hms(0, 0, 0); [INFO] [stderr] 16 | | let d = NaiveDateTime::new(v, t); [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | let m = match dtt.checked_sub_signed(Duration::hours(3)) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 19 | | Some(r) => Some(r), [INFO] [stderr] 20 | | None => None, [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | d [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let d = DateTime::parse_from_rfc3339("1970-01-01T00:00:00+03:00").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | dt [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let dt = d.with_timezone(&FixedOffset::east(3 * 3600)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let m = RegexTools::del_all_ws(&res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/regextools.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | rz [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/regextools.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | let rz = if cap.len() > 1 { [INFO] [stderr] | __________________^ [INFO] [stderr] 22 | | let r = &cap[1]; [INFO] [stderr] 23 | | Some(r.to_string()) [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | None [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/toolslib/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod toolslib; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parsers/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod parsers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/parsers/parsers.rs:2:26 [INFO] [stderr] | [INFO] [stderr] 2 | fn parser(&mut self) -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/settings/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod settings; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let s = FullSettingsParser { [INFO] [stderr] | _____________^ [INFO] [stderr] 73 | | database: set.database, [INFO] [stderr] 74 | | userdb: set.userdb, [INFO] [stderr] 75 | | passdb: set.passdb, [INFO] [stderr] ... | [INFO] [stderr] 79 | | log, [INFO] [stderr] 80 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/settings/settings.rs:138:22 [INFO] [stderr] | [INFO] [stderr] 138 | fn create_argument() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | k [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let k = ARGUMENT.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/settings/settings.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | a [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/settings/settings.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | let a = match matches.value_of("argument") { [INFO] [stderr] | _____________^ [INFO] [stderr] 167 | | None => { [INFO] [stderr] 168 | | println!("empty argument, use -h for help"); [INFO] [stderr] 169 | | process::exit(0x0100); [INFO] [stderr] ... | [INFO] [stderr] 182 | | }, [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_beeline.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_beeline.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 33 | | Ok(v) => v, [INFO] [stderr] 34 | | Err(e) => { [INFO] [stderr] 35 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 36 | | (0, 0) [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_beeline.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_beeline.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_kamgb.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_kamgb.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 32 | | Ok(v) => v, [INFO] [stderr] 33 | | Err(e) => { [INFO] [stderr] 34 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 35 | | (0, 0) [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_kamgb.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_kamgb.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_megafon.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_megafon.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 35 | | Ok(v) => v, [INFO] [stderr] 36 | | Err(e) => { [INFO] [stderr] 37 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 38 | | (0, 0) [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_megafon.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_megafon.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_mts.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_mts.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 29 | | Ok(v) => v, [INFO] [stderr] 30 | | Err(e) => { [INFO] [stderr] 31 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 32 | | (0, 0) [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_mts.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_mts.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_nefaz.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_nefaz.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 30 | | Ok(v) => v, [INFO] [stderr] 31 | | Err(e) => { [INFO] [stderr] 32 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 33 | | (0, 0) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_nefaz.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_nefaz.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tender_uds.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tender_uds.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | let res = match self.parser_unwrap() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 30 | | Ok(v) => v, [INFO] [stderr] 31 | | Err(e) => { [INFO] [stderr] 32 | | warn!("{} {}", e, e.description()); [INFO] [stderr] 33 | | (0, 0) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_uds.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tenders/tender_uds.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | return Ok(res_insert.last_insert_id()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res_insert.last_insert_id())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/tenders/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub mod tenders; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tenders.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tenders.rs:41:37 [INFO] [stderr] | [INFO] [stderr] 41 | let m = (tt)?; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tenders/tenders.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tenders/tenders.rs:50:37 [INFO] [stderr] | [INFO] [stderr] 50 | let m = (tt)?; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | dt [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:13:18 [INFO] [stderr] | [INFO] [stderr] 13 | let dt = match res { [INFO] [stderr] | __________________^ [INFO] [stderr] 14 | | Ok(v) => { [INFO] [stderr] 15 | | let t = NaiveTime::from_hms(0, 0, 0); [INFO] [stderr] 16 | | let d = NaiveDateTime::new(v, t); [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | let m = match dtt.checked_sub_signed(Duration::hours(3)) { [INFO] [stderr] | _________________________^ [INFO] [stderr] 19 | | Some(r) => Some(r), [INFO] [stderr] 20 | | None => None, [INFO] [stderr] 21 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | d [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | let d = DateTime::parse_from_rfc3339("1970-01-01T00:00:00+03:00").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | dt [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | let dt = d.with_timezone(&FixedOffset::east(3 * 3600)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/datetimetools.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | m [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/datetimetools.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | let m = RegexTools::del_all_ws(&res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/toolslib/regextools.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | rz [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/toolslib/regextools.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | let rz = if cap.len() > 1 { [INFO] [stderr] | __________________^ [INFO] [stderr] 22 | | let r = &cap[1]; [INFO] [stderr] 23 | | Some(r.to_string()) [INFO] [stderr] 24 | | } else { [INFO] [stderr] 25 | | None [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/toolslib/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub mod toolslib; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parsers/parser_uds.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | .unwrap_or("01.01.1970".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "01.01.1970".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parsers/parsers.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | fn end_parsing(&self, add: &i32, upd: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parsers/parsers.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | fn end_parsing(&self, add: &i32, upd: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tenders/tender_beeline.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(format!("can not download page {}", &self.href))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("can not download page {}", &self.href))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tenders/tender_beeline.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / if x.text().contains("Тендер добавлен") { [INFO] [stderr] 51 | | true [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | false [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `x.text().contains("Тендер добавлен")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_beeline.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 74 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 75 | | return Ok((0, 0)); [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_beeline.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/tenders/tender_beeline.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / fn get_tender_id( [INFO] [stderr] 130 | | &self, [INFO] [stderr] 131 | | pool: &my::Pool, [INFO] [stderr] 132 | | id_organizer: &u64, [INFO] [stderr] ... | [INFO] [stderr] 141 | | return Ok(res_insert.last_insert_id()); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_beeline.rs:154:27 [INFO] [stderr] | [INFO] [stderr] 154 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:163:54 [INFO] [stderr] | [INFO] [stderr] 163 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_kamgb.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 47 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 48 | | return Ok((0, 0)); [INFO] [stderr] 49 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_kamgb.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_kamgb.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:132:54 [INFO] [stderr] | [INFO] [stderr] 132 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:145:61 [INFO] [stderr] | [INFO] [stderr] 145 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_megafon.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 50 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 51 | | return Ok((0, 0)); [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tenders/tender_megafon.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .ok_or(format!("can not download page {}", &self.href))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("can not download page {}", &self.href))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_megafon.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:110:23 [INFO] [stderr] | [INFO] [stderr] 110 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_megafon.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:146:22 [INFO] [stderr] | [INFO] [stderr] 146 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | id_tender: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tenders/tender_megafon.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / if x.text().contains("Скачать документацию") { [INFO] [stderr] 160 | | true [INFO] [stderr] 161 | | } else { [INFO] [stderr] 162 | | false [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `x.text().contains("Скачать документацию")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_mts.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 44 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 45 | | return Ok((0, 0)); [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_mts.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_mts.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_nefaz.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 45 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 46 | | return Ok((0, 0)); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_nefaz.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_nefaz.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:128:54 [INFO] [stderr] | [INFO] [stderr] 128 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:142:61 [INFO] [stderr] | [INFO] [stderr] 142 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_uds.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 45 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 46 | | return Ok((0, 0)); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_uds.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_uds.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:130:54 [INFO] [stderr] | [INFO] [stderr] 130 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:134:61 [INFO] [stderr] | [INFO] [stderr] 134 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tenders.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | id_tender: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tenders/tenders.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pur_num: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for r in res.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tenders/tenders.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | pur_num: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for r in res.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | for r_po in res_po.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_po` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for r_att in res_att.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_att` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | for r_ten in res_ten.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_ten` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:167:27 [INFO] [stderr] | [INFO] [stderr] 167 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:176:27 [INFO] [stderr] | [INFO] [stderr] 176 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | for r_org in res_org.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_org` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | for r_cus in res_cus.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_cus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:217:27 [INFO] [stderr] | [INFO] [stderr] 217 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/toolslib/regextools.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn del_double_ws(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/toolslib/regextools.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn del_all_ws(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/toolslib/toolslib.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn find_from_child_text<'a, 'b, T: Predicate>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/toolslib/toolslib.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | while let Some(n) = find.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for n in find { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/toolslib/toolslib.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | while let Some(n) = res.next() { [INFO] [stderr] | ^^^^^^^^^^ help: try: `for n in res { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parsers/parser_uds.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | .unwrap_or("01.01.1970".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "01.01.1970".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parsers/parsers.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | fn end_parsing(&self, add: &i32, upd: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parsers/parsers.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | fn end_parsing(&self, add: &i32, upd: &i32) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tenders/tender_beeline.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | .ok_or(format!("can not download page {}", &self.href))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("can not download page {}", &self.href))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tenders/tender_beeline.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / if x.text().contains("Тендер добавлен") { [INFO] [stderr] 51 | | true [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | false [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `x.text().contains("Тендер добавлен")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_beeline.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 74 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 75 | | return Ok((0, 0)); [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_beeline.rs:116:27 [INFO] [stderr] | [INFO] [stderr] 116 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/tenders/tender_beeline.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / fn get_tender_id( [INFO] [stderr] 130 | | &self, [INFO] [stderr] 131 | | pool: &my::Pool, [INFO] [stderr] 132 | | id_organizer: &u64, [INFO] [stderr] ... | [INFO] [stderr] 141 | | return Ok(res_insert.last_insert_id()); [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:134:17 [INFO] [stderr] | [INFO] [stderr] 134 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:136:24 [INFO] [stderr] | [INFO] [stderr] 136 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_beeline.rs:154:27 [INFO] [stderr] | [INFO] [stderr] 154 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:163:54 [INFO] [stderr] | [INFO] [stderr] 163 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_beeline.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_kamgb.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 47 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 48 | | return Ok((0, 0)); [INFO] [stderr] 49 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_kamgb.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:105:25 [INFO] [stderr] | [INFO] [stderr] 105 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:108:24 [INFO] [stderr] | [INFO] [stderr] 108 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_kamgb.rs:123:27 [INFO] [stderr] | [INFO] [stderr] 123 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:132:54 [INFO] [stderr] | [INFO] [stderr] 132 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:140:22 [INFO] [stderr] | [INFO] [stderr] 140 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_kamgb.rs:145:61 [INFO] [stderr] | [INFO] [stderr] 145 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_megafon.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 50 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 51 | | return Ok((0, 0)); [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tenders/tender_megafon.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | .ok_or(format!("can not download page {}", &self.href))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("can not download page {}", &self.href))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_megafon.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:110:23 [INFO] [stderr] | [INFO] [stderr] 110 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:114:24 [INFO] [stderr] | [INFO] [stderr] 114 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_megafon.rs:129:27 [INFO] [stderr] | [INFO] [stderr] 129 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:138:54 [INFO] [stderr] | [INFO] [stderr] 138 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:146:22 [INFO] [stderr] | [INFO] [stderr] 146 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_megafon.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | id_tender: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tenders/tender_megafon.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / if x.text().contains("Скачать документацию") { [INFO] [stderr] 160 | | true [INFO] [stderr] 161 | | } else { [INFO] [stderr] 162 | | false [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `x.text().contains("Скачать документацию")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_mts.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 44 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 45 | | return Ok((0, 0)); [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_mts.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:105:23 [INFO] [stderr] | [INFO] [stderr] 105 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:106:25 [INFO] [stderr] | [INFO] [stderr] 106 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:109:24 [INFO] [stderr] | [INFO] [stderr] 109 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_mts.rs:125:27 [INFO] [stderr] | [INFO] [stderr] 125 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:135:54 [INFO] [stderr] | [INFO] [stderr] 135 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_mts.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_nefaz.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 45 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 46 | | return Ok((0, 0)); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_nefaz.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:102:25 [INFO] [stderr] | [INFO] [stderr] 102 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_nefaz.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:128:54 [INFO] [stderr] | [INFO] [stderr] 128 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_nefaz.rs:142:61 [INFO] [stderr] | [INFO] [stderr] 142 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tenders/tender_uds.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | if let Some(_) = query_res.next() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 45 | | //info!("this tender exist in base, pur_num {}", &self.pur_num); [INFO] [stderr] 46 | | return Ok((0, 0)); [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________- help: try this: `if query_res.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_uds.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | id_organizer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | id_placing_way: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | id_etp: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:106:24 [INFO] [stderr] | [INFO] [stderr] 106 | cancel_status: &i32, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tender_uds.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:130:54 [INFO] [stderr] | [INFO] [stderr] 130 | fn get_lot_id(&self, pool: &my::Pool, id_tender: &u64) -> Result> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:134:61 [INFO] [stderr] | [INFO] [stderr] 134 | fn insert_attachment(&self, pool: &my::Pool, id_tender: &u64) -> Result<(), Box> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | id_lot: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tender_uds.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | id_customer: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tenders/tenders.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | id_tender: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tenders/tenders.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | pur_num: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | for r in res.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:85:27 [INFO] [stderr] | [INFO] [stderr] 85 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tenders/tenders.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | pur_num: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:104:18 [INFO] [stderr] | [INFO] [stderr] 104 | for r in res.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | .and_then(|x| my::from_value_opt::(x))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | for r_po in res_po.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_po` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:132:27 [INFO] [stderr] | [INFO] [stderr] 132 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for r_att in res_att.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_att` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | for r_ten in res_ten.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_ten` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:167:27 [INFO] [stderr] | [INFO] [stderr] 167 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:176:27 [INFO] [stderr] | [INFO] [stderr] 176 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:183:30 [INFO] [stderr] | [INFO] [stderr] 183 | for r_org in res_org.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_org` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:193:35 [INFO] [stderr] | [INFO] [stderr] 193 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tenders/tenders.rs:207:22 [INFO] [stderr] | [INFO] [stderr] 207 | for r_cus in res_cus.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `res_cus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tenders/tenders.rs:217:27 [INFO] [stderr] | [INFO] [stderr] 217 | .and_then(|x| my::from_value_opt::(x)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `my::from_value_opt::` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/toolslib/regextools.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn del_double_ws(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/toolslib/regextools.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn del_all_ws(s: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/toolslib/toolslib.rs:15:33 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn find_from_child_text<'a, 'b, T: Predicate>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/toolslib/toolslib.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | while let Some(n) = find.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for n in find { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/toolslib/toolslib.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | while let Some(n) = res.next() { [INFO] [stderr] | ^^^^^^^^^^ help: try: `for n in res { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.40s [INFO] running `"docker" "inspect" "84f0e617c71b885d32be7f3f2031009bf74169965bfe1d985160598134e92fa0"` [INFO] running `"docker" "rm" "-f" "84f0e617c71b885d32be7f3f2031009bf74169965bfe1d985160598134e92fa0"` [INFO] [stdout] 84f0e617c71b885d32be7f3f2031009bf74169965bfe1d985160598134e92fa0