[INFO] updating cached repository ruggeri/my-first-server
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ruggeri/my-first-server
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ruggeri/my-first-server" "work/ex/clippy-test-run/sources/stable/gh/ruggeri/my-first-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ruggeri/my-first-server'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ruggeri/my-first-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/my-first-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/my-first-server'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fcfa000269d76376a31d7f75a205285d11716165
[INFO] sha for GitHub repo ruggeri/my-first-server: fcfa000269d76376a31d7f75a205285d11716165
[INFO] validating manifest of ruggeri/my-first-server on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ruggeri/my-first-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ruggeri/my-first-server
[INFO] finished frobbing ruggeri/my-first-server
[INFO] frobbed toml for ruggeri/my-first-server written to work/ex/clippy-test-run/sources/stable/gh/ruggeri/my-first-server/Cargo.toml
[INFO] started frobbing ruggeri/my-first-server
[INFO] finished frobbing ruggeri/my-first-server
[INFO] frobbed toml for ruggeri/my-first-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/my-first-server/Cargo.toml
[INFO] crate ruggeri/my-first-server has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ruggeri/my-first-server against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ruggeri/my-first-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 83ac81a33448c70bf88365bcf1a3b8c42b0f5097bd97168fb0b1540692a85b16
[INFO] running `"docker" "start" "-a" "83ac81a33448c70bf88365bcf1a3b8c42b0f5097bd97168fb0b1540692a85b16"`
[INFO] [stderr]     Checking my-first-server v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/worker_manager.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     manager
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/worker_manager.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |       let manager = WorkerManager {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 26 | |       tx,
[INFO] [stderr] 27 | |       worker: Arc::new(worker),
[INFO] [stderr] 28 | |       work_count,
[INFO] [stderr] 29 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/worker_manager.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     manager
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/worker_manager.rs:25:19
[INFO] [stderr]    |
[INFO] [stderr] 25 |       let manager = WorkerManager {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 26 | |       tx,
[INFO] [stderr] 27 | |       worker: Arc::new(worker),
[INFO] [stderr] 28 | |       work_count,
[INFO] [stderr] 29 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `worker_manager::WorkerManager`
[INFO] [stderr]   --> src/worker_manager.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 | /   pub fn new() -> WorkerManager {
[INFO] [stderr] 20 | |     let (tx, rx) = channel::unbounded::<WorkMessage>();
[INFO] [stderr] 21 | |     let work_count = Arc::new(Mutex::new(0));
[INFO] [stderr] 22 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |     manager
[INFO] [stderr] 32 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for worker_manager::WorkerManager {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let work_count = Arc::new(Mutex::new(0));
[INFO] [stderr]    |                               ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |       let mut work_count = (*work_count).lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:47:26
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut work_count = (*self.work_count).lock().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:80:6
[INFO] [stderr]    |
[INFO] [stderr] 80 |     *(*self.work_count).lock().unwrap()
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `worker_manager::WorkerManager`
[INFO] [stderr]   --> src/worker_manager.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 | /   pub fn new() -> WorkerManager {
[INFO] [stderr] 20 | |     let (tx, rx) = channel::unbounded::<WorkMessage>();
[INFO] [stderr] 21 | |     let work_count = Arc::new(Mutex::new(0));
[INFO] [stderr] 22 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 31 | |     manager
[INFO] [stderr] 32 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 | impl Default for worker_manager::WorkerManager {
[INFO] [stderr] 19 |     fn default() -> Self {
[INFO] [stderr] 20 |         Self::new()
[INFO] [stderr] 21 |     }
[INFO] [stderr] 22 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:21:31
[INFO] [stderr]    |
[INFO] [stderr] 21 |     let work_count = Arc::new(Mutex::new(0));
[INFO] [stderr]    |                               ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |       let mut work_count = (*work_count).lock().unwrap();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:47:26
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut work_count = (*self.work_count).lock().unwrap();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/worker_manager.rs:80:6
[INFO] [stderr]    |
[INFO] [stderr] 80 |     *(*self.work_count).lock().unwrap()
[INFO] [stderr]    |      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/bin/main.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 | /   for stream in listener.incoming() {
[INFO] [stderr] 31 | |     let stream = stream?;
[INFO] [stderr] 32 | |
[INFO] [stderr] 33 | |     let work = move || {
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |     break;
[INFO] [stderr] 43 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `my-first-server`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]   --> src/bin/main.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 | /   for stream in listener.incoming() {
[INFO] [stderr] 31 | |     let stream = stream?;
[INFO] [stderr] 32 | |
[INFO] [stderr] 33 | |     let work = move || {
[INFO] [stderr] ...  |
[INFO] [stderr] 42 | |     break;
[INFO] [stderr] 43 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `my-first-server`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "83ac81a33448c70bf88365bcf1a3b8c42b0f5097bd97168fb0b1540692a85b16"`
[INFO] running `"docker" "rm" "-f" "83ac81a33448c70bf88365bcf1a3b8c42b0f5097bd97168fb0b1540692a85b16"`
[INFO] [stdout] 83ac81a33448c70bf88365bcf1a3b8c42b0f5097bd97168fb0b1540692a85b16