[INFO] updating cached repository ruggeri/fourier2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ruggeri/fourier2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ruggeri/fourier2" "work/ex/clippy-test-run/sources/stable/gh/ruggeri/fourier2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ruggeri/fourier2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ruggeri/fourier2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/fourier2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/fourier2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 55cbdfe0fbff1825298827d0653d48f1a02fc8bf [INFO] sha for GitHub repo ruggeri/fourier2: 55cbdfe0fbff1825298827d0653d48f1a02fc8bf [INFO] validating manifest of ruggeri/fourier2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ruggeri/fourier2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ruggeri/fourier2 [INFO] finished frobbing ruggeri/fourier2 [INFO] frobbed toml for ruggeri/fourier2 written to work/ex/clippy-test-run/sources/stable/gh/ruggeri/fourier2/Cargo.toml [INFO] started frobbing ruggeri/fourier2 [INFO] finished frobbing ruggeri/fourier2 [INFO] frobbed toml for ruggeri/fourier2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ruggeri/fourier2/Cargo.toml [INFO] crate ruggeri/fourier2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ruggeri/fourier2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ruggeri/fourier2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cfb54191246af73d7240fd4d4ac16b837f898e6bcdc22bb3d01ece076e6bbab4 [INFO] running `"docker" "start" "-a" "cfb54191246af73d7240fd4d4ac16b837f898e6bcdc22bb3d01ece076e6bbab4"` [INFO] [stderr] Checking rand_core v0.2.0 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking fourier2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(float_cmp)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(float_cmp)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(float_cmp)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | #[allow(float_cmp)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/core/pitch_class.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn semitones_above_a(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/core/pitch_class.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn base_freq(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib/transforms/fourier.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn ftransform<'a, AS>( [INFO] [stderr] 17 | | freq: f64, [INFO] [stderr] 18 | | source: &'a AS, [INFO] [stderr] 19 | | window_center: f64, [INFO] [stderr] ... | [INFO] [stderr] 50 | | (sin_amplitude, cos_amplitude) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / loop { [INFO] [stderr] 51 | | if let Some(item) = self.iter.peek() { [INFO] [stderr] 52 | | #[allow(float_cmp)] [INFO] [stderr] 53 | | match time { [INFO] [stderr] ... | [INFO] [stderr] 63 | | group.push(self.iter.next().unwrap()); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = self.iter.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/core/pitch_class.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn semitones_above_a(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib/core/pitch_class.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn base_freq(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib/transforms/fourier.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn ftransform<'a, AS>( [INFO] [stderr] 17 | | freq: f64, [INFO] [stderr] 18 | | source: &'a AS, [INFO] [stderr] 19 | | window_center: f64, [INFO] [stderr] ... | [INFO] [stderr] 50 | | (sin_amplitude, cos_amplitude) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib/transforms/pitch_smoothing.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | / loop { [INFO] [stderr] 51 | | if let Some(item) = self.iter.peek() { [INFO] [stderr] 52 | | #[allow(float_cmp)] [INFO] [stderr] 53 | | match time { [INFO] [stderr] ... | [INFO] [stderr] 63 | | group.push(self.iter.next().unwrap()); [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = self.iter.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/cli/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(label_break_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `fourier2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/cli/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(label_break_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `fourier2`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cfb54191246af73d7240fd4d4ac16b837f898e6bcdc22bb3d01ece076e6bbab4"` [INFO] running `"docker" "rm" "-f" "cfb54191246af73d7240fd4d4ac16b837f898e6bcdc22bb3d01ece076e6bbab4"` [INFO] [stdout] cfb54191246af73d7240fd4d4ac16b837f898e6bcdc22bb3d01ece076e6bbab4