[INFO] updating cached repository rudolphalmeida/raytrac [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rudolphalmeida/raytrac [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rudolphalmeida/raytrac" "work/ex/clippy-test-run/sources/stable/gh/rudolphalmeida/raytrac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rudolphalmeida/raytrac'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rudolphalmeida/raytrac" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rudolphalmeida/raytrac"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rudolphalmeida/raytrac'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d12c5dd5691122ef3f4de14fd3774e631b31094 [INFO] sha for GitHub repo rudolphalmeida/raytrac: 6d12c5dd5691122ef3f4de14fd3774e631b31094 [INFO] validating manifest of rudolphalmeida/raytrac on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rudolphalmeida/raytrac on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rudolphalmeida/raytrac [INFO] finished frobbing rudolphalmeida/raytrac [INFO] frobbed toml for rudolphalmeida/raytrac written to work/ex/clippy-test-run/sources/stable/gh/rudolphalmeida/raytrac/Cargo.toml [INFO] started frobbing rudolphalmeida/raytrac [INFO] finished frobbing rudolphalmeida/raytrac [INFO] frobbed toml for rudolphalmeida/raytrac written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rudolphalmeida/raytrac/Cargo.toml [INFO] crate rudolphalmeida/raytrac has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rudolphalmeida/raytrac against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rudolphalmeida/raytrac:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adbff1b3b0532977cac9ac59267204d0ad9d9dce322faf517c31c7e0966071a1 [INFO] running `"docker" "start" "-a" "adbff1b3b0532977cac9ac59267204d0ad9d9dce322faf517c31c7e0966071a1"` [INFO] [stderr] Checking termios v0.3.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking indicatif v0.7.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking raytrac v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:41:25 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let i = p.x.floor(); [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:55:22 [INFO] [stderr] | [INFO] [stderr] 55 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/moving_sphere.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/objects/moving_sphere.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let (u, v) = super::get_sphere_uv((point - center) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let j = p.y.floor(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let k = p.z.floor(); [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:41:25 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] 41 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let mut c: [[[Vector3; 2]; 2]; 2] = [ [INFO] [stderr] | ^ [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] | [INFO] [stderr] --> src/objects/sphere.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/objects/sphere.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | let (u, v) = super::get_sphere_uv((point - self.center.to_vec()) / self.radius); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let i = p.x.floor(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let j = p.y.floor(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | let k = p.z.floor(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/textures/noise_texture.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let mut c: [[[Vector3; 2]; 2]; 2] = [ [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | hittable: Option<&'a Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Hittable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | fn new_leaf(&mut self, hitable: &'a Box, time0: f64, time1: f64) -> NodeId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | fn box_x_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:156:40 [INFO] [stderr] | [INFO] [stderr] 156 | fn box_x_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | fn box_y_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:170:40 [INFO] [stderr] | [INFO] [stderr] 170 | fn box_y_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | fn box_z_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:184:40 [INFO] [stderr] | [INFO] [stderr] 184 | fn box_z_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | hittable: Option<&'a Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Hittable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `textures::noise_texture::Perlin` [INFO] [stderr] --> src/textures/noise_texture.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Perlin { [INFO] [stderr] 19 | | ranvec: Perlin::perlin_generate(), [INFO] [stderr] 20 | | perm_x: Perlin::perlin_generate_perm(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:129:37 [INFO] [stderr] | [INFO] [stderr] 129 | fn new_leaf(&mut self, hitable: &'a Box, time0: f64, time1: f64) -> NodeId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | fn box_x_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:156:40 [INFO] [stderr] | [INFO] [stderr] 156 | fn box_x_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | fn box_y_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:170:40 [INFO] [stderr] | [INFO] [stderr] 170 | fn box_y_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | fn box_z_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/bvh.rs:184:40 [INFO] [stderr] | [INFO] [stderr] 184 | fn box_z_compare(a: &Box, b: &Box, time0: f64, time1: f64) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: the loop variable `di` is used to index `c` [INFO] [stderr] --> src/textures/noise_texture.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | for di in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for (di, ) in c.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/textures/noise_texture.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in c.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `textures::noise_texture::Perlin` [INFO] [stderr] --> src/textures/noise_texture.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Perlin { [INFO] [stderr] 19 | | ranvec: Perlin::perlin_generate(), [INFO] [stderr] 20 | | perm_x: Perlin::perlin_generate_perm(), [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `di` is used to index `c` [INFO] [stderr] --> src/textures/noise_texture.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | for di in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for (di, ) in c.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/textures/noise_texture.rs:137:14 [INFO] [stderr] | [INFO] [stderr] 137 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 137 | for (i, ) in c.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.20s [INFO] running `"docker" "inspect" "adbff1b3b0532977cac9ac59267204d0ad9d9dce322faf517c31c7e0966071a1"` [INFO] running `"docker" "rm" "-f" "adbff1b3b0532977cac9ac59267204d0ad9d9dce322faf517c31c7e0966071a1"` [INFO] [stdout] adbff1b3b0532977cac9ac59267204d0ad9d9dce322faf517c31c7e0966071a1