[INFO] updating cached repository rubberduck203/cryptopals-challenges [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rubberduck203/cryptopals-challenges [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rubberduck203/cryptopals-challenges" "work/ex/clippy-test-run/sources/stable/gh/rubberduck203/cryptopals-challenges"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rubberduck203/cryptopals-challenges'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rubberduck203/cryptopals-challenges" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rubberduck203/cryptopals-challenges"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rubberduck203/cryptopals-challenges'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22317fde2c5029601e86e5353ce2a9e3d3383866 [INFO] sha for GitHub repo rubberduck203/cryptopals-challenges: 22317fde2c5029601e86e5353ce2a9e3d3383866 [INFO] validating manifest of rubberduck203/cryptopals-challenges on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rubberduck203/cryptopals-challenges on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rubberduck203/cryptopals-challenges [INFO] finished frobbing rubberduck203/cryptopals-challenges [INFO] frobbed toml for rubberduck203/cryptopals-challenges written to work/ex/clippy-test-run/sources/stable/gh/rubberduck203/cryptopals-challenges/Cargo.toml [INFO] started frobbing rubberduck203/cryptopals-challenges [INFO] finished frobbing rubberduck203/cryptopals-challenges [INFO] frobbed toml for rubberduck203/cryptopals-challenges written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rubberduck203/cryptopals-challenges/Cargo.toml [INFO] crate rubberduck203/cryptopals-challenges has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rubberduck203/cryptopals-challenges against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rubberduck203/cryptopals-challenges:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8337621caa9de49fe71f846820f26b28706161733e3e8ac250a44ef0def48ea7 [INFO] running `"docker" "start" "-a" "8337621caa9de49fe71f846820f26b28706161733e3e8ac250a44ef0def48ea7"` [INFO] [stderr] Compiling cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frequency.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | None => 0.0000001, //non-zero, but tiny possibility [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frequency.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | None => 0.0000001, //non-zero, but tiny possibility [INFO] [stderr] | ^^^^^^^^^ help: consider: `0.000_000_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | .map(|(k, freq)| (k.clone() as char, (freq / 100.0) * (message.len() as f32))) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | Some(x) => x.clone() + 1, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/frequency.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | Some(x) => x.clone() as f32, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:8:27 [INFO] [stderr] | [INFO] [stderr] 8 | .map(|(k, freq)| (k.clone() as char, (freq / 100.0) * (message.len() as f32))) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | Some(x) => x.clone() + 1, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the HashMap [INFO] [stderr] --> src/frequency.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frequency.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | Some(x) => x.clone() as f32, [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / alphabet [INFO] [stderr] 40 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `alphabet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / alphabet [INFO] [stderr] 40 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `alphabet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "8337621caa9de49fe71f846820f26b28706161733e3e8ac250a44ef0def48ea7"` [INFO] running `"docker" "rm" "-f" "8337621caa9de49fe71f846820f26b28706161733e3e8ac250a44ef0def48ea7"` [INFO] [stdout] 8337621caa9de49fe71f846820f26b28706161733e3e8ac250a44ef0def48ea7