[INFO] updating cached repository rtroxler/assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rtroxler/assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rtroxler/assembler" "work/ex/clippy-test-run/sources/stable/gh/rtroxler/assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rtroxler/assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rtroxler/assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rtroxler/assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rtroxler/assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c493fd729170dfba6856537bd71d0b4cc3c5a3b [INFO] sha for GitHub repo rtroxler/assembler: 8c493fd729170dfba6856537bd71d0b4cc3c5a3b [INFO] validating manifest of rtroxler/assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rtroxler/assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rtroxler/assembler [INFO] finished frobbing rtroxler/assembler [INFO] frobbed toml for rtroxler/assembler written to work/ex/clippy-test-run/sources/stable/gh/rtroxler/assembler/Cargo.toml [INFO] started frobbing rtroxler/assembler [INFO] finished frobbing rtroxler/assembler [INFO] frobbed toml for rtroxler/assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rtroxler/assembler/Cargo.toml [INFO] crate rtroxler/assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rtroxler/assembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/rtroxler/assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3966ee770344f91b8f8a20f6c7a71c1574e04fe07f2485df695ef159a67dffe [INFO] running `"docker" "start" "-a" "e3966ee770344f91b8f8a20f6c7a71c1574e04fe07f2485df695ef159a67dffe"` [INFO] [stderr] Checking assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | dest_map: dest_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dest_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | jump_map: jump_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | comp_map: comp_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comp_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/a_instruction.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | AInstruction { line: line } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/instruction/a_instruction.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | write!(output, "{:016b}\n", self.symbol().parse::().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | c_instr: c_instr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `c_instr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | write!(output, "{}\n", self.dest_comp_jump_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/l_instruction.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | LInstruction { line: line } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | Parser { filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | dest_map: dest_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dest_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | jump_map: jump_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `jump_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/c_instruction_translator.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | comp_map: comp_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `comp_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/a_instruction.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | AInstruction { line: line } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/instruction/a_instruction.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | write!(output, "{:016b}\n", self.symbol().parse::().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | c_instr: c_instr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `c_instr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/instruction/c_instruction.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | write!(output, "{}\n", self.dest_comp_jump_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/instruction/l_instruction.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | LInstruction { line: line } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | Parser { filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | let output_filename = self.filename.split(".").nth(0).unwrap().to_owned() + ".hack"; [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | if self.line.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | } else if self.line.starts_with("(") && self.line.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:84:69 [INFO] [stderr] | [INFO] [stderr] 84 | } else if self.line.starts_with("(") && self.line.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | let output_filename = self.filename.split(".").nth(0).unwrap().to_owned() + ".hack"; [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:82:34 [INFO] [stderr] | [INFO] [stderr] 82 | if self.line.starts_with("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | } else if self.line.starts_with("(") && self.line.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/mod.rs:84:69 [INFO] [stderr] | [INFO] [stderr] 84 | } else if self.line.starts_with("(") && self.line.ends_with(")") { [INFO] [stderr] | ^^^ help: try using a char instead: `')'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `"docker" "inspect" "e3966ee770344f91b8f8a20f6c7a71c1574e04fe07f2485df695ef159a67dffe"` [INFO] running `"docker" "rm" "-f" "e3966ee770344f91b8f8a20f6c7a71c1574e04fe07f2485df695ef159a67dffe"` [INFO] [stdout] e3966ee770344f91b8f8a20f6c7a71c1574e04fe07f2485df695ef159a67dffe